Flag account-based chains with hasStableAddresses - #1076
Draft
j0ntz wants to merge 1 commit into
Draft
Conversation
Every plugin here derives its receive address once from the key and never rotates it, so a previously shown address stays valid and reuse-safe. Setting hasStableAddresses on each currencyInfo lets the core serve the cached address before the engine loads and lets the receive scene reconcile it, giving these chains an instant receive screen on a warm login. Needs the edge-core-js version that defines the field.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Sets
hasStableAddresses: trueon every account-based currency plugin. These chains derive their receive address once from the key and never rotate it, so a previously shown address stays valid and reuse-safe.This lets edge-core-js serve a wallet's cached receive address before the engine loads, and lets the edge-react-gui receive scene reconcile it, giving these chains an instant receive screen on a warm login (Login Perf - Wallet Cache, phase 6).
Scope
hasStableAddresses: trueadded to 63currencyInfoliterals across: all EVM chains, Solana, XRP, Stellar, Tezos, Tron, Algorand, Hedera, EOS/Telos/WAX, FIO, all Cosmos chains, Cardano, all Polkadot chains, Ton, Sui, Filecoin, Binance, Zcash, and Piratechain. Monero and Zano (privacy chains) are included: their primary address is static and reuse-safe by CryptoNote stealth-address design. Reviewer confirmation on the Monero/Zano inclusion is welcome.Dependency
Depends on
edge-core-jsadding the optionalEdgeCurrencyInfo.hasStableAddressesfield (EdgeApp/edge-core-js#733). This PR is a draft and will failtscuntil that dependency publishes and is bumped here.Asana: https://app.asana.com/0/1215088146871429/1216673467164267