Skip to content

Wrap fiat value in parens on Stake amount tile #6093

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
j0ntz wants to merge 2 commits into from
+13 −11
Closed

Wrap fiat value in parens on Stake amount tile #6093

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
d672328
Fix lint warnings in EditableAmountTile
j0ntz Jul 24, 2026
bf88456
Wrap fiat value in parens on Stake amount tile
j0ntz Jul 24, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,6 +2,8 @@

## Unreleased (develop)

- fixed: Wrap the fiat value in parentheses on the Stake/Unstake/Claim amount row.

## 4.50.0 (2026-07-21)

- added: Changelly swap provider
Expand Down
2 changes: 1 addition & 1 deletion eslint.config.mjs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -401,7 +401,7 @@ export default [
'src/components/tiles/AprCard.tsx',
'src/components/tiles/CountdownTile.tsx',
'src/components/tiles/CryptoFiatAmountTile.tsx',
'src/components/tiles/EditableAmountTile.tsx',

'src/components/tiles/ErrorTile.tsx',
'src/components/tiles/FiatAmountTile.tsx',
'src/components/tiles/InterestRateChangeTile.tsx',
Expand Down
14 changes: 7 additions & 7 deletions src/__tests__/scenes/__snapshots__/SendScene2.ui.test.tsx.snap
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -925,7 +925,7 @@ exports[`SendScene2 1 spendTarget 1`] = `
]
}
>
€ 0.23
(€ 0.23)
</Text>
</View>
<View
Expand Down Expand Up @@ -2703,7 +2703,7 @@ exports[`SendScene2 1 spendTarget with info tiles 1`] = `
]
}
>
€ 0.23
(€ 0.23)
</Text>
</View>
<View
Expand Down Expand Up @@ -4945,7 +4945,7 @@ exports[`SendScene2 2 spendTargets 1`] = `
]
}
>
€ 2.26
(€ 2.26)
</Text>
</View>
<View
Expand Down Expand Up @@ -6722,7 +6722,7 @@ exports[`SendScene2 2 spendTargets hide tiles 1`] = `
]
}
>
€ 2.26
(€ 2.26)
</Text>
</View>
<View
Expand Down Expand Up @@ -11382,7 +11382,7 @@ exports[`SendScene2 2 spendTargets lock tiles 1`] = `
]
}
>
€ 2.26
(€ 2.26)
</Text>
</View>
<View
Expand Down Expand Up @@ -13157,7 +13157,7 @@ exports[`SendScene2 2 spendTargets lock tiles 2`] = `
]
}
>
€ 2.26
(€ 2.26)
</Text>
</View>
</View>
Expand Down Expand Up @@ -14786,7 +14786,7 @@ exports[`SendScene2 2 spendTargets lock tiles 3`] = `
]
}
>
€ 2.26
(€ 2.26)
</Text>
</View>
</View>
Expand Down
6 changes: 3 additions & 3 deletions src/components/tiles/EditableAmountTile.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -29,7 +29,7 @@ interface Props {
onPress: () => void
}

export const EditableAmountTile = (props: Props) => {
export const EditableAmountTile: React.FC<Props> = props => {
let cryptoAmountSyntax
let cryptoAmountStyle
let fiatAmountSyntax
Expand Down Expand Up @@ -74,7 +74,7 @@ export const EditableAmountTile = (props: Props) => {
exchangeAmount
)
cryptoAmountSyntax = `${displayAmount ?? '0'} ${displayDenomination.name}`
if (fiatAmount) {
if (fiatAmount !== '') {
fiatAmountSyntax = `${fiatSymbol} ${
toFixed(round(fiatAmount, -2), 2, 2) ?? '0'
}`
Expand Down Expand Up @@ -119,7 +119,7 @@ export const EditableAmountTile = (props: Props) => {
{cryptoAmountSyntax}
</EdgeText>
{fiatAmountSyntax == null ? null : (
<EdgeText>{fiatAmountSyntax}</EdgeText>
<EdgeText>{`(${fiatAmountSyntax})`}</EdgeText>
)}
</EdgeRow>
</EdgeAnim>
Expand Down
Loading