Consolidate 12 small GUI tasks (4.51) - #6105
Merged
Merged
Conversation
|
You have reached your Codex usage limits for code reviews. You can see your limits in the Codex usage dashboard. |
Contributor
Author
📸 Test evidence (fiat spacing re-verification)stake fiat no space
Captured by the agent's in-app test run (build-and-test). |
This was referenced Jul 24, 2026
Appends a -m suffix to the version string shown in the Help modal when the app is a Maestro test build, so QA/devs can tell at a glance that a Maestro build is installed.
Replace the XRP reserve warning body text so it no longer implies a user must deposit 1 XRP in addition to their balance. The reserve is met once the address balance itself reaches 1 XRP.
The Wallets list row balance used the auto-expanding fiat precision meant for unit prices, showing up to 6 decimals for sub-$1 balances. Cap it at 2 decimals to match the wallet detail scene's rounding.
Add explicit React.FC return types and use the shared themed CloseIcon instead of importing react-native-vector-icons directly.
Give the alert drop-down's close button a testID so UI tests can dismiss it instead of tapping coordinates. Committing the file graduates it off the lint suppression list, so AlertDropdown also picks up its explicit React.FC type.
Previously only "Sign in" was colored as a tappable link; "Already have an account?" was dimmed even though the whole line is already one tap target.
The Nym Mix Net Assets list order followed plugin registration order, which differs between iOS and Android, producing inconsistent and non-alphabetical ordering on both platforms.
The Next button on CreateWalletSelectCryptoScene (shared by both the onboarding and logged-in "+" add-wallet flows) was double-absolutely positioned: SceneWrapper already renders dockProps.children inside its own absolutely-positioned, keyboard-aware dock, but the button itself was also given position:absolute via SceneButtons' absolute prop. That took the button out of the dock's layout flow, so the dock's measured height collapsed and the scene under-reserved scroll clearance for it, letting the button cover the last row(s) when scrolled to the end. The absolute prop was only forced on outside of Maestro, so automated UI tests exercised a different, correctly-docked layout and never caught the regression. Switch to KavButtons, the same primitive every other scene uses inside dockProps.children, and drop the now-unneeded manual paddingBottom compensation since the dock's real height is now measured correctly.
Switches from KavButtons (fullWidth) to EdgeButton with layout="solo", matching the button's original non-full-width appearance and letting EdgeButton's built-in usePendingPress hook manage the pending/error state instead of a hand-rolled scene state.
Regenerated the fontello 'custom' font from the designer SVGs attached to the task. The buy, sell, sort and control-panel-scan-qr glyphs are replaced with the updated artwork, and two new glyphs (list, chart) are added. The font is rebuilt through the fontello session API, which reproduces the existing custom.ttf byte for byte from the checked-in config, so the only outline changes are the six intended glyphs.
Also remove the space between the fiat symbol and the amount so it matches the network fee tile's formatting (useFiatText's default), and add the explicit React.FC return type.
Truncate the locked crypto amount with the shared getCryptoText helper so it uses the same exchange-rate-adjusted precision as the rest of the app, and drop the nested maxWidth clamps that limited the status text to roughly half the card width.
Replace the ad-hoc warning-color Paragraph on the Reveal Raw Keys and Reveal Master Private Key password confirmation modals with the AlertCardUi4 warning card. Also fold in the follow-up lint fixes: explicit return types, safe catch callback typing, and replacing the styled() inner view with a plain View + StyleSheet.
Freezing TRX buys bandwidth and energy rather than yield, and the claim action only returns the user's own unfrozen TRX to their spendable balance. Let a stake policy replace the default reward wording so the Tron policies read as reclaiming instead of earning.
Replace the popup error alert and generic "unknown error occurred" on the StakeModify scene with the real error surfaced in the existing on-scene error field. When the failure is insufficient funds during an unstake, show a clear message that the wallet needs a native-asset balance to cover the network fee.
j0ntz
force-pushed
the
jon/consolidate-small-gui-tasks-451
branch
from
July 27, 2026 18:37
ad61c36 to
28fb216
Compare
j0ntz
enabled auto-merge
July 27, 2026 18:37
![cursor[bot]](https://avatars.githubusercontent.com/in/1210556?s=60&v=4){kind=small}
There was a problem hiding this comment.
Cursor Bugbot has reviewed your changes using default effort and found 1 potential issue.
❌ Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, enable autofix in the Cursor dashboard.
Want higher recall? High effort reviews run extra passes and find more bugs. A team admin can switch effort levels in the Cursor dashboard.
Reviewed by Cursor Bugbot for commit 28fb216. Configure here.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
CHANGELOG
Does this branch warrant an entry to the CHANGELOG?
Dependencies
none
Requirements
If you have made any visual changes to the GUI. Make sure you have:
Description
Asana (umbrella): https://app.asana.com/1/9976422036640/project/1213880789473005/task/1216833234330851
Consolidates 12 small independent GUI fixes from 12 separate subtask branches/PRs into one branch, per the umbrella task's instructions. Each subtask's commits were cherry-picked in; two subtasks got an additional squashed-in fix for a new operator comment posted after the subtask's own agent run completed. The individual PRs listed below are being closed in favor of this one (see closing note on each).
-mon Maestro test builds.Not included: Change Username - Add warning copy (Asana) lives in
edge-login-ui-rn(#296), a different repo with no other subtask PRs to consolidate with, so it stays as its own PR. Its new operator comment ("wrap this warning message in a UI4 warning card") was addressed directly on that PR.Testing
tsc --noEmit, eslint (--quieton all changed files), and the full jest suite pass on every cherry-picked commit.Screenshots
Reused from each subtask's own PR (not re-driven), grouped by subtask.
Add "-m" (Maestro) tag to version number in "Help" scene
XRP - Minimum Balance Copy
Limit fiat amounts to 2 decimals in Wallets list
Fix Notification text shrinkage from Side Menu
USPs - Signin UI clarification 🩹
Privacy Settings - List Sorting Order
Create Wallet - Button Overlap
Add new custom icons
Put fiat value inside round brackets in Stake scene (re-verified in this branch)
Original:
After the no-space fix (this branch), verified via a hack-fabricated quote since the staking RPC is unreachable in this environment (also covered by an updated snapshot test —
€ 0.23→(€0.23)):Staked Funds - Text cutoff 🩹
UI4 - Warning Cards
Earn (TRX) - Rewards Language and UI
Earn - Improve Unstake Error 🩹
Note
Low Risk
Changes are mostly visual, copy, and localized staking UX; staking approve/error paths still use the same core wallet APIs with clearer on-screen messaging.
Overview
Bundles a dozen independent GUI polish items into one release branch.
Help & onboarding: Maestro builds show a
-msuffix on the version in Help. The getting-started carousel tints the full “Already have an account? Sign in” line with the tertiary link color.Lists & layout: Wallet list fiat values round to cents like wallet detail (
autoPrecision: false). Notification center cards use fixed text size with ellipsis instead of shrinking. Privacy Settings Nym asset list is sorted by display name. Choose Wallets to Add drops extra list bottom padding and uses a solo NextEdgeButtonso it no longer overlaps the list.Icons: Refreshed buy, sell, sort, scan-QR, and FIO names vector glyphs; side menu Markets uses a new custom chart icon instead of Font Awesome.
Staking / earn: Fiat on stake amount rows is shown as
(€0.23)(parentheses, no space after symbol). Locked staked balance on the wallet view truncates crypto decimals sensibly and drops width clamps that cut off text. Tron resource staking addsStakeClaimLanguageso claim UI says reclaim TRX instead of rewards. Unstake/approve errors surface in the scene viagetDisplayErrorMessage, with a specific message when native balance cannot cover the unstake network fee (no popup + generic unknown error).Copy & modals: XRP minimum-balance notification text clarifies the 1 XRP reserve. Password confirmation for Reveal Raw Keys / Master Private Key uses
AlertCardUi4instead of the legacy alert.Tests / tooling: New unit tests for
getDisplayErrorMessage; snapshot updates for modals, create-wallet list padding, and send/stake fiat formatting. ESLint allowlist trims a few files.Reviewed by Cursor Bugbot for commit 28fb216. Bugbot is set up for automated code reviews on this repo. Configure here.