NYM: label native network as Nyx instead of Nym - #6108
Merged
Conversation
|
You have reached your Codex usage limits for code reviews. You can see your limits in the Codex usage dashboard. |
Contributor
Author
📸 Test evidence (iOS sim)nyx network header
Captured by the agent's in-app test run (build-and-test). |
The wallet details scene network-context title used the deprecated
currencyInfo.displayName ('Nym'), rendering 'Nym Network'. Nym is the
asset and ecosystem name; the native chain is Nyx. Source the title from
chainDisplayName so it reads 'Nyx Network'. Asset-context labels are
unchanged.
j0ntz
force-pushed
the
jon/nym-network-label-nyx
branch
from
July 28, 2026 00:51
4158399 to
f8e579c
Compare
j0ntz
enabled auto-merge
July 28, 2026 00:51
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
CHANGELOG
Does this branch warrant an entry to the CHANGELOG?
Dependencies
none
Requirements
If you have made any visual changes to the GUI. Make sure you have:
Description
The native NYM wallet details scene rendered its network-context header title as "Nym Network". Nym is the asset and ecosystem name; the native blockchain is Nyx. The title now sources from
currencyInfo.chainDisplayName("Nyx") instead of the deprecatedcurrencyInfo.displayName("Nym"), so it reads "Nyx Network". Asset-context labels (wallet balanceNYM, the coin-ranking section header "Nym") are unchanged.edge-currency-accountbasedalready exposes the correctassetDisplayName: 'Nym'/chainDisplayName: 'Nyx'for the plugin; this only corrects which field the GUI title reads. No dependency changes.Verified on the iOS simulator: opened the native NYM wallet details and confirmed the header reads "Nyx Network" while the balance and asset labels remain Nym/NYM (screenshot attached).
Asana: https://app.asana.com/0/1215088146871429/1216842613201602
Note
Low Risk
Single display-field swap in the wallet details header with no security, payment, or persistence changes.
Overview
The native NYM wallet details header used
currencyInfo.displayName("Nym") in the%s Networktitle pattern, so it read "Nym Network" even though the native chain is Nyx.WalletDetailsTitlenow passescurrencyInfo.chainDisplayName("Nyx"), so the header shows "Nyx Network". Balance labels and other asset naming that useassetDisplayNameare unchanged.Reviewed by Cursor Bugbot for commit f8e579c. Bugbot is set up for automated code reviews on this repo. Configure here.