Skip to content

fix(Effect): add Refinement narrowing support for retry while option#6210

Open
lihan3238 wants to merge 2 commits intoEffect-TS:mainfrom
lihan3238:fix/retry-while-refinement
Open

fix(Effect): add Refinement narrowing support for retry while option#6210
lihan3238 wants to merge 2 commits intoEffect-TS:mainfrom
lihan3238:fix/retry-while-refinement

Conversation

@lihan3238
Copy link
Copy Markdown

Summary

Adds Refinement-based type narrowing for the while option in Effect.retry, symmetric with the existing until narrowing.

When while receives a Refinement<E, E2>, the output error type is now narrowed to Exclude<E, E2> — the errors that cause while to return false and pass through.

Closes #6122

Test plan

  • Verify that type narrowing works correctly with while + Refinement
  • Verify existing until narrowing is unchanged
  • Verify behavior without Refinement is unchanged (still returns full E)

When the `while` option receives a Refinement<E, E2>, the output error
type is now narrowed to Exclude<E, E2>, matching the symmetry of the
existing `until` Refinement narrowing.

Closes Effect-TS#6122
@lihan3238 lihan3238 requested a review from mikearnaldi as a code owner May 5, 2026 15:31
@github-project-automation github-project-automation Bot moved this to Discussion Ongoing in PR Backlog May 5, 2026
@changeset-bot
Copy link
Copy Markdown

changeset-bot Bot commented May 5, 2026

🦋 Changeset detected

Latest commit: 30e5b02

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 36 packages
Name Type
effect Patch
@effect/cli Patch
@effect/cluster Patch
@effect/experimental Patch
@effect/opentelemetry Patch
@effect/platform-browser Patch
@effect/platform-bun Patch
@effect/platform-node-shared Patch
@effect/platform-node Patch
@effect/platform Patch
@effect/printer-ansi Patch
@effect/printer Patch
@effect/rpc Patch
@effect/sql-clickhouse Patch
@effect/sql-d1 Patch
@effect/sql-drizzle Patch
@effect/sql-kysely Patch
@effect/sql-libsql Patch
@effect/sql-mssql Patch
@effect/sql-mysql2 Patch
@effect/sql-pg Patch
@effect/sql-sqlite-bun Patch
@effect/sql-sqlite-do Patch
@effect/sql-sqlite-node Patch
@effect/sql-sqlite-react-native Patch
@effect/sql-sqlite-wasm Patch
@effect/sql Patch
@effect/typeclass Patch
@effect/vitest Patch
@effect/workflow Patch
@effect/ai Patch
@effect/ai-amazon-bedrock Patch
@effect/ai-anthropic Patch
@effect/ai-google Patch
@effect/ai-openai Patch
@effect/ai-openrouter Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

Status: Discussion Ongoing

Development

Successfully merging this pull request may close these issues.

Effect.retry: support Refinement narrowing for while option

1 participant