Skip to content

fix(Record): make fromIterableBy dual for pipe-friendly usage#6212

Open
lihan3238 wants to merge 2 commits intoEffect-TS:mainfrom
lihan3238:fix/record-fromiterableby-dual
Open

fix(Record): make fromIterableBy dual for pipe-friendly usage#6212
lihan3238 wants to merge 2 commits intoEffect-TS:mainfrom
lihan3238:fix/record-fromiterableby-dual

Conversation

@lihan3238
Copy link
Copy Markdown

Summary

Wraps Record.fromIterableBy with dual(2, ...) so it supports both data-first and data-last (curried) calling conventions, consistent with fromIterableWith and other dual APIs in the codebase.

This enables the following pipe-friendly usage:

pipe(rows, Record.fromIterableBy(Struct.get("authEmail")))

Closes #6092

Test plan

  • Verify data-first usage still works: Record.fromIterableBy(items, fn)
  • Verify data-last/curried usage works: pipe(items, Record.fromIterableBy(fn))
  • Verify type inference is correct in both modes

Wraps `Record.fromIterableBy` with `dual(2, ...)` so it supports both
data-first and data-last (curried) calling conventions, consistent with
`fromIterableWith` and other dual APIs in the codebase.

Closes Effect-TS#6092
@lihan3238 lihan3238 requested a review from mikearnaldi as a code owner May 5, 2026 15:34
@github-project-automation github-project-automation Bot moved this to Discussion Ongoing in PR Backlog May 5, 2026
@changeset-bot
Copy link
Copy Markdown

changeset-bot Bot commented May 5, 2026

🦋 Changeset detected

Latest commit: 2acd558

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 36 packages
Name Type
effect Patch
@effect/cli Patch
@effect/cluster Patch
@effect/experimental Patch
@effect/opentelemetry Patch
@effect/platform-browser Patch
@effect/platform-bun Patch
@effect/platform-node-shared Patch
@effect/platform-node Patch
@effect/platform Patch
@effect/printer-ansi Patch
@effect/printer Patch
@effect/rpc Patch
@effect/sql-clickhouse Patch
@effect/sql-d1 Patch
@effect/sql-drizzle Patch
@effect/sql-kysely Patch
@effect/sql-libsql Patch
@effect/sql-mssql Patch
@effect/sql-mysql2 Patch
@effect/sql-pg Patch
@effect/sql-sqlite-bun Patch
@effect/sql-sqlite-do Patch
@effect/sql-sqlite-node Patch
@effect/sql-sqlite-react-native Patch
@effect/sql-sqlite-wasm Patch
@effect/sql Patch
@effect/typeclass Patch
@effect/vitest Patch
@effect/workflow Patch
@effect/ai Patch
@effect/ai-amazon-bedrock Patch
@effect/ai-anthropic Patch
@effect/ai-google Patch
@effect/ai-openai Patch
@effect/ai-openrouter Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

Status: Discussion Ongoing

Development

Successfully merging this pull request may close these issues.

Record.fromIterableBy is not dual/curried (awkward in pipe)

1 participant