pytest: fix broken test_pay_bolt11_metadata#9178
Open
rustyrussell wants to merge 1 commit into
Open
Conversation
It uses a canned, but now expired invoice. Instead, use bolt11-cli to add metadata to an existing invoice. Signed-off-by: Rusty Russell <rusty@rustcorp.com.au>
Lagrang3
reviewed
Jun 1, 2026
| del inv_decoded['signature'] | ||
| del post_decoded['signature'] | ||
| del post_decoded['payment_metadata'] | ||
| assert inv_decoded == post_decoded |
Collaborator
There was a problem hiding this comment.
This is flaky. The "created_at" field might differ by 1.
It suffices to add a couple of lines
del inv_decoded['created_at']
del post_decoded['created_at']
Lagrang3
reviewed
Jun 1, 2026
| inv_decoded = l1.rpc.decode(inv['bolt11']) | ||
| inv_with_metadata = subprocess.check_output(['devtools/bolt11-cli', 'encode', | ||
| # l2's private key (old_hsmsecret, WIF byte stripped) | ||
| '0c633a7c17c701a0980158f5483035e01fa8bd091b47fadf2e86e589a9f93fca', |
Collaborator
There was a problem hiding this comment.
How do you get the private key of the regtest nodes?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
It uses a canned, but now expired invoice. Instead, use bolt11-cli to add metadata to an existing invoice.
Changelog-None