Skip to content
Open
Changes from 1 commit
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
47 changes: 36 additions & 11 deletions etc/enigma.appdata.xml
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
<?xml version="1.0" encoding="UTF-8"?>
<!-- Copyright 2014 Ryan Lerch <rlerch@redhat.com>, Andreas Lochmann <and.lochmann@googlemail.com> -->
<application>
<id type="desktop">enigma.desktop</id>
<component type="desktop-application">
<id>org.nongnu.enigma</id>

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We have an own domain name enigma-game.org. I'd prefer to use this. (Even if it just redirects to nongnu for now.)

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

<launchable type="desktop-id">org.nongnu.enigma.desktop</launchable>
<metadata_license>CC0-1.0</metadata_license>
<project_license>GPL-2.0+</project_license>
<name>Enigma</name>
Expand Down Expand Up @@ -44,22 +44,47 @@
<ul>
<li>Rescaling the application window introduces graphical artifacts: Better use fixed window sizes for now.</li>
<li>Not all fullscreen modes are available yet, in particular no vertical screen modes. If you use a vertical screen, please use Enigma in windowed mode.</li>
<li>On Windows 7, after playing or finishing a level, the mouse cursor is trapped inside Enigma's window (but not frozen). Enigma can still be operated and exited via the main menu or the game menu, though.</li>
<li>On Windows 7, after playing or finishing a level, the mouse cursor is trapped inside Enigma&apos;s window (but not frozen). Enigma can still be operated and exited via the main menu or the game menu, though.</li>
</ul>
</description>
</release>
</releases>
<url type="homepage">http://www.nongnu.org/enigma/</url>
<url type="homepage">https://www.nongnu.org/enigma/</url>

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

<screenshots>
<screenshot type="default">http://www.nongnu.org/enigma/images/screenshots/ral15_1.png</screenshot>
<screenshot>http://www.nongnu.org/enigma/images/screenshots/mecke22_2.png</screenshot>
<screenshot>http://www.nongnu.org/enigma/images/screenshots/luc36_1.png</screenshot>
<screenshot type="default">
<image>https://www.nongnu.org/enigma/images/screenshots/ral15_1.png</image>
<caption>"The Gordian Knot" by Ronald Lamprecht</caption>
</screenshot>
<screenshot>
<image>https://www.nongnu.org/enigma/images/screenshots/mecke22_2.png</image>
<caption>Example Level</caption>

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please use proper level title (to give credits to the authors).

</screenshot>
<screenshot>
<image>https://www.nongnu.org/enigma/images/screenshots/luc36_1.png</image>
<caption>Example Level</caption>
</screenshot>
</screenshots>
<keywords>
<keyword>enigma</keyword>
<keyword>puzzle</keyword>
<keyword>marble</keyword>
</keywords>
<content_rating type="oars-1.1" />
<updatecontact>enigma-devel@nongnu.org</updatecontact>
</application>
<developer id="enigma.nongnu.org">

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't really like to duplicate the list of contributors in yet another place.
But if this is good practice for the metadata, then I'm ok with it. Just make sure it is in sync with what is shown in-game. (Which is the most up-to-date list a think.)

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hmm, spec seems to say we can have just one name tag (per language):
https://docs.flathub.org/docs/for-app-authors/metainfo-guidelines/#developer-name

Although the file validates via appstreamcli validate.

<name>Thomas Bernhardt</name>
<name>Raoul Bourquin</name>
<name>Siegfried Fennig</name>
<name>Martin Hawlisch</name>
<name>Daniel Heck</name>
<name>Georg Honold</name>
<name>Ronald Lamprecht</name>
<name>Andreas Lochmann</name>
<name>Petr Machata</name>
<name>Nobby</name>
<name>Nat Pryce</name>
<name>Jacob Scott</name>
<name>Sven Siggelkow</name>
<name>Ralf Westram</name>
</developer>
<content_rating type="oars-1.1"/>
<update_contact>enigma-devel@nongnu.org</update_contact>
</component>