ui: remove redundant loop in layout constraint enforcement#755
Open
rnpnr wants to merge 1 commit intoEpicGamesExt:masterfrom
Open
ui: remove redundant loop in layout constraint enforcement#755rnpnr wants to merge 1 commit intoEpicGamesExt:masterfrom
rnpnr wants to merge 1 commit intoEpicGamesExt:masterfrom
Conversation
rnpnr
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hi,
I was reviewing the layout code to get a better feeling for how the strictness parameter was used and I spotted this redundant loop. I thought I would send forward a patch since it is probably not a section of code that is seeing much active review.
Thanks for such a great tool!