fix: for incompatibly old models, just say downgrade everyvoice - #156
Merged
Conversation
Now that we're about to release EveryVoice 0.5.0, we should no longer specifically say <0.3.0 or earlier alpha, except in the one case where that's actually known to be correct. Fixes EveryVoiceTTS/EveryVoice#854
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #156 +/- ##
=======================================
Coverage 48.80% 48.80%
=======================================
Files 27 27
Lines 2012 2012
Branches 231 231
=======================================
Hits 982 982
Misses 995 995
Partials 35 35 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PR Goal?
Now that we're about to release EveryVoice 0.5.0, we should no longer specifically say <0.3.0 or earlier alpha, except in the one case where that's actually known to be correct.
Fixes?
Fixes EveryVoiceTTS/EveryVoice#854
Feedback sought?
rubber stamping
Priority?
low
Tests added?
no
How to test?
try to use old models and see that the warning messages are updated
caveat: I did not test these changes, they're only touching actual warning messages, no calls, so if CI passes that's going to be good enough for me.
Confidence?
high
Version change?
no
Related PRs?
EveryVoiceTTS/EveryVoice#856