Repository navigation
feat: Create new table object_audit_log - #384
Open
jiaolong89 wants to merge 5 commits into
Open
jiaolong89 wants to merge 5 commits into
jiaolong89 wants to merge 5 commits into
Conversation
jiaolong89
changed the title
piket
requested changes
Oct 7, 2026
| Column("project_id", String(255), nullable=False), | ||
| Column("object_type", String(50), nullable=False), | ||
| Column("object_name", String(255), nullable=False), | ||
| Column("operation", String(20), nullable=False), # create | update | delete |
Collaborator
There was a problem hiding this comment.
The comment defines a closed set of values (create | update | delete), but the column accepts any string (same for object_type). For an audit table I'd lean toward a CheckConstraint on operation, or at least shared constants for the follow-up writer PR. That way we don't end up with CREATE/upsert/feature_views variants that forensic queries silently miss.
| sqlite_registry.apply_entity(entity, "test_project") | ||
| sqlite_registry.delete_entity("test_entity", "test_project") | ||
|
|
||
| with pytest.raises(Exception): |
Collaborator
There was a problem hiding this comment.
pytest.raises(Exception) would pass on any error, including an unrelated failure. Can we assert EntityNotFoundException instead?
make id 64-bit Co-authored-by: piket <timonpike@gmail.com>
use LargeBinary().with_variant(mysql.LONGBLOB, "mysql") for both before_proto and after_proto Co-authored-by: piket <timonpike@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
create new table object_audit_log used for audits on registry operations
Which issue(s) this PR fixes:
Misc