Repository navigation
fix(10.x.x): keep SynchronizedDataLoader when the registry has an instrumentation, and synchronize loadMany. - #2216
Merged
samuelAndalon merged 1 commit intoOct 1, 2026
Conversation
…trumentation, and synchronize loadMany.
samuelAndalon
approved these changes
Oct 1, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
📝 Description
SynchronizedDataLoader(#2202) has two gaps that let concurrent loads on a cached, non-batching loader call the downstream more than once:DataLoaderRegistryrebuilds each loader withtransform(...)to add its name and instrumentation.DelegatingDataLoader.transformreturns the plain delegate, so the wrapper is lost whenever aDataLoaderInstrumentationis passed togenerate(...), which is always the case withSYNC_EXHAUSTION.transformnow re-wraps the result.loadManybypasses the wrapper and calls the delegate'sloadImpldirectly. That includesgetValuesFromDataLoader. The threeloadManyoverloads are now synchronized likeload.🔗 Related Issues
Follow-up to #2202, which addressed the loss of
loadsynchronization