Skip to content

[Due for payment 2026-11-20] [$175] Company cards - Not here page opens after refreshing Contact methods RHP and returning #105426

Closed

Description

@applause-bot

If you haven’t already, check out our contributing guidelines for onboarding. To join our Slack channel, fill out this form.


Version Number: 9.5.26.0
Reproducible in staging?: Yes
Reproducible in production?: N/A - new feature, doesn't exist in prod
If this was caught during regression testing, add the test name, ID and link from BrowserStack: #95610
Email or phone of affected tester (no customers): sjodinjoisdjoisjio@gmail.com
Issue reported by: Applause Internal Team
Bug source: Exploratory - Significant User Experience Deterioration
Device used: Mac 26.5 / Chrome
App Component: Workspace Settings

Action Performed:

Precondition:

  • Add a direct feed on workspace settings > Company cards.
  1. Go to staging.new.expensify.com
  2. Create a workspace.
  3. Go to workspace settings > Company cards.
  4. Click Add card.
  5. Select card feed from other workspace > Save.
  6. Click Add work email.
  7. Refresh the page.
  8. Click RHP back button.

Expected Result:

Select cards RHP will open.

Actual Result:

Not here page opens after refreshing Contact methods RHP and returning via back button.

Workaround:

Unknown

Platforms:

  • Android: App
  • Android: mWeb Chrome
  • iOS: App
  • iOS: mWeb Safari
  • iOS: mWeb Chrome
  • Windows: Chrome
  • MacOS: Chrome Safari

Screenshots/Videos

Bug7300012_1793310268813.3.mp4

View all open jobs on GitHub

Applause Internal Information
Exported by: Svetlana Lazutkina
Bug ID: 7300012

Upwork Automation - Do Not Edit
Issue OwnerCurrent Issue Owner: @gijoe0295

Activity

  1. applause-bot commented on Oct 29, 2026

    @applause-bot
    Author

    While Applause doesn't embed attachments for this bug, here are the links for quick view:
    https://platform.applause.com/services/links/v1/external/0f5ab8815d0e107d3403a149baa901a28341eb52d4565b1c37bb215d3944aa90

  2. added
    DeployBlockerCashThis issue or pull request should block deployment
    BugSomething is broken. Auto assigns a BugZero manager.
    on Oct 29, 2026
  3. melvin-bot commented on Oct 29, 2026

    @melvin-bot

    You have been assigned to this deploy blocker because you recently merged this PR: #95610

  4. melvin-bot commented on Oct 29, 2026

    @melvin-bot

    @mountiny @gijoe0295 you have been assigned to this deploy blocker because you reviewed the offending PR: #95610

  5. melvin-bot commented on Oct 29, 2026

    @melvin-bot

    💬 A slack conversation has been started in #expensify-open-source

  6. github-actions commented on Oct 29, 2026

    @github-actions
    Contributor

    👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open `StagingDeployCash` deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:

    1. Identify the pull request that introduced this issue and revert it.
    2. Find someone who can quickly fix the issue.
    3. Fix the issue yourself.
  7. MelvinBot commented on Oct 29, 2026

    @MelvinBot
    Contributor

    Deploy Blocker Analysis

    Causing PR: [Payment due @gijoe0295] Replace work email input with button linking to Contact Methods in card feed flows (high confidence). It added the "Add work email" button in step 6, which opens Contact methods on top of the work-email route. No other PR in this staging checklist touches this flow.

    Root cause (medium confidence): After a refresh, the Contact methods back button calls a bare Navigation.goBack() with no fallback (DynamicContactMethodsPage.tsx:64-67). It depends on the navigation state that the app rebuilds from the URL, and that state doesn't land on a valid screen. I couldn't confirm from code alone which branch renders "Not here". The likely candidates are the work-email page's access wrapper or the dynamic-route rebuild.

    Recommendation: targeted fix or demote, not revert.

    • Reverting brings back the inline AddWorkEmail call. Per the PR, the backend now rejects that call, which is worse than this bug.
    • The bug only happens on a mid-flow page refresh on web. Closing the panel recovers.
    • Fix: give Contact methods an explicit back path from the work-email page. For example, pass a backTo, or use Navigation.goBack(useDynamicBackPath(DYNAMIC_ROUTES.CONTACT_METHODS.path)) (useDynamicBackPath.ts). Apply the same fix to the Expensify Card page, which has the same button (WorkspaceExpensifyCardAddWorkEmailPage.tsx:71).

    Note: the Select cards screen isn't kept in the URL, so after a refresh, back can at best return to Add work email, not Select cards.

    Investigation details

    Next Steps: Reply with @MelvinBot <your feedback> to refine this analysis.


    view run

  8. gijoe0295 commented on Oct 30, 2026

    @gijoe0295
    Contributor

    I think we can demote. I'm working on it though

  9. 18 remaining items

  10. jeffrey-graham commented on Nov 7, 2026

    @jeffrey-graham
  11. melvin-bot commented on Nov 7, 2026

    @melvin-bot
  12. changed the title [-][$175] Company cards - Not here page opens after refreshing Contact methods RHP and returning[/-] [+][Due for payment 2026-11-20] [$175] Company cards - Not here page opens after refreshing Contact methods RHP and returning[/+] on Nov 13, 2026
  13. melvin-bot commented on Nov 13, 2026

    @melvin-bot

    @gijoe0295

    The solution for this issue has been 🚀 deployed to production 🚀 in version 9.5.37-1 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

    If no regressions arise, payment will be issued on 2026-11-20. 🎊

    The following checklist (instructions) will need to be completed before the issue can be closed. Please copy/paste the Contributor+ Checklist from here into a new comment on this GH and complete it. If you have the K2 extension, you can simply click: [this button]. If no checklist is needed for this issue, you can click: [no checklist button]

  14. gijoe0295 commented on Nov 13, 2026

    @gijoe0295
    Contributor

    I think we can close. No payment is due here as it's a small follow-up item.

  15. added
    Skip PaymentSkips all the payment process steps for an issue. Use it for fixed-price projects.
    on Nov 13, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Labels

BugSomething is broken. Auto assigns a BugZero manager.DailyKSv2EngineeringExternalAdded to denote the issue can be worked on by a contributorSkip PaymentSkips all the payment process steps for an issue. Use it for fixed-price projects.

Type

No type

Projects

Milestone

No milestone

Relationships

None yet

Development

No branches or pull requests

Issue actions