Skip to content

[Partial Payment] Remove Onyx.connect() for the key: ONYXKEYS.CREDENTIALS in src/libs/actions/Session/index.ts #67785

Open

Description

@danieldoglas

This is part of deprecating Onyx.connect. Parent Issue

Details

Be sure to refactor methods using test driven development:

  1. Create a unit test for methods before refactoring
  2. Refactor the methods
  3. Ensure the unit test still runs after refactoring
  4. Reinforce the unit testing with a functional test and a QA test
  5. Once you are done, decrease the number of allowable ESLint warnings here to equal the number of Onyx.connect references remaining in the code

Activity

  1. self-assigned this
    on Aug 4, 2025
  2. added
    ImprovementItem broken or needs improvement.
    BugSomething is broken. Auto assigns a BugZero manager.
    on Aug 4, 2025
  3. danieldoglas commented on Aug 4, 2025

    @danieldoglas
    ContributorAuthor

    Warning

    DO NOT POST PROPOSALS ON THIS ISSUE!!

    Bug-Zero Instructions

    • This issue is CLOSED for proposals
    • It is a special issue and part of a bigger project
    • A contributor will be manually assigned to work on this issue and they do not need to submit a proposal
    • The bug-zero person only needs to take care of payments to the contributor for the PR and the C+ for reviews
    • There do not need to be any regression tests added or updated since this is only refactoring and shouldn't change any existing functionality
  4. melvin-bot commented on Aug 4, 2025

    @melvin-bot

    Triggered auto assignment to @sakluger (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.

  5. sakluger commented on Sep 6, 2025

    @sakluger
    Contributor

    @danieldoglas what's the status of this one?

  6. 91 remaining items

  7. mallenexpensify commented on Oct 27, 2026

    @mallenexpensify
    Contributor

    Payment Summary

    Contributor+: @huult due $250 via NewDot
    Contributor+: @shubham1206agra due $500 via NewDot
    Contributor+: @cretadn22 due $750 via NewDot

    Is that correct?!?! Tag me if not, cc @danieldoglas

    Updated title to reflect partial payments, leaving issue open

  8. changed the title [-][Due for payment 2026-10-26] Remove `Onyx.connect()` for the key: `ONYXKEYS.CREDENTIALS` in `src/libs/actions/Session/index.ts`[/-] [+][Partial Payment] Remove `Onyx.connect()` for the key: `ONYXKEYS.CREDENTIALS` in `src/libs/actions/Session/index.ts`[/+] on Oct 27, 2026
  9. removed their assignment
    on Oct 27, 2026
  10. huult commented on Oct 29, 2026

    @huult
    Contributor

    78. The remaining work on this issue will be held until Onyx.get is exposed

    I think we've summarized one part for the payment ticket, and since it's on hold, we can move this ticket to weekly.

  11. added and removed on Oct 29, 2026
  12. huult commented on Nov 11, 2026

    @huult
    Contributor

    Not overdue

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Labels

BugSomething is broken. Auto assigns a BugZero manager.EngineeringImprovementItem broken or needs improvement.WeeklyKSv2

Type

No type

Projects

No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions