Repository navigation
Remove Onyx.connect() for the key: ONYXKEYS.ONYX_UPDATES_LAST_UPDATE_ID_APPLIED_TO_CLIENT in src/libs/actions/Session/index.ts #67789
Description
This is part of deprecating Onyx.connect. Parent Issue
Details
- Module: src/libs/actions/Session/index.ts
- Onyx Key:
ONYXKEYS.ONYX_UPDATES_LAST_UPDATE_ID_APPLIED_TO_CLIENT - Reference:
Line 522: ONYXKEYS.ONYX_UPDATES_LAST_UPDATE_ID_APPLIED_TO_CLIENT
Be sure to refactor methods using test driven development:
- Create a unit test for methods before refactoring
- Refactor the methods
- Ensure the unit test still runs after refactoring
- Reinforce the unit testing with a functional test and a QA test
- Once you are done, decrease the number of allowable ESLint warnings here to equal the number of
Onyx.connectreferences remaining in the code
Activity
danieldoglas commentedon Aug 4, 2025
Warning
DO NOT POST PROPOSALS ON THIS ISSUE!!
Bug-Zero Instructions
src/libs/actions/Session/index.tsto removeOnyx.connect()references #67781melvin-bot commentedon Aug 4, 2025
Triggered auto assignment to @kadiealexander (
Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.kadiealexander commentedon Sep 9, 2025
@DylanDylann @shubham1206agra any update here?
DylanDylann commentedon Sep 9, 2025
will be worked on soon
danieldoglas commentedon Oct 13, 2025
not overdue
kadiealexander commentedon Nov 18, 2025
Not overdue.
DylanDylann commentedon Dec 4, 2025
@kadiealexander @danieldoglas This is invalid now, please close this issue