Repository navigation
Bump React Native 0.88 #101739
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Bump React Native 0.88 #101739
Changes from 31 commits
d3ab8e3
bec5a42
a344654
6d8a254
8764564
21a7c79
270d4ef
3efceef
bae3ecd
73d3b55
66504f1
a134644
fdb16db
bfa91ee
118877d
747893d
49bb2b9
f2c27e2
5da5098
3616a77
c9f0908
57b0cee
1a5965d
ad725d3
4a90230
ee6caeb
764e94e
9fbff48
2e4c262
abb84b8
06fca10
c128acb
8213216
fe86833
650db6f
a54ce42
76d8fc0
c492cb7
3f9a09f
90f7dda
e169073
f2c64de
f6fa6d5
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -192,6 +192,11 @@ const getSharedConfiguration = ({file = '.env', isDevServer = false}: Environmen | |
| 'victory-native': path.resolve(dirname, '../../node_modules/victory-native/src/index.ts'), | ||
| // Required for @shopify/react-native-skia web support | ||
| 'react-native/Libraries/Image/AssetRegistry': false, | ||
| // RN 0.87+ dropped the @react-native/assets-registry package and moved the registry into core | ||
| // (react-native/asset-registry, a Flow file). expo-asset/expo-image import the new path, react-native-svg | ||
|
Contributor
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. I think maybe we should fix this with a patch/upstream PR for react-native-svg?
Contributor
Author
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. There's already an upstream PR in the repo, but it isn't merged yet. I'll ask the maintainers when they plan to fix this. I also added a comment with a link to the upstream issue, so we don't forget to remove these lines. So I think it would be better to leave it as is, without a patch, and just bump the library once they ship the release. WDYT?
Contributor
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Sounds good. Let's open a follow-up issue to upgrade react-native-svg and remove this
Contributor
Author
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. |
||
| // still imports the old package. On web both should resolve to react-native-web's registry. | ||
| 'react-native/asset-registry': 'react-native-web/dist/modules/AssetRegistry', | ||
| '@react-native/assets-registry/registry': 'react-native-web/dist/modules/AssetRegistry', | ||
| // @sentry/react-native references the optional expo-updates module. We do not install it, | ||
| // so web/Storybook bundles should treat it as unavailable instead of failing resolution. | ||
| 'expo-updates': false, | ||
|
|
||
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
NAB / potential follow-up: I wonder if we should consider migrating our gradle scripts from Groovy to Kotlin
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Agreed it'd be nice, it would pair well with moving off the legacy variant API so we can enable android.newDsl. Should I create an issue?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
yep I'd say go for it. We talked about doing it in a follow-up during the last RN upgrade and didn't