Repository navigation
Migrate ShareActionHandlerModule to a type-safe Nitro module #104550
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,76 @@ | ||
| package com.margelo.nitro.utils | ||
|
|
||
| import android.content.Context | ||
| import android.graphics.BitmapFactory | ||
| import android.media.MediaMetadataRetriever | ||
| import android.net.Uri | ||
| import android.webkit.MimeTypeMap | ||
| import com.margelo.nitro.NitroModules | ||
| import com.margelo.nitro.core.Promise | ||
| import org.json.JSONObject | ||
| import java.io.File | ||
| import java.io.IOException | ||
| import java.util.Locale | ||
|
|
||
| /** Reads the same persisted share intent in standalone and hybrid builds. */ | ||
| class HybridShareActionHandler : HybridShareActionHandlerSpec() { | ||
| override val memorySize: Long = 0L | ||
|
|
||
| override fun processFiles(): Promise<Array<SharedFile>> = Promise.parallel { | ||
| val context = NitroModules.applicationContext ?: throw IOException("React Native context is unavailable") | ||
| val preferences = context.getSharedPreferences("shareActionHandler", Context.MODE_PRIVATE) | ||
| val serialized = preferences.getString("shareObject", null) ?: return@parallel emptyArray() | ||
| val share = JSONObject(serialized) | ||
| val content = share.opt("content") as? String ?: throw IOException("Shared content must be a string") | ||
| if (content.isEmpty()) { | ||
| throw IOException("Shared content is empty") | ||
| } | ||
| val file = File(content) | ||
| val storedMimeType = share.opt("mimeType") | ||
| if (storedMimeType != null && storedMimeType != JSONObject.NULL && storedMimeType !is String) { | ||
| throw IOException("Shared MIME type must be a string") | ||
| } | ||
| var mimeType = (storedMimeType as? String).orEmpty().substringBefore(';').trim().lowercase(Locale.ROOT) | ||
| val timestamp = System.currentTimeMillis().toString() | ||
|
|
||
| // Older intent handlers did not distinguish literal text from a text file's path. | ||
| val isText = if (share.has("isText")) { | ||
| share.opt("isText") as? Boolean ?: throw IOException("Shared text discriminator must be a boolean") | ||
| } else { | ||
| mimeType == "text/plain" && !file.isAbsolute | ||
| } | ||
| if (isText) { | ||
| return@parallel arrayOf(SharedFile("text", content, "txt", timestamp, null)) | ||
| } | ||
|
|
||
| if (!file.isFile || !file.canRead() || file.length() == 0L) { | ||
|
Contributor
There was a problem hiding this comment. (Shubham's Ai) Throwing on a zero-byte file (here and the
Author
There was a problem hiding this comment. Thanks, addressed. Zero-byte regular files now reach the existing JavaScript size validation, restoring the |
||
| throw IOException("Shared attachment is missing, unreadable, or empty") | ||
| } | ||
| if (mimeType.isEmpty() || mimeType == "null" || mimeType.endsWith("/*")) { | ||
| mimeType = MimeTypeMap.getSingleton().getMimeTypeFromExtension(file.extension.lowercase(Locale.ROOT)) | ||
| ?: "application/octet-stream" | ||
| } | ||
|
|
||
| val aspectRatio = when { | ||
| mimeType.startsWith("image/") -> { | ||
| val options = BitmapFactory.Options().apply { inJustDecodeBounds = true } | ||
| BitmapFactory.decodeFile(content, options) | ||
| if (options.outWidth > 0 && options.outHeight > 0) options.outWidth.toDouble() / options.outHeight else null | ||
| } | ||
| mimeType.startsWith("video/") -> { | ||
| val retriever = MediaMetadataRetriever() | ||
| try { | ||
| retriever.setDataSource(content) | ||
| val width = retriever.extractMetadata(MediaMetadataRetriever.METADATA_KEY_VIDEO_WIDTH)?.toDoubleOrNull() | ||
| val height = retriever.extractMetadata(MediaMetadataRetriever.METADATA_KEY_VIDEO_HEIGHT)?.toDoubleOrNull() | ||
| if (width != null && height != null && width > 0 && height > 0) width / height else null | ||
| } finally { | ||
| retriever.release() | ||
| } | ||
| } | ||
| else -> null | ||
|
Contributor
There was a problem hiding this comment. (Shubham's Ai)
Author
There was a problem hiding this comment. Thanks for flagging. Confirmed by the existing preview implementation: when |
||
| } | ||
|
|
||
| arrayOf(SharedFile(file.name, Uri.fromFile(file).toString(), mimeType, timestamp, aspectRatio)) | ||
| } | ||
| } | ||
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
(Shubham's Ai) Nit:
"shareActionHandler"/"shareObject"duplicateIntentHandlerConstants(in both App and Mobile-Expensify), which this module can't import. Could you add a comment pointing at the source so the two don't drift?There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks, addressed. I added a comment identifying
IntentHandlerConstantsas the source of truth for the duplicated preference file and key, and explaining that the standalone Nitro module cannot import app-level Android code.