[CP Staging] fix: Downscale oversized in-app camera photos before use by OlimpiaZurek · Pull Request #104979 · Expensify/App

OlimpiaZurek · 2026-10-26T09:06:46Z

Explanation of Change

After the VisionCamera v5 upgrade (#102898), the photo resolution we request (2880×2160) is only a hint, and CameraX may return a full-sensor photo. On some Android devices (Samsung S23 FE / S25 FE), the photo taken with "Take a photo" from the attachment picker is then over AVATAR_MAX_ATTACHMENT_SIZE (6 MiB), so the avatar flow rejects it with "Size exceeded" before cropping.

This PR adds downscalePhoto, which runs in AttachmentCamera right after capture:

A photo whose long edge is 2880 px or less is used as is, with no re-encode.
A larger photo is resized so its long edge is 2880 px, keeping the aspect ratio, and saved as a JPEG at JPEG_QUALITY. The full-size original is deleted.
If the resize fails, the original photo is used and a warning is logged, so capture never breaks.

Fixed Issues

$ #104941
PROPOSAL:

Tests

On Android native, go to Account > Profile and tap the avatar.
Choose "Take a photo", take a photo, then tap "Use photo".
Verify the crop screen opens and no "Size exceeded" error appears.

Verify that no errors appear in the JS console

Offline tests

QA Steps

Same as tests

Verify that no errors appear in the JS console

PR Author Checklist

Screenshots/Videos

Android: Native

Android: mWeb Chrome

iOS: Native

iOS: mWeb Safari

MacOS: Chrome / Safari

OlimpiaZurek · 2026-10-26T09:07:00Z

@MelvinBot review

OlimpiaZurek · 2026-10-26T09:07:07Z

@codex review

chatgpt-codex-connector · 2026-10-26T09:07:20Z

Codex Review Summary

This comment shows the latest Codex review activity on this pull request.

Review	Status	Commit	Review trigger
📝 Code Review	✅ Completed 2026-10-26T10:05:28.970954Z	`7414598`	Draft marked ready

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

Open a pull request for review
Mark a draft as ready
Comment "@codex review" or "@codex security review".

Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings.

MelvinBot · 2026-10-26T09:10:19Z

Review

The approach looks right, and I found nothing blocking. capturePhotoToPath already reports display-frame dimensions, so resizing in that frame matches what the manipulator decodes. The long-edge cap also handles the 16:9 output Android sometimes returns.

I have two suggestions and one housekeeping item:

A synchronous throw skips the fallback. downscalePhoto.ts:40 calls ImageManipulator.manipulate(...) synchronously. If it throws, the error skips the .catch at AttachmentCamera.tsx:184-188. The user then sees the camera error alert, and the original capture is never discarded. That breaks the promise that "capture never breaks." To fix it, start the work inside a promise, as callAsPromise does in cameraCapture/index.ts. For example: Promise.resolve().then(() => downscalePhoto(photo)).catch(...).
Resizing to both dimensions can squash the photo. resize(size) forces exact width and height. rotatePhotoToUpright.ts:27 says some stills are saved without rotation metadata. For those, the decoded frame is sideways compared with photo's display size. An 8160×6120 decode would then be forced into 2160×2880 and distorted. Passing only one dimension keeps the aspect ratio, and result.width/result.height already report the real output. Measuring with ImageSize.getSize first also works.
The PR body is unfinished. QA Steps still contains the // TODO placeholder.

Other checks

Cleanup is correct on every path: the original is deleted after a successful resize, and the final file is deleted if the modal closes mid-resize. ReceiptStorage.discard deletes any path, including the manipulator's cache output.
A 2880×2160 JPEG at JPEG_QUALITY (0.85) should fit easily under the 6 MiB avatar limit.
I did not run a UI test. AttachmentCamera is only rendered from AttachmentPicker/index.native.tsx, so this run's web environment cannot reach this flow.
No CI checks are failing other than Check independent approval.

view run

codecov · 2026-10-26T09:11:32Z

Codecov Report

❌ Looks like you've decreased code coverage for some files. Please write tests to increase, or at least maintain, the existing level of code coverage. See our documentation here for how to interpret this table.

Files with missing lines	Coverage Δ
src/libs/cameraCapture/releaseQuietly.ts	`100.00% <100.00%> (ø)`
...p/IOURequestStepScan/utils/rotatePhotoToUpright.ts	`33.33% <ø> (+5.33%)`	⬆️
...c/components/AttachmentPicker/AttachmentCamera.tsx	`87.38% <88.88%> (-0.24%)`	⬇️
src/libs/cameraCapture/downscalePhoto.ts	`59.37% <59.37%> (ø)`
... and 24 files with indirect coverage changes

chatgpt-codex-connector

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 5add194d34

ℹ️ About Codex in GitHub

Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you

Open a pull request for review
Mark a draft as ready
Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".

chatgpt-codex-connector · 2026-10-26T09:22:19Z

+    }
+
+    // The manipulator applies the file's rotation metadata while decoding, so resize in the display frame `photo` reports.
+    const context = ImageManipulator.manipulate(getPhotoSource(photo.path)).resize(size);


Route synchronous resize errors through the fallback

When ImageManipulator.manipulate() or the synchronous .resize() call throws (for example, during native context initialization), downscalePhoto() exits before returning a Promise. The .catch() in AttachmentCamera.tsx therefore cannot apply its "use the original" fallback; the error reaches the outer capture catch, displays a camera failure, and leaves the valid original capture unused and undeleted. Wrap this setup in a Promise or try so these failures reject through the resize fallback.

Useful? React with 👍 / 👎.

melvin-bot · 2026-10-26T09:51:09Z

@situchan Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button]

github-actions · 2026-10-26T11:35:58Z

🚧 MonilBhavsar has triggered a test Expensify/App build. You can view the workflow run here.

situchan · 2026-10-26T11:56:07Z

Reviewer Checklist

I have verified the author checklist is complete (all boxes are checked off).
I verified the correct issue is linked in the ### Fixed Issues section above
I verified testing steps are clear and they cover the changes made in this PR
- I verified the steps for local testing are in the Tests section
- I verified the steps for Staging and/or Production testing are in the QA steps section
- I verified the steps cover any possible failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
- I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
I checked that screenshots or videos are included for tests on all platforms
I included screenshots or videos for tests on all platforms
I verified that the composer does not automatically focus or open the keyboard on mobile unless explicitly intended. This includes checking that returning the app from the background does not unexpectedly open the keyboard.
I verified tests pass on all platforms & I tested again on:
- Android: HybridApp
- Android: mWeb Chrome
- iOS: HybridApp
- iOS: mWeb Safari
- MacOS: Chrome / Safari
If there are any errors in the console that are unrelated to this PR, I either fixed them (preferred) or linked to where I reported them in Slack
I verified any copy / text that was added to the app is either coming verbatim from figma or has been approved by marketing (in order to get marketing approval, ask the Bug Zero team member to add the Waiting for copy label to the issue)
If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
I verified other components that can be impacted by these changes have been tested, and I retested again (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar have been tested & I retested again)
If a new component is created I verified that:
- A similar component doesn't exist in the codebase
- All props are defined accurately
- The component has a clear name that is non-ambiguous and the purpose of the component can be inferred from the name alone
- The only data being stored in the state is data necessary for rendering and nothing else
- The component has the minimum amount of code necessary for its purpose, and it is broken down into smaller components in order to separate concerns and functions
If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
If the PR modifies the UI (e.g. new buttons, new UI components, changing the padding/spacing/sizing, moving components, etc) or modifies the form input styles:
- I verified that all the inputs inside a form are aligned with each other.
- I added Design label and/or tagged @Expensify/design so the design team can review the changes.
If the PR adds or modifies the UI:
- I asked an AI agent to review the changes for accessibility issues and addressed its findings.
- I tested with a screen reader (VoiceOver on macOS) and verified all new/changed elements are reachable with a logical focus order.
- I verified all new/changed elements have meaningful accessible names and roles.
- I verified state changes are announced (e.g. checked/unchecked, expanded/collapsed, selected).
For any bug fix or new feature in this PR, I verified that sufficient unit tests are included to prevent regressions in this flow.
If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.
I have checked off every checkbox in the PR reviewer checklist, including those that don't apply to this PR.

Screenshots/Videos

Android: HybridApp

android.2.mp4

Android: mWeb Chrome

iOS: HybridApp

iOS: mWeb Safari

MacOS: Chrome / Safari

MelvinBot · 2026-10-26T11:59:42Z

Regression check

I found no regressions at 7414598. That commit fixes both issues from my earlier review:

The work now starts inside a promise, so a synchronous throw reaches the "use the original" fallback.
The size now comes from the decoded bitmap (downscalePhoto.ts:48-56), so missing or transposed rotation metadata can't squash the photo.

Scope: every "Take a photo" flow that goes through AttachmentPicker on native now gets photos of 2880 px or less on devices that ignore the resolution hint. That includes chat attachments, avatars, receipt attach, and odometer images. 2880 px is the size those flows got before VisionCamera v5, so this restores the old behavior.

Web is not affected. Every changed file is reachable only from native code, so I did not run a web test.

Minor side effects (not blockers)

Metadata: downscaled photos lose EXIF metadata, such as capture date and GPS, because the manipulator writes a new JPEG. This only applies to oversized captures. The receipt camera already re-encodes photos in rotatePhotoToUpright.ts:46-49, so the same behavior already exists there.
Memory: affected devices now decode the full-size photo, which takes about 200 MB of native memory for 50 MP. The receipt camera already does the same. I could not confirm whether an out-of-memory error on a low-RAM device would reject (and fall back) or crash.
Log prefix: the receipt flow's release warning changes from [PhotoUpgrade] to [cameraCapture]. Update any log search that matches the old prefix.

view run

AndrewGable

This fixes the blocker: #104941 (comment)

OSBotify · 2026-10-26T16:01:57Z

✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release.

…ent-camera-downscale [CP Staging] fix: Downscale oversized in-app camera photos before use (cherry picked from commit fbb7858) (cherry-picked to staging by AndrewGable)

github-actions · 2026-10-26T16:28:37Z

🚧 AndrewGable has triggered a test Expensify/App build. You can view the workflow run here.

github-actions · 2026-10-26T16:35:34Z

🧪🧪 Use the links below to test this adhoc build on Android, iOS, and Web. Happy testing! 🧪🧪
Built from App PR #104979 with the pinned Mobile-Expensify submodule.

Android 🤖	iOS 🍎
https://ad-hoc-expensify-cash.s3.us-east-1.amazonaws.com/rock-artifacts/ad-hoc/rock-android-Adhoc-fbb78581-04bdaa5-13d64a0bd11b1f38ab86b8623ed458403c141c19/index.html	https://ad-hoc-expensify-cash.s3.us-east-1.amazonaws.com/rock-artifacts/ad-hoc/rock-ios-device-AdHoc-fbb78581-04bdaa5-50e9e1cac7d9172fcb968f42cc1bfea232afff10/index.html

Web 🕸️
https://104979.pr-testing.expensify.com

👀 View the workflow run that generated this build 👀

os-botify · 2026-10-26T16:35:45Z

🔁 Filed a Staging retest request for deploy blockers #104941 after this PR was cherry-picked to staging.

OSBotify · 2026-10-26T16:36:48Z

🚀 Cherry-picked to staging by https://github.com/AndrewGable in version: 9.5.20-3 🚀

platform	result
🕸 web 🕸	success ✅
🤖 android 🤖	success ✅
🍎 iOS 🍎	success ✅

MelvinBot · 2026-10-26T16:39:33Z

No help site update is needed: this bug fix makes in-app camera photos work in the avatar flow as users already expect, and it doesn't change any feature, label, or size limit that an article describes.

view run

OSBotify · 2026-10-26T20:45:23Z

🚀 Deployed to production by https://github.com/jasperhuangg in version: 9.5.20-5 🚀

platform	result
🕸 web 🕸	success ✅
🤖 android 🤖	success ✅
🍎 iOS 🍎	failure ❌

Bundle Size Analysis (Sentry):

Android
iOS

OSBotify · 2026-10-26T20:59:35Z

🚀 Cherry-picked to staging by https://github.com/AndrewGable in version: 9.5.21-0 🚀

platform	result
🕸 web 🕸	success ✅
🤖 android 🤖	success ✅
🍎 iOS 🍎	success ✅

MelvinBot · 2026-10-26T21:01:40Z

No help site update is needed: this bug fix makes in-app camera photos work in the avatar flow as users already expect, and it doesn't change any feature, label, or size limit that an article describes.

view run

OSBotify · 2026-10-27T00:08:26Z

🚀 Cherry-picked to staging by https://github.com/AndrewGable in version: 9.5.23-0 🚀

platform	result
🕸 web 🕸	success ✅
🤖 android 🤖	success ✅
🍎 iOS 🍎	success ✅

MelvinBot · 2026-10-27T00:10:26Z

No help site update is needed: this bug fix makes in-app camera photos work in the avatar flow as users already expect, and it doesn't change any feature, label, or size limit that an article describes. The PR's files haven't changed since my earlier review, so that answer still stands.

view run

OSBotify · 2026-10-27T22:08:53Z

🚀 Deployed to production by https://github.com/jasperhuangg in version: 9.5.23-3 🚀

platform	result
🕸 web 🕸	success ✅
🤖 android 🤖	success ✅
🍎 iOS 🍎	success ✅

Bundle Size Analysis (Sentry):

Android
iOS

fix: Downscale oversized in-app camera photos before use

5add194

melvin-bot Bot assigned OlimpiaZurek Oct 26, 2026

chatgpt-codex-connector Bot reviewed Oct 26, 2026

View reviewed changes

fix: Resize from the decoded bitmap and fall back on early errors

7414598

OlimpiaZurek force-pushed the fix/104941-attachment-camera-downscale branch from b483d97 to 7414598 Compare October 26, 2026 09:47

OlimpiaZurek marked this pull request as ready for review October 26, 2026 09:51

OlimpiaZurek requested review from a team as code owners October 26, 2026 09:51

melvin-bot Bot requested review from situchan and removed request for a team October 26, 2026 09:51

melvin-bot Bot requested review from trjExpensify and removed request for a team October 26, 2026 09:51

OlimpiaZurek mentioned this pull request Oct 26, 2026

[Due for payment 2026-11-02] Android - Profile - Size exceed error shows up when taking photo for avatar #104941

Closed

1 of 7 tasks

MonilBhavsar changed the title ~~fix: Downscale oversized in-app camera photos before use~~ [CP Staging] fix: Downscale oversized in-app camera photos before use Oct 26, 2026

This comment has been minimized.

Sign in to view

situchan approved these changes Oct 26, 2026

View reviewed changes

melvin-bot Bot requested review from AndrewGable and MonilBhavsar October 26, 2026 11:56

AndrewGable approved these changes Oct 26, 2026

View reviewed changes

AndrewGable merged commit fbb7858 into Expensify:main Oct 26, 2026
41 of 43 checks passed

OSBotify added the CP Staging marks PRs that have been CP'd to staging label Oct 26, 2026

OSBotify mentioned this pull request Oct 26, 2026

Deploy Checklist: New Expensify 2026-10-23 #104870

Closed

Conversation

OlimpiaZurek commented Oct 26, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Explanation of Change

Fixed Issues

Tests

Offline tests

QA Steps

PR Author Checklist

Screenshots/Videos

Uh oh!

OlimpiaZurek commented Oct 26, 2026

Uh oh!

OlimpiaZurek commented Oct 26, 2026

Uh oh!

chatgpt-codex-connector Bot commented Oct 26, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Codex Review Summary

Uh oh!

MelvinBot commented Oct 26, 2026

Review

Uh oh!

codecov Bot commented Oct 26, 2026 • edited by github-actions Bot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Codecov Report

Uh oh!

chatgpt-codex-connector Bot left a comment

Choose a reason for hiding this comment

💡 Codex Review

Uh oh!

chatgpt-codex-connector Bot Oct 26, 2026

Choose a reason for hiding this comment

Uh oh!

melvin-bot Bot commented Oct 26, 2026

Uh oh!

github-actions Bot commented Oct 26, 2026

Uh oh!

This comment has been minimized.

situchan commented Oct 26, 2026

Reviewer Checklist

Screenshots/Videos

Uh oh!

MelvinBot commented Oct 26, 2026

Regression check

Uh oh!

AndrewGable left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

OSBotify commented Oct 26, 2026

Uh oh!

github-actions Bot commented Oct 26, 2026

Uh oh!

github-actions Bot commented Oct 26, 2026

Uh oh!

os-botify Bot commented Oct 26, 2026

Uh oh!

OSBotify commented Oct 26, 2026

Uh oh!

MelvinBot commented Oct 26, 2026

Uh oh!

OSBotify commented Oct 26, 2026

Uh oh!

OSBotify commented Oct 26, 2026

Uh oh!

MelvinBot commented Oct 26, 2026

Uh oh!

OSBotify commented Oct 27, 2026

Uh oh!

MelvinBot commented Oct 27, 2026

Uh oh!

OSBotify commented Oct 27, 2026

Uh oh!

Reviewers

Uh oh!

Assignees

Labels

Projects

Milestone

Development

OlimpiaZurek commented Oct 26, 2026 •

edited

Loading

chatgpt-codex-connector Bot commented Oct 26, 2026 •

edited

Loading

codecov Bot commented Oct 26, 2026 •

edited by github-actions Bot

Loading