Repository navigation
Bump react-native-plaid-link-sdk to 12.8.6 - #105005
Closed
collectioneur wants to merge 1 commit into
Closed
collectioneur wants to merge 1 commit into
collectioneur wants to merge 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Explanation of Change
Upgrades
react-native-plaid-link-sdkfrom 12.5.3 to 12.8.6, the latest 12.x release. 13.x rewrites the Android module on Expo Modules and is left for a separate upgrade.This is one of the dependency bumps split out of the React Native 0.88 upgrade (#101739), so they can be tested and shipped on the current React Native 0.86 before the upgrade lands. The new version works on both 0.86 and 0.88. 12.7.0 reads the current Activity through
reactApplicationContext.currentActivity, which the upgrade PR otherwise has to patch because React Native 0.88 no longer exposes the barecurrentActivityproperty in Kotlin.Native SDK changes:
ios/Frameworks/LinkKit.xcframeworkinstead of thePlaidCocoaPod, because CocoaPods distribution of LinkKit ended at 6.5.1 and CocoaPods trunk becomes read-only on 2026-12-02. The Mobile-Expensify PR removes thePlaidpod fromPodfile.lock.The
fix-oauth-hybrid-app-iospatch is still needed (12.8.6 has nocontinueFromRedirectUri) and was ported to 12.8.6. Upstream now drops the link handler in one place,releaseCurrentSession(used by success, exit,dismiss, the newdestroyandinvalidate), so the patch clears its shared instance there instead of in the exit callback. Seepatches/react-native-plaid-link-sdk/details.md.Fixed Issues
$ #101427
PROPOSAL: N/A
MOBILE-EXPENSIFY: https://github.com/Expensify/Mobile-Expensify/pull/14204
Tests
react-native-plaid-link-sdkis only used on native (web usesreact-plaid-link), so these steps are for the HybridApp on iOS and Android. Web and mWeb are N/A.Offline tests
QA Steps
Same as tests
PR Author Checklist
### Fixed Issuessection aboveTestssectionOffline stepssectionQA stepssectionAvatar, I verified the components usingAvatarare working as expected)npm run compress-svg)Avataris modified, I verified thatAvataris working as expected in all cases)Designlabel and/or tagged@Expensify/designso the design team can review the changes.mainbranch was merged into this PR after a review, I tested again and verified the outcome was still expected according to theTeststeps.Screenshots/Videos
Android: Native
Android: mWeb Chrome
iOS: Native
iOS: mWeb Safari
MacOS: Chrome / Safari