Skip to content

[No QA] Stop deploying staging builds to test-staging - #105156

Merged
roryabraham merged 2 commits into
mainfrom
jpersaud-stop-test-staging-deploy
Oct 27, 2026
Merged

[No QA] Stop deploying staging builds to test-staging#105156
roryabraham merged 2 commits into
mainfrom
jpersaud-stop-test-staging-deploy

Conversation

@justinpersaud

@justinpersaud justinpersaud commented Oct 27, 2026

Copy link
Copy Markdown
Contributor

Explanation of Change

  • Removes the webDeployTestStaging job: staging and production are deployed to their own Cloudflare Workers by webDeploy, so test-staging no longer needs every staging build. It's now only for trying Worker changes by hand, and redeploying it on every staging deploy would overwrite whatever is being tested there.
  • The test-staging environment stays in wrangler.jsonc, so npx wrangler deploy --env test-staging still works. The README and config comment now say it's only deployed by hand.

Fixed Issues

$ https://github.com/Expensify/Expensify/issues/688126
PROPOSAL:

Tests

None yet. After merging, check that the next staging deploy has no Deploy Web to test-staging.new.expensify.com job, and that test-staging still serves whatever was last deployed there by hand.

  • Verify that no errors appear in the JS console

Offline tests

None. This only changes the deploy workflow.

QA Steps

// TODO: These must be filled out, or the issue title must include "[No QA]."

No QA. This only changes the deploy workflow.

  • Verify that no errors appear in the JS console

PR Author Checklist

  • I linked the correct issue in the ### Fixed Issues section above
  • I wrote clear testing steps that cover the changes made in this PR
    • I added steps for local testing in the Tests section
    • I added steps for the expected offline behavior in the Offline steps section
    • I added steps for Staging and/or Production testing in the QA steps section
    • I added steps to cover failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
    • I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
    • I tested this PR with a High Traffic account against the staging or production API to ensure there are no regressions (e.g. long loading states that impact usability).
  • I included screenshots or videos for tests on all platforms
  • I ran the tests on all platforms & verified they passed on:
    • Android: Native
    • Android: mWeb Chrome
    • iOS: Native
    • iOS: mWeb Safari
    • MacOS: Chrome / Safari
  • I verified there are no console errors (if there's a console error not related to the PR, report it or open an issue for it to be fixed)
  • I verified any copy / text that was added to the app is either coming verbatim from figma or has been approved by marketing (in order to get marketing approval, ask the Bug Zero team member to add the Waiting for copy label to the issue)
  • If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
  • I tested other components that can be impacted by my changes (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar are working as expected)
  • If new assets were added or existing ones were modified, I verified that:
    • The assets are optimized and compressed (for SVG files, run npm run compress-svg)
    • The assets load correctly across all supported platforms.
  • If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
  • If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
  • If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
  • If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
  • If the PR modifies the UI (e.g. new buttons, new UI components, changing the padding/spacing/sizing, moving components, etc) or modifies the form input styles:
    • I verified that all the inputs inside a form are aligned with each other.
    • I added Design label and/or tagged @Expensify/design so the design team can review the changes.
  • If the PR adds or modifies the UI:
    • I asked an AI agent to review the changes for accessibility issues and addressed its findings.
    • I tested with a screen reader (VoiceOver on macOS) and verified all new/changed elements are reachable with a logical focus order.
    • I verified all new/changed elements have meaningful accessible names and roles.
    • I verified state changes are announced (e.g. checked/unchecked, expanded/collapsed, selected).
  • I added unit tests for any new feature or bug fix in this PR to help automatically prevent regressions in this user flow.
  • If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.

Screenshots/Videos

Android: Native
Android: mWeb Chrome
iOS: Native
iOS: mWeb Safari
MacOS: Chrome / Safari

@justinpersaud
Stop deploying staging builds to test-staging
384810c 
Staging and production are deployed to their own Workers now, so test-staging is only for trying Worker changes by hand. Redeploying it on every staging deploy would overwrite whatever is being tested there.
@justinpersaud
Document that test-staging is only deployed by hand
ebccece
@justinpersaud
justinpersaud marked this pull request as ready for review October 27, 2026 16:35
@melvin-bot
melvin-bot Bot requested review from getusha and removed request for a team October 27, 2026 16:35
@chatgpt-codex-connector

chatgpt-codex-connector Bot commented Oct 27, 2026 •
edited
Loading

Copy link
Copy Markdown

Codex Review Summary

This comment shows the latest Codex review activity on this pull request.

Review Status Commit Review trigger
📝 Code Review ✅ Completed 2026-10-27T16:44:59.281465Z ebccece Draft marked ready
ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review" or "@codex security review".

Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings.

@melvin-bot

melvin-bot Bot commented Oct 27, 2026

Copy link
Copy Markdown

@getusha Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button]

@justinpersaud
justinpersaud requested review from a team and removed request for getusha October 27, 2026 16:35
@melvin-bot
melvin-bot Bot requested review from Eskalifer1 and removed request for a team October 27, 2026 16:35
@melvin-bot

melvin-bot Bot commented Oct 27, 2026

Copy link
Copy Markdown

@Eskalifer1 Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button]

@justinpersaud
justinpersaud removed the request for review from Eskalifer1 October 27, 2026 16:35
AndrewGable
AndrewGable reviewed Oct 27, 2026
View reviewed changes
Comment thread web/cloudflare-worker/wrangler.jsonc
"env": {
// Serves a staging build on test-staging.new.expensify.com, a hostname nobody else uses.
// Serves a staging build on test-staging.new.expensify.com, a hostname nobody else uses. Only deployed by hand.
"test-staging": {

@AndrewGable AndrewGable Oct 27, 2026

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why should we keep it? Should we just remove it 100%?

@justinpersaud justinpersaud Oct 27, 2026

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Now that this is the only piece of infrastructure that sits in front of App, I think it's useful to have it as a way to test "infrastructure" changes to the worker and validate they work before we send a PR for staging/prod. We could rely on the dev server, but I still like having something live to rule out any differences

@AndrewGable AndrewGable Oct 27, 2026

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nab but can we test changes on AdHoc builds?

@justinpersaud justinpersaud Oct 27, 2026

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yeah that's true, but we need to move over adhoc. I'll look at that next

@roryabraham roryabraham Oct 27, 2026

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@justinpersaud I have these PRs for AdHoc:

I'll get them ready for review. Just want to make sure we're not duplicating work.

@justinpersaud justinpersaud Oct 27, 2026

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

oh ok I'll leave that to you

@roryabraham
roryabraham merged commit de4593c into main Oct 27, 2026
37 of 42 checks passed
@roryabraham
roryabraham deleted the jpersaud-stop-test-staging-deploy branch October 27, 2026 17:04
@OSBotify

OSBotify commented Oct 27, 2026

Copy link
Copy Markdown
Contributor

✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release.

@github-actions

github-actions Bot commented Oct 27, 2026

Copy link
Copy Markdown
Contributor

🚧 roryabraham has triggered a test Expensify/App build. You can view the workflow run here.

@github-actions

github-actions Bot commented Oct 27, 2026

Copy link
Copy Markdown
Contributor

🧪🧪 Use the links below to test this adhoc build on Android, iOS, and Web. Happy testing! 🧪🧪
Built from App PR #105156 with the pinned Mobile-Expensify submodule.

Android 🤖 iOS 🍎
https://ad-hoc-expensify-cash.s3.us-east-1.amazonaws.com/rock-artifacts/ad-hoc/rock-android-Adhoc-de4593c5-cd0c1f9-16686b4d083c14c59350dec9e1c6d15fa7b8424f/index.html https://ad-hoc-expensify-cash.s3.us-east-1.amazonaws.com/rock-artifacts/ad-hoc/rock-ios-device-AdHoc-de4593c5-cd0c1f9-1406c0069963e968e3940d80599dd2c68e696b9b/index.html
Android iOS
Web 🕸️
https://105156.pr-testing.expensify.com
Web

👀 View the workflow run that generated this build 👀

@OSBotify OSBotify mentioned this pull request Oct 27, 2026
Closed
97 tasks done
@OSBotify

OSBotify commented Oct 27, 2026

Copy link
Copy Markdown
Contributor

🚀 Deployed to staging by https://github.com/roryabraham in version: 9.5.24-1 🚀

platform result
🕸 web 🕸 success ✅
🤖 android 🤖 cancelled 🔪
🍎 iOS 🍎 cancelled 🔪

@OSBotify

OSBotify commented Oct 29, 2026

Copy link
Copy Markdown
Contributor

🚀 Deployed to production by https://github.com/jasperhuangg in version: 9.5.24-8 🚀

platform result
🕸 web 🕸 success ✅
🤖 android 🤖 success ✅
🍎 iOS 🍎 success ✅

Bundle Size Analysis (Sentry):

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@AndrewGable AndrewGable AndrewGable approved these changes
@roryabraham roryabraham roryabraham approved these changes

Assignees

@justinpersaud justinpersaud

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@justinpersaud @OSBotify @AndrewGable @roryabraham