Repository navigation
[No QA] Update undici to fix Dependabot alerts - #105614
Conversation
|
npm has a |
Codex Review Summary: ✅ CompletedThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
|
🚧 roryabraham has triggered a test Expensify/App build. You can view the workflow run here. |
|
✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release. |
|
🧪🧪 Use the links below to test this adhoc build on Android, iOS, and Web. Happy testing! 🧪🧪
|
Explanation of Change
App has 15 open Undici alerts across the root and Cloudflare Worker lockfiles. This PR updates the 6.x copy to 6.29.1 and bumps Wrangler so Miniflare uses Undici 7.30.1 in both lockfiles. It also rebuilds the GitHub Actions bundles with the fixed version.
Fixed Issues
$ https://github.com/Expensify/Expensify/issues/688705
Tests
Manual tests: N/A
Verified the installed versions in both dependency trees, rebuilt and verified the GitHub Actions bundles, and ran the root and Cloudflare Worker type checks. All 66 Cloudflare Worker tests and the spell check passed. All 25 generated bundles passed Node syntax checks. Oxlint excludes those generated files.
Offline tests
N/A
QA Steps
N/A
Query Timings/Plans
N/A
PR Author Checklist
### Fixed Issuessection aboveTestssectionOffline stepssectionQA stepssectionAvatar, I verified the components usingAvatarare working as expected)npm run compress-svg)Avataris modified, I verified thatAvataris working as expected in all cases)Designlabel and/or tagged@Expensify/designso the design team can review the changes.mainbranch was merged into this PR after a review, I tested again and verified the outcome was still expected according to theTeststeps.Screenshots/Videos
Android: Native
Android: mWeb Chrome
iOS: Native
iOS: mWeb Safari
MacOS: Chrome / Safari