Repository navigation
DO NOT MERGE: PR preview E2E fixture A - #105691
roryabraham wants to merge 11 commits into
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. |
|
🚧 roryabraham has triggered a test Expensify/App build. You can view the workflow run here. |
This comment has been minimized.
This comment has been minimized.
|
🚧 roryabraham has triggered a test Expensify/App build. You can view the workflow run here. |
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
|
🚧 roryabraham has triggered a test Expensify/App build. You can view the workflow run here. |
This comment has been minimized.
This comment has been minimized.
|
🚧 roryabraham has triggered a test Expensify/App build. You can view the workflow run here. |
This comment has been minimized.
This comment has been minimized.
|
🚧 roryabraham has triggered a test Expensify/App build. You can view the workflow run here. |
This comment has been minimized.
This comment has been minimized.
Restore the normal build after verifying that an intentional failure skips publication and preserves the last good Preview.
|
🚧 roryabraham has triggered a test Expensify/App build. You can view the workflow run here. |
This comment has been minimized.
This comment has been minimized.
|
🚧 roryabraham has triggered a test Expensify/App build. You can view the workflow run here. |
This comment has been minimized.
This comment has been minimized.
|
🚧 roryabraham has triggered a test Expensify/App build. You can view the workflow run here. |
This comment has been minimized.
This comment has been minimized.
|
🚧 roryabraham has triggered a test Expensify/App build. You can view the workflow run here. |
This comment has been minimized.
This comment has been minimized.
|
🚧 roryabraham has triggered a test Expensify/App build. You can view the workflow run here. |
This comment has been minimized.
This comment has been minimized.
|
🚧 roryabraham has triggered a test Expensify/App build. You can view the workflow run here. |
|
🧪🧪 Use the links below to test this adhoc build on Android, iOS, and Web. Happy testing! 🧪🧪
|
Restore normal builds after verifying that a failed build skips publication and preserves the last good Preview.
|
Completed the dedicated Worker hosting experiment and restored the normal build hook. Closing this disposable fixture without merging; its last good Preview is retained. |
Explanation of Change
Disposable E2E fixture A for #104801. Do not merge. This PR targets the migration branch so its diff contains only the experiment markers.
The branch Worker adds
X-Preview-Experiment: A-v1; the independently built HTML includes<meta name="pr-testing-experiment" content="A-v1" />. Seeing both markers at this PR's hostname proves that branch Worker code and matching branch assets were published together.Planned experiment:
testBuild.ymlfromrory/migrate-pr-testing-worker, targeting this PR, with web enabled and iOS/Android disabled./__expensify_previewand/preview-build.json.AI Tests
Refreshed from the migration branch and App main snapshot
b93c137af31. All 63 Worker tests, including the experiment-header assertion, and Worker typechecks pass after the refresh. A fresh native-Preview web-only CI experiment is running against commit15d6668848dc60c848900d7fdc8cea2651d33e5f, expectingA-v1in both Worker and HTML markers. Live success has not been verified; read-only preflight found Preview hosting disabled on the shared parent Worker. Earlier CI built the web assets successfully but targeted the superseded per-PR Worker model.Fixed Issues
$
PROPOSAL:
Tests
// TODO: The human co-author must fill out the tests you ran before marking this PR as "ready for review".
// Please describe what tests you performed that validates your changes worked.
Offline tests
QA Steps
// TODO: The human co-author must fill out the QA tests you ran before marking this PR as "ready for review".
// Please describe what QA needs to do to validate your changes and what areas they need to test for regressions.
PR Author Checklist
### Fixed Issuessection aboveTestssectionOffline stepssectionQA stepssectionAvatar, I verified the components usingAvatarare working as expected)npm run compress-svg)Avataris modified, I verified thatAvataris working as expected in all cases)Designlabel and/or tagged@Expensify/designso the design team can review the changes.mainbranch was merged into this PR after a review, I tested again and verified the outcome was still expected according to theTeststeps.Screenshots/Videos
Android: Native
Android: mWeb Chrome
iOS: Native
iOS: mWeb Safari
MacOS: Chrome / Safari