Skip to content

DO NOT MERGE: PR preview E2E fixture B - #105692

Closed
roryabraham wants to merge 5 commits into
rory/migrate-pr-testing-workerfrom
rory/pr-testing-e2e-b
Closed

roryabraham wants to merge 5 commits into
rory/migrate-pr-testing-workerfrom
rory/pr-testing-e2e-b

Conversation

@roryabraham

@roryabraham roryabraham commented Nov 2, 2026 •

Copy link
Copy Markdown
Contributor

Explanation of Change

Disposable E2E fixture B for #104801. Do not merge. This PR targets the migration branch so its diff contains only the experiment markers.

The branch Worker adds X-Preview-Experiment: B-v1; the independently built HTML includes <meta name="pr-testing-experiment" content="B-v1" />. Fixture B is the unchanged control while fixture A is rebuilt, canceled or intentionally broken.

Planned experiment:

  1. Dispatch testBuild.yml from rory/migrate-pr-testing-worker, targeting this PR, with web enabled and iOS/Android disabled.
  2. Verify the Worker header, HTML meta marker and matching SHA/run/attempt at /__expensify_preview and /preview-build.json.
  3. Confirm B remains unchanged throughout fixture A's update, cancellation and failure tests.
  4. Close a fixture after verification and confirm its preview remains available.

AI Tests

Refreshed from the migration branch and App main snapshot b93c137af31. All 63 Worker tests, including the experiment-header assertion, and Worker typechecks pass after the refresh. A fresh native-Preview web-only CI experiment is running against commit 04788ce4ec5ef365147ada29d6a1c2bdd2099db7, expecting B-v1 in both Worker and HTML markers. Live success has not been verified; read-only preflight found Preview hosting disabled on the shared parent Worker. Earlier CI built the web assets successfully but targeted the superseded per-PR Worker model.

Fixed Issues

$
PROPOSAL:

Tests

// TODO: The human co-author must fill out the tests you ran before marking this PR as "ready for review".
// Please describe what tests you performed that validates your changes worked.

  • Verify that no errors appear in the JS console

Offline tests

QA Steps

// TODO: The human co-author must fill out the QA tests you ran before marking this PR as "ready for review".
// Please describe what QA needs to do to validate your changes and what areas they need to test for regressions.

  • Verify that no errors appear in the JS console

PR Author Checklist

  • I linked the correct issue in the ### Fixed Issues section above
  • I wrote clear testing steps that cover the changes made in this PR
    • I added steps for local testing in the Tests section
    • I added steps for the expected offline behavior in the Offline steps section
    • I added steps for Staging and/or Production testing in the QA steps section
    • I added steps to cover failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
    • I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
    • I tested this PR with a High Traffic account against the staging or production API to ensure there are no regressions (e.g. long loading states that impact usability).
  • I included screenshots or videos for tests on all platforms
  • I ran the tests on all platforms & verified they passed on:
    • Android: Native
    • Android: mWeb Chrome
    • iOS: Native
    • iOS: mWeb Safari
    • MacOS: Chrome / Safari
  • I verified there are no console errors (if there's a console error not related to the PR, report it or open an issue for it to be fixed)
  • I verified any copy / text that was added to the app is either coming verbatim from figma or has been approved by marketing (in order to get marketing approval, ask the Bug Zero team member to add the Waiting for copy label to the issue)
  • If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
  • I tested other components that can be impacted by my changes (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar are working as expected)
  • If new assets were added or existing ones were modified, I verified that:
    • The assets are optimized and compressed (for SVG files, run npm run compress-svg)
    • The assets load correctly across all supported platforms.
  • If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
  • If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
  • If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
  • If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
  • If the PR modifies the UI (e.g. new buttons, new UI components, changing the padding/spacing/sizing, moving components, etc) or modifies the form input styles:
    • I verified that all the inputs inside a form are aligned with each other.
    • I added Design label and/or tagged @Expensify/design so the design team can review the changes.
  • If the PR adds or modifies the UI:
    • I asked an AI agent to review the changes for accessibility issues and addressed its findings.
    • I tested with a screen reader (VoiceOver on macOS) and verified all new/changed elements are reachable with a logical focus order.
    • I verified all new/changed elements have meaningful accessible names and roles.
    • I verified state changes are announced (e.g. checked/unchecked, expanded/collapsed, selected).
  • I added unit tests for any new feature or bug fix in this PR to help automatically prevent regressions in this user flow.
  • If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.

Screenshots/Videos

Android: Native
Android: mWeb Chrome
iOS: Native
iOS: mWeb Safari
MacOS: Chrome / Safari

@codecov

codecov Bot commented Nov 2, 2026 •

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
see 202 files with indirect coverage changes

@github-actions

github-actions Bot commented Nov 2, 2026

Copy link
Copy Markdown
Contributor

🚧 roryabraham has triggered a test Expensify/App build. You can view the workflow run here.

@github-actions
github-actions Bot had a problem deploying to pr-testing-105692 November 2, 2026 23:11 Failure
@github-actions

This comment has been minimized.

@github-actions

github-actions Bot commented Nov 4, 2026

Copy link
Copy Markdown
Contributor

🚧 roryabraham has triggered a test Expensify/App build. You can view the workflow run here.

@github-actions

This comment has been minimized.

@github-actions

This comment has been minimized.

@roryabraham

Copy link
Copy Markdown
Contributor Author

Closing this disposable fixture without merging to verify that its last published Worker Preview remains available.

@roryabraham roryabraham closed this Nov 4, 2026
@roryabraham roryabraham reopened this Nov 11, 2026
@github-actions

Copy link
Copy Markdown
Contributor

🚧 roryabraham has triggered a test Expensify/App build. You can view the workflow run here.

@github-actions

This comment has been minimized.

@github-actions

Copy link
Copy Markdown
Contributor

🚧 roryabraham has triggered a test Expensify/App build. You can view the workflow run here.

@github-actions

This comment has been minimized.

@github-actions

Copy link
Copy Markdown
Contributor

🚧 roryabraham has triggered a test Expensify/App build. You can view the workflow run here.

@github-actions

Copy link
Copy Markdown
Contributor

🧪🧪 Use the links below to test this adhoc build on Android, iOS, and Web. Happy testing! 🧪🧪
Built from App PR #105692 with the pinned Mobile-Expensify submodule.

Android 🤖 iOS 🍎
⏩ SKIPPED ⏩ ⏩ SKIPPED ⏩
The build for Android was skipped The build for iOS was skipped
Web 🕸️
https://105692.adhoc.expensify.com
Web

👀 View the workflow run that generated this build 👀

@roryabraham

Copy link
Copy Markdown
Contributor Author

Closing this disposable fixture without merging to verify that its new adhoc.expensify.com Preview remains available.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant