Repository navigation
[CFI] Update the Edit multiple flow to use inline editing and dropdown down style rows - #106067
DylanDylann wants to merge 18 commits into
Conversation
|
@ikevin127 Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button] |
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
Reviewer Checklist
Screenshots/VideosScreen.Recording.2026-11-05.at.16.49.39.mov |
…draft transaction logic
Codecov Report❌ Looks like you've decreased code coverage for some files. Please write tests to increase, or at least maintain, the existing level of code coverage. See our documentation here for how to interpret this table.
|
…dit multiple functionality, replacing them with toggle options in the main edit page.
|
@shawnborton @JmillsExpensify I’d suggest letting users type “-” in the amount input as we do in the creation flow, instead of adding a new icon at the end of the row as shown in the mockup. What do you think? My Change Design |
…ferred empty-selection error handling
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
That makes sense, I think we only need the Flip button on mobile devices. |
This comment was marked as outdated.
This comment was marked as outdated.
|
@ikevin127 Ready for review |
JmillsExpensify
left a comment
JmillsExpensify
left a comment
There was a problem hiding this comment.
Agree with the above. All LGTM
ikevin127
left a comment
ikevin127
left a comment
There was a problem hiding this comment.
Requesting changes for two blockers: the amount saves without the currency the row shows, and switching a toggle on and then off writes false to every selected expense.
…n and integrating currency handling in SearchEditMultiple components
…chEditMultiplePage
|
Looks like this'll be ready for another review soon? |
|
I see some commits so I'll run another test build. |
|
🚧 shawnborton has triggered a test Expensify/App build. You can view the workflow run here. |
|
🧪🧪 Use the links below to test this adhoc build on Android, iOS, and Web. Happy testing! 🧪🧪
|
|
For tags, I don't think we need to repeat the field label above the popover. We only do that for mobile when we launch the popover from the bottom using the bottom-docked pattern: |
|
On that note, I thought we decided that for mobile inline popovers, all of them should have the small back arrow and heading title like this? cc @trjExpensify for confirmation there |
Correct. 👍 |
ikevin127
left a comment
ikevin127
left a comment
There was a problem hiding this comment.
Request changes with blockers. Resolved the thread, but saveDraftReimbursable and saveDraftBillable still write isOn straight to the draft, so switching a toggle on then off still sends false to every selected expense. The QA steps also still describe Billable and Reimbursable as dropdown rows, and they are toggles now.
For this, I’d prefer to keep it as is so it stays consistent between the creation flow and the edit details flow. If we agree to change it, I suggest doing it in a separate PR that fixes it everywhere |
|
@shawnborton @ikevin127 Updated the reimbursable toggle 
|
|
If Don't change is selected, shouldn't that be reflected in the input itself? I don't see a value under the label. |
…earchEditMultiplePage to integrate AmountFormField. Add tests for borderless button behavior.
|
The failed check on main |
What is this "Don't change" thing? I don't see it on prod. I even selected one non-reimbursable expense and one reimbursable expense. 🤔 
|
ikevin127
left a comment
ikevin127
left a comment
There was a problem hiding this comment.
🟢 LGTM - Approved. The currency and the on/off toggle problems are both fixed. Before merge, please fill in the empty Explanation of Change and add a QA step for the new Billable and Reimbursable Don’t change / Yes / No list.
- QA step 1 matches the new rows. Step 13 mentions billable but never says how to pick a value.
- Suggested wording: "Press Reimbursable and Billable. Verify the list shows
Don’t changepicked by default, then pickNo. Save and verify every expense is marked non-reimbursable and non-billable. Reopen, leave it onDon’t change, save and verify the expenses keep their own values." - QA runs steps verbatim, so this one is worth adding.
- Suggested wording: "Press Reimbursable and Billable. Verify the list shows
cc @DylanDylann
|
@trjExpensify On production, you can click a selected option again to deselect it. When no option is selected, the expenses keep their previous value. That’s what “Don’t change” means. |
|
https://expensify.slack.com/archives/C07NMDKEFMH/p1794486527172629?thread_ts=1794244871.313419&cid=C07NMDKEFMH let's talk about it in real time. |
…ion and update related logic
|
@trjExpensify Got it. Updated Screen.Recording.2026-11-13.at.13.50.12.mov |
…ByRow for Reimbursable visibility checks
Explanation of Change
Fixed Issues
$ #101571
PROPOSAL:
Tests
Same as QA steps
Offline tests
QA Steps
Precondition: a workspace with categories, tags, tax tracking and attendee tracking enabled, and at least three expenses submitted to it. Go to Reports > Expenses, select two or more of those expenses and choose
Edit multiple.Edit multipleagain. Press the currency code on the Amount row. Verify the currency picker opens. Pick another currency and verify the symbol and code on the row update. Type an amount and press Save. Verify every selected expense gets that amount in the picked currency.Edit multipleagain. Type(none)as the merchant. Verify an error shows under the field and Save does nothing. Clear the field and verify the error goes away.0as the amount. Verify an error shows under the field and Save does nothing.PR Author Checklist
### Fixed Issuessection aboveTestssectionOffline stepssectionQA stepssectionAvatar, I verified the components usingAvatarare working as expected)npm run compress-svg)Avataris modified, I verified thatAvataris working as expected in all cases)Designlabel and/or tagged@Expensify/designso the design team can review the changes.mainbranch was merged into this PR after a review, I tested again and verified the outcome was still expected according to theTeststeps.Screenshots/Videos
Android: Native
Screen.Recording.2026-11-05.at.17.03.57.mov
Android: mWeb Chrome
Screen.Recording.2026-11-05.at.17.01.19.mov
iOS: Native
Screen.Recording.2026-11-05.at.16.45.45.mov
iOS: mWeb Safari
Screen.Recording.2026-11-05.at.16.54.39.mov
MacOS: Chrome / Safari
Screen.Recording.2026-11-05.at.16.44.34.mov