Skip to content

Use TypeScript 7.1 APIs and remove TypeScript 6 - #106311

Draft
roryabraham wants to merge 13 commits into
mainfrom
rory/ts71-beta-compiler
Draft

Use TypeScript 7.1 APIs and remove TypeScript 6#106311
roryabraham wants to merge 13 commits into
mainfrom
rory/ts71-beta-compiler

Conversation

@roryabraham

@roryabraham roryabraham commented Nov 7, 2026 •
edited
Loading

Copy link
Copy Markdown
Contributor

Explanation of Change

Use TypeScript 7.1's native API throughout the compiler utilities and remove @typescript/typescript6. Preserve existing lint checks with generated upstream syntax-only rule snapshots.

Fixed Issues

$ https://github.com/Expensify/Expensify/issues/701267
PROPOSAL:

Tests

// TODO: The human co-author must fill out the tests you ran before marking this PR as "ready for review"
// Please describe what tests you performed that validates your changed worked.

  • Verify that no errors appear in the JS console

Offline tests

Not applicable: tooling and type annotations only.

QA Steps

// TODO: The human co-author must fill out the QA tests you ran before marking this PR as "ready for review".
// Please describe what QA needs to do to validate your changes and what areas do they need to test for regressions.

  • Verify that no errors appear in the JS console

AI Tests

Clean install, six typecheck projects, full lint, spelling, formatting and patch checks pass; 889 Bun tests and 623 lint-rule tests pass. Generated rule snapshots retain upstream formatting and comments. Independent staged review passed.

PR Author Checklist

  • I linked the correct issue in the ### Fixed Issues section above
  • I wrote clear testing steps that cover the changes made in this PR
    • I added steps for local testing in the Tests section
    • I added steps for the expected offline behavior in the Offline steps section
    • I added steps for Staging and/or Production testing in the QA steps section
    • I added steps to cover failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
    • I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
    • I tested this PR with a High Traffic account against the staging or production API to ensure there are no regressions (e.g. long loading states that impact usability).
  • I included screenshots or videos for tests on all platforms
  • I ran the tests on all platforms & verified they passed on:
    • Android: Native
    • Android: mWeb Chrome
    • iOS: Native
    • iOS: mWeb Safari
    • MacOS: Chrome / Safari
  • I verified there are no console errors (if there's a console error not related to the PR, report it or open an issue for it to be fixed)
  • I verified any copy / text that was added to the app is either coming verbatim from figma or has been approved by marketing (in order to get marketing approval, ask the Bug Zero team member to add the Waiting for copy label to the issue)
  • If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
  • I tested other components that can be impacted by my changes (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar are working as expected)
  • If new assets were added or existing ones were modified, I verified that:
    • The assets are optimized and compressed (for SVG files, run npm run compress-svg)
    • The assets load correctly across all supported platforms.
  • If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
  • If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
  • If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
  • If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
  • If the PR modifies the UI (e.g. new buttons, new UI components, changing the padding/spacing/sizing, moving components, etc) or modifies the form input styles:
    • I verified that all the inputs inside a form are aligned with each other.
    • I added Design label and/or tagged @Expensify/design so the design team can review the changes.
  • If the PR adds or modifies the UI:
    • I asked an AI agent to review the changes for accessibility issues and addressed its findings.
    • I tested with a screen reader (VoiceOver on macOS) and verified all new/changed elements are reachable with a logical focus order.
    • I verified all new/changed elements have meaningful accessible names and roles.
    • I verified state changes are announced (e.g. checked/unchecked, expanded/collapsed, selected).
  • I added unit tests for any new feature or bug fix in this PR to help automatically prevent regressions in this user flow.
  • If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.

Screenshots/Videos

Android: Native
Android: mWeb Chrome
iOS: Native
iOS: mWeb Safari
MacOS: Chrome / Safari

@roryabraham roryabraham self-assigned this Nov 7, 2026
@roryabraham
roryabraham requested a review from a team November 7, 2026 21:35
@roryabraham roryabraham mentioned this pull request Nov 7, 2026
Draft
38 tasks
@roryabraham
chore: checkpoint WIP native scanner migration
f7cc596 
LOCAL WIP only; not ready to merge, push, or open as a PR.

Use the native async API and dispose compiler/source leases. Move scanner tests to Bun. The beta sync API crashes under Bun at stdout._handle.fd.

Latest full scanner run: 14/16 Bun cases pass. Malformed-TypeScript and directory cases time out in the full run, although isolated error-path tests pass. These failures remain unresolved.

Bun/Jest project typechecks, changed-file lint/spelling, formatting, and staged self-review pass. No claim of complete TS6 removal.
@roryabraham

roryabraham commented Nov 9, 2026

Copy link
Copy Markdown
Contributor Author

@codex review

@chatgpt-codex-connector

chatgpt-codex-connector Bot commented Nov 9, 2026 •
edited
Loading

Copy link
Copy Markdown
Codex Review Summary: ✅ Completed

This comment shows the latest Codex review activity on this pull request.

Review Status Commit Review trigger
📝 Code Review ✅ Completed 2026-11-09T21:23:09.223778Z f4f20ca Manual request
ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review" or "@codex security review".

Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings.

@chatgpt-codex-connector

chatgpt-codex-connector Bot commented Nov 9, 2026

Copy link
Copy Markdown

Codex Review: Didn't find any major issues. You're on a roll.

Reviewed commit: f4f20caf4c

ℹ️ About Codex in GitHub

Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".

@roryabraham
fix: await native scanner I/O before assertions
44207c1 
Bun promise matchers can stall native compiler RPC callbacks. Await scans directly, preserving all assertions and the five-second performance threshold.

The native scanner suite passes all 16 cases in three consecutive runs. Full App typecheck, changed-file lint/spelling, formatting, and real CLI smoke checks pass. Staged self-review used because nested reviewer agents are unavailable.
@roryabraham
refactor: migrate translation tooling to TS7 API
6a7555c
@roryabraham
fix: preserve tagged template raw spelling
426ddc7
@roryabraham
build(lint): remove legacy compiler consumers
5e51b8a 
Keep hosted rule implementations and fixture scope analysis without a\nJavaScript TypeScript compiler. Preserve existing lint diagnostics and\nremove the seven compiler-routing patches.
@roryabraham
Merge native API migration for translation tooling
d01f9bc
@roryabraham
fix(lint): tokenize TypeScript decorators
0bc469d
@roryabraham
perf: scan comment trivia without token trees
528ac73
@roryabraham
fix(lint): preserve parser and Unicode parity
e8426f5
@roryabraham
build: remove TypeScript 6 compiler dependency
e704e8f 
Run compiler utilities through the native API and keep hosted lint
checks without loading the retired compiler. Generated syntax-only
rule snapshots preserve pinned upstream behavior and licenses.
@roryabraham roryabraham changed the title Upgrade App to TypeScript 7.1 beta Use TypeScript 7.1 APIs and remove TypeScript 6 Nov 9, 2026

This branch has not been deployed

No deployments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@justinpersaud justinpersaud Awaiting requested review from justinpersaud justinpersaud will be requested when the pull request is marked ready for review justinpersaud is a code owner
@AndrewGable AndrewGable Awaiting requested review from AndrewGable AndrewGable will be requested when the pull request is marked ready for review AndrewGable is a code owner

At least 1 approving review is required to merge this pull request.

Assignees

@roryabraham roryabraham

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

1 participant

@roryabraham