Skip to content

Fix travel billing showing as on for workspaces not linked to the domain's travel feed - #106565

Open
blimpich wants to merge 5 commits into
mainfrom
blimpich-ctbUnlinkedWorkspaceToggle
Open

blimpich wants to merge 5 commits into
mainfrom
blimpich-ctbUnlinkedWorkspaceToggle

Conversation

@blimpich

@blimpich blimpich commented Nov 10, 2026 •

Copy link
Copy Markdown
Contributor

Explanation of Change

When a company's domain runs Consolidated Travel Billing for one workspace, any other workspace on that domain's Expensify Card showed travel billing as already on, along with the first workspace's travel spend, limit and settlement account. Admins of that other workspace could change the first workspace's travel settings and had no way to turn travel billing on for their own. Now a workspace only shows the domain's travel billing when the domain's travel feed actually lists it, which is the rule the backend already follows, so the toggle reads off and the admin can set travel billing up or join the domain's feed.

Fixed Issues

$ https://github.com/Expensify/Expensify/issues/702725
PROPOSAL:

Tests

  • Verify that no errors appear in the JS console

Offline tests

QA Steps

ping @blimpich to QA this internally with Arctiq.com

  • Verify that no errors appear in the JS console

@blimpich blimpich added the InternalQA This pull request required internal QA label Nov 11, 2026
@blimpich
blimpich marked this pull request as ready for review November 11, 2026 00:33
@blimpich
blimpich requested review from a team as code owners November 11, 2026 00:33
@melvin-bot
melvin-bot Bot requested review from thesahindia and removed request for a team November 11, 2026 00:34
@melvin-bot

melvin-bot Bot commented Nov 11, 2026

Copy link
Copy Markdown

@thesahindia Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button]

@melvin-bot
melvin-bot Bot requested review from joekaufmanexpensify and removed request for a team November 11, 2026 00:34
@chatgpt-codex-connector

chatgpt-codex-connector Bot commented Nov 11, 2026 •

Copy link
Copy Markdown
Codex Review Summary: ✅ Completed

This comment shows the latest Codex review activity on this pull request.

Review Status Commit Review trigger
📝 Code Review ✅ Completed 2026-11-11T00:47:02.358626Z b39eb1d Draft marked ready
ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review" or "@codex security review".

Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings.

@blimpich

Copy link
Copy Markdown
Contributor Author

working on QA-ing this in an ad-hoc build

@github-actions

Copy link
Copy Markdown
Contributor

🚧 blimpich has triggered a test Expensify/App build. You can view the workflow run here.

@github-actions

Copy link
Copy Markdown
Contributor

@blimpich

Copy link
Copy Markdown
Contributor Author
Screenshot 2026-11-10 at 5 13 20 PM

confirmed in the ad hoc build that this fixes the issue where CTB should not show as toggled on ✅

rlinoz
rlinoz previously approved these changes Nov 11, 2026

@allgandalf allgandalf left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm overall, one question

Comment thread src/hooks/useTravelBillingFundID.ts Resolved

This branch has not been deployed

No deployments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

InternalQA This pull request required internal QA Ready To Build

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants