Repository navigation
Conversation
|
@thesahindia Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button] |
Codex Review Summary: ✅ CompletedThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
|
working on QA-ing this in an ad-hoc build |
|
🚧 blimpich has triggered a test Expensify/App build. You can view the workflow run here. |
|
🧪🧪 Use the links below to test this adhoc build on Android, iOS, and Web. Happy testing! 🧪🧪
|
allgandalf
left a comment
There was a problem hiding this comment.
lgtm overall, one question

Explanation of Change
When a company's domain runs Consolidated Travel Billing for one workspace, any other workspace on that domain's Expensify Card showed travel billing as already on, along with the first workspace's travel spend, limit and settlement account. Admins of that other workspace could change the first workspace's travel settings and had no way to turn travel billing on for their own. Now a workspace only shows the domain's travel billing when the domain's travel feed actually lists it, which is the rule the backend already follows, so the toggle reads off and the admin can set travel billing up or join the domain's feed.
Fixed Issues
$ https://github.com/Expensify/Expensify/issues/702725
PROPOSAL:
Tests
Offline tests
QA Steps
ping @blimpich to QA this internally with Arctiq.com