[TMisiukiewicz]

Explanation of Change

Opening an expense from Spend (or editing it in the RHP) sent two Search requests for the same query: an unflagged refetch, then a copy with shouldSaveRecentSearch: true.

The refetch (from useSearchAutoRefetch, refreshSearchAfterReportAction or the totals retry) marks the snapshot pending. That reopens the guard in useSearchPageSetup, so the page fires its own flagged request. search() sees the running request and, because only the new one has the save flag, re-sends the whole query once the first one finishes. On large accounts each response blocks the JS thread for seconds, so every edit froze the app twice.

useSearchPageSetup now skips its request when all of these hold:

• the snapshot is loaded;
• the page has already shown this query since the user last came to Search, so this visit's recent search was saved on arrival (an RHP over Search blurs the page but doesn't count as leaving);
• a first-page request for the same query is already running and returns the same totals, footer breakdown and trip rooms the page needs.

A user arriving on a query that another caller (for example a Home row) is refreshing still sends the flagged request, so it is still saved to recent searches. A not-yet-loaded first page still goes through search() and claims the page for Search. search() itself is unchanged. The new isFirstPageSearchInFlight mirrors the totals, footer breakdown and trip-rooms checks search() uses to decide on a re-fire, and leaves out the save-flag one, which is the duplicate this PR removes.

Fixed Issues

$ #106777
PROPOSAL:

Tests

1. Open Spend → Reports and wait for the results to load
2. Open the network tab and filter by Search
3. Open an expense in the RHP
4. Verify only one Search request goes out for the open query (same hash, offset: 0)
5. Edit the expense description and save
6. Verify only one Search request goes out for the open query
7. Go to Home, then tap the "Awaiting approval" row
8. Verify a Search request with shouldSaveRecentSearch: true goes out for that query and it appears in recent searches
9. Open a new query on the Search page
10. Verify its first request has shouldSaveRecentSearch: true

• Verify that no errors appear in the JS console

Offline tests

Same as before: going offline and back on Spend refetches the open query once.

QA Steps

Same as tests

• Verify that no errors appear in the JS console

PR Author Checklist

• I linked the correct issue in the ### Fixed Issues section above
• I wrote clear testing steps that cover the changes made in this PR
  • I added steps for local testing in the Tests section
  • I added steps for the expected offline behavior in the Offline steps section
  • I added steps for Staging and/or Production testing in the QA steps section
  • I added steps to cover failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
  • I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
  • I tested this PR with a High Traffic account against the staging or production API to ensure there are no regressions (e.g. long loading states that impact usability).
• I included screenshots or videos for tests on all platforms
• I ran the tests on all platforms & verified they passed on:
  • Android: Native
  • Android: mWeb Chrome
  • iOS: Native
  • iOS: mWeb Safari
  • MacOS: Chrome / Safari
• I verified there are no console errors (if there's a console error not related to the PR, report it or open an issue for it to be fixed)
• I followed proper code patterns (see Reviewing the code)
  • I verified that comments were added to code that is not self explanatory
  • I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
  • I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is either coming verbatim from figma or has been approved by marketing (in order to get marketing approval, ask the Bug Zero team member to add the Waiting for copy label to the issue)
• If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
• I followed the guidelines as stated in the Review Guidelines
• I tested other components that can be impacted by my changes (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar are working as expected)
• If a new CSS style is added I verified that:
  • A similar style doesn't already exist
  • The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(theme.componentBG))
• If new assets were added or existing ones were modified, I verified that:
  • The assets are optimized and compressed (for SVG files, run npm run compress-svg)
  • The assets load correctly across all supported platforms.
• If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
• If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
• If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
• If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
• If the PR modifies the UI (e.g. new buttons, new UI components, changing the padding/spacing/sizing, moving components, etc) or modifies the form input styles:
  • I verified that all the inputs inside a form are aligned with each other.
  • I added Design label and/or tagged @Expensify/design so the design team can review the changes.
• If the PR adds or modifies the UI:
  • I asked an AI agent to review the changes for accessibility issues and addressed its findings.
  • I tested with a screen reader (VoiceOver on macOS) and verified all new/changed elements are reachable with a logical focus order.
  • I verified all new/changed elements have meaningful accessible names and roles.
  • I verified state changes are announced (e.g. checked/unchecked, expanded/collapsed, selected).
• I added unit tests for any new feature or bug fix in this PR to help automatically prevent regressions in this user flow.
• If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.

Screenshots/Videos

Android: Native

Android: mWeb Chrome

iOS: Native

iOS: mWeb Safari

MacOS: Chrome / Safari

🤖 Generated with Claude Code

[melvin-bot]

@brunovjk Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button]

[chatgpt-codex-connector]

Codex Review Summary: ✅ Completed

This comment shows the latest Codex review activity on this pull request.

Review	Status	Commit	Review trigger
📝 Code Review	✅ Completed 2026-11-13T07:59:12.503165Z	366913c	Draft marked ready

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

• Open a pull request for review
• Mark a draft as ready
• Comment "@codex review" or "@codex security review".

Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings.

[chatgpt-codex-connector]

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 366913cc94

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

• Open a pull request for review
• Mark a draft as ready
• Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

[chatgpt-codex-connector]

Avoid marking background snapshots as shown

On native, background tabs keep rendering (src/libs/Navigation/AppNavigator/FreezeWrapper/index.native.tsx). If a refetch finishes after leaving Spend, this assignment repopulates shownHashRef while another tab is active, undoing the blur cleanup. Opening the same query during Home's next unflagged refresh then satisfies the new skip guard, so the page never sends the save-recent request for that visit. The Search-internal effect also skips while loading and deliberately does not rerun on focus. Only mark the hash as shown while Search is the topmost fullscreen route, preserving the RHP case without treating an offscreen snapshot update as a user visit.

Useful? React with 👍 / 👎.