Repository navigation
[HOLD Web-Expensify#58532] Add a Concierge page to the flat navigation - #106799
Draft
rushatgabhane wants to merge 3 commits into
Draft
rushatgabhane wants to merge 3 commits into
rushatgabhane wants to merge 3 commits into
Conversation
|
Hey, I noticed you changed If you want to automatically generate translations for other locales, an Expensify employee will have to:
Alternatively, if you are an external contributor, you can run the translation script locally with your own OpenAI API key. To learn more, try running: npx bun ./scripts/generateTranslations.ts --helpTypically, you'd want to translate only what you changed by running |
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Explanation of Change
Adds a Concierge item to the flat navigation, between Home and Inbox. It opens its own page: a list of Concierge conversations on the left and the open one on the right. Clicking Concierge or New always lands on the new chat screen, and every message sent there starts a new thread, including tasks.
Concierge messages that nobody has opened yet show up in the list too, and opening one turns it into a thread. Inbox no longer shows the Concierge DM or its threads for these users. Links to a Concierge thread open on the Concierge page.
Auth: https://github.com/Expensify/Auth/pull/26660
Web-Expensify: https://github.com/Expensify/Web-Expensify/pull/58532
Fixed Issues
$ #106759
PROPOSAL:
Tests
flatNavbeta.[] Call the bank, and check that it also starts a new thread.r/<threadReportID>, and check that it opens on the Concierge page.flatNavbeta and check that Concierge is back in Inbox as before.Offline tests
QA Steps
Same as tests.
PR Author Checklist
### Fixed Issuessection aboveTestssectionOffline stepssectionQA stepssectionAvatar, I verified the components usingAvatarare working as expected)npm run compress-svg)Avataris modified, I verified thatAvataris working as expected in all cases)Designlabel and/or tagged@Expensify/designso the design team can review the changes.mainbranch was merged into this PR after a review, I tested again and verified the outcome was still expected according to theTeststeps.Screenshots/Videos
Android: Native
Android: mWeb Chrome
iOS: Native
iOS: mWeb Safari
MacOS: Chrome / Safari