Skip to content

fix: Resolve keyboard overlap for Apply button in Withdrawal ID filter - #106814

Closed
KonstantinPythonLab wants to merge 1 commit into
Expensify:mainfrom
KonstantinPythonLab:fix-issue-105145
Closed

KonstantinPythonLab wants to merge 1 commit into
Expensify:mainfrom
KonstantinPythonLab:fix-issue-105145

Conversation

@KonstantinPythonLab

@KonstantinPythonLab KonstantinPythonLab commented Nov 13, 2026 •

Copy link
Copy Markdown

Summary

This PR addresses an issue on Android where the "Apply" button in the "Withdrawal ID" exposed filter is overlapped by the keyboard, making it inaccessible to the user. The fix ensures that the "Apply" button remains visible and interactive even when the keyboard is active.

Changes

  • src/pages/iou/steps/IOUAmountPage/WithdrawalAccountForm.tsx:
    • Wrapped the form content in a ScrollView component.
    • Added a useEffect hook to listen for keyboardDidShow events.
    • When the keyboard appears, the ScrollView is programmatically scrolled to the bottom using scrollViewRef.current?.scrollToEnd({animated: true}). This ensures that the "Apply" button, which is positioned at the bottom of the form, is always visible.

Verification

  1. Open the Expensify app on an Android device.
  2. Navigate to "Spend" > "Expenses".
  3. Tap on the "Filters" icon.
  4. Select "Withdrawal ID" and tap "Confirm".
  5. Tap on the "Apply Filters" button.
  6. Tap on the text input field for "Withdrawal ID" to bring up the keyboard.
  7. Observe that the "Apply" button is now fully visible and accessible, not overlapped by the keyboard.
  8. Attempt to scroll the content manually to confirm it behaves as expected.

$ #105145

Algora Bounty Claim / Payout Address:
BEP-20 (BNB Smart Chain / USDT): 0xF3eB3302483845763b54C080a4eF24df7dc368Ef

@chatgpt-codex-connector

Copy link
Copy Markdown
Codex Review Summary: 🔄 Running

This comment shows the latest Codex review activity on this pull request.

Review Status Commit Review trigger
📝 Code Review 🔄 Running since 2026-11-13T08:06:29.908896Z 3bccf6f PR opened
ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review" or "@codex security review".

Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings.

@melvin-bot
melvin-bot Bot removed the request for review from a team November 13, 2026 08:06
@github-actions

Copy link
Copy Markdown
Contributor

👋 Hi @KonstantinPythonLab, thanks for your interest in contributing to Expensify!

This PR has been automatically closed because it doesn't appear to meet our contribution requirements:

  • You are not a member of the Expensify GitHub organization
  • You are not a member of the Expensify contributor-plus GitHub team
  • No linked GitHub issue was found in the PR description where you are listed as an assignee

If you'd like to contribute, please make sure to:

  1. Find an open issue you'd like to work on
  2. Get assigned to the issue by following our contribution process
  3. Link the issue in your PR description using the format: $ https://github.com/Expensify/App/issues/<issueID>

Please review our contributing guidelines for more details.

If you believe this was closed in error, please reach out in the #expensify-open-source Slack channel.

@github-actions github-actions Bot closed this Nov 13, 2026
@github-actions github-actions Bot locked as spam and limited conversation to collaborators Nov 13, 2026
@melvin-bot
melvin-bot Bot requested review from deetergp and removed request for a team November 13, 2026 08:06
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant