Handle highlight-on-return animation upon newly created workspace rooms#91284
Draft
jakubstec wants to merge 17 commits into
Draft
Conversation
…ski/feature/workspace-rooms-list
…ooms/add-create-button-interaction
…re/workspace-rooms-list
- Use styles.flex3/flex2/flex1 instead of inline {flex: N} so column widths share one source of truth between header and row
- Move column header into FlatList ListHeaderComponent
- Use textLabelSupporting for column titles
- Replace per-row PERSONAL_DETAILS_LIST subscription with getPersonalDetailsByIDs
Filter archived/hidden rooms, derive room name from report attributes, and exclude hidden participants from the member count. Lift personal-details lookup to the page and pass per-row data into WorkspaceRoomsListItem. Switch FlatList to FlashList, disable the placeholder Create button, add the persistent row background, hover state, 8px row gap, and the column flex constants shared between the header and rows.
Tell useOnyx to invalidate its selector cache when policyID changes instead of relying on selector reference identity, matching the SuggestionMention pattern.
Use the existing styles.flex1/flex2/flex3 helpers directly in the header and row instead of wrapping them in a separate columnFlex module.
… tests for that selectors
…racking branch 'origin' into jakubstec/workspace-rooms/add-create-button-interaction-animation
52 tasks
Codecov Report❌ Looks like you've decreased code coverage for some files. Please write tests to increase, or at least maintain, the existing level of code coverage. See our documentation here for how to interpret this table.
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Explanation of Change
Fixed Issues
$
PROPOSAL:
Tests
Offline tests
QA Steps
// TODO: These must be filled out, or the issue title must include "[No QA]."
PR Author Checklist
### Fixed Issuessection aboveTestssectionOffline stepssectionQA stepssectiontoggleReportand notonIconClick)src/languages/*files and using the translation methodSTYLE.md) were followedAvatar, I verified the components usingAvatarare working as expected)StyleUtils.getBackgroundAndBorderStyle(theme.componentBG))npm run compress-svg)Avataris modified, I verified thatAvataris working as expected in all cases)Designlabel and/or tagged@Expensify/designso the design team can review the changes.ScrollViewcomponent to make it scrollable when more elements are added to the page.mainbranch was merged into this PR after a review, I tested again and verified the outcome was still expected according to theTeststeps.Screenshots/Videos
MacOS: Chrome / Safari
Screen.Recording.2026-05-21.at.12.00.14.mov