refactor: split SearchContext into narrow Query, Results, and Selection providers#91303
Draft
TMisiukiewicz wants to merge 8 commits into
Draft
refactor: split SearchContext into narrow Query, Results, and Selection providers#91303TMisiukiewicz wants to merge 8 commits into
TMisiukiewicz wants to merge 8 commits into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Explanation of Change
The monolithic
SearchContextwas serving three unrelated concerns (query state, results/data, and selection state) through a single context object. Any component consuming even one field caused re-renders on all three axes of change.This refactor splits
SearchContextinto three narrow providers:SearchQueryProvider— owns query string and filter stateSearchResultsProvider— owns results data, loading state, and sort configSearchSelectionProvider— owns selection set and bulk-action stateAll 90+ consumers across components, hooks, pages, and tests are migrated to import from the matching narrow hook (
useSearchQuery,useSearchResults,useSearchSelection). The oldSearchContextshim and its re-exports are removed. A newSearchContextDefinitions.tsfile holds shared type definitions to avoid circular imports.The public API of the
Searchcomponent is unchanged. Tests are updated to use the newMockSearchContextProviderutility.Fixed Issues
$ #77173
PROPOSAL:
Tests
Offline tests
N/A
QA Steps
Same as tests
PR Author Checklist
### Fixed Issuessection aboveTestssectionOffline stepssectionQA stepssectiontoggleReportand notonIconClick)src/languages/*files and using the translation methodSTYLE.md) were followedAvatar, I verified the components usingAvatarare working as expected)StyleUtils.getBackgroundAndBorderStyle(theme.componentBG))npm run compress-svg)Avataris modified, I verified thatAvataris working as expected in all cases)Designlabel and/or tagged@Expensify/designso the design team can review the changes.ScrollViewcomponent to make it scrollable when more elements are added to the page.mainbranch was merged into this PR after a review, I tested again and verified the outcome was still expected according to theTeststeps.Screenshots/Videos
Android: Native
Android: mWeb Chrome
iOS: Native
iOS: mWeb Safari
MacOS: Chrome / Safari