Skip to content

[No QA] Update Invite-members-and-assign-roles.md#91319

Merged
stephanieelliott merged 1 commit into
mainfrom
brianlee-expensify-patch-3
May 22, 2026
Merged

[No QA] Update Invite-members-and-assign-roles.md#91319
stephanieelliott merged 1 commit into
mainfrom
brianlee-expensify-patch-3

Conversation

@brianlee-expensify
Copy link
Copy Markdown
Contributor

taken from the NewDot version: https://help.expensify.com/articles/new-expensify/reports-and-expenses/Approve-Expenses

Explanation of Change

Fixed Issues

$
PROPOSAL:

Tests

  • Verify that no errors appear in the JS console

Offline tests

QA Steps

// TODO: These must be filled out, or the issue title must include "[No QA]."

  • Verify that no errors appear in the JS console

PR Author Checklist

  • I linked the correct issue in the ### Fixed Issues section above
  • I wrote clear testing steps that cover the changes made in this PR
    • I added steps for local testing in the Tests section
    • I added steps for the expected offline behavior in the Offline steps section
    • I added steps for Staging and/or Production testing in the QA steps section
    • I added steps to cover failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
    • I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
    • I tested this PR with a High Traffic account against the staging or production API to ensure there are no regressions (e.g. long loading states that impact usability).
  • I included screenshots or videos for tests on all platforms
  • I ran the tests on all platforms & verified they passed on:
    • Android / native
    • Android / Chrome
    • iOS / native
    • iOS / Safari
    • MacOS / Chrome / Safari
    • MacOS / Desktop
  • I verified there are no console errors (if there's a console error not related to the PR, report it or open an issue for it to be fixed)
  • I followed proper code patterns (see Reviewing the code)
    • I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick)
    • I verified that the left part of a conditional rendering a React component is a boolean and NOT a string, e.g. myBool && <MyComponent />.
    • I verified that comments were added to code that is not self explanatory
    • I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
    • I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method
      • If any non-english text was added/modified, I verified the translation was requested/reviewed in #expensify-open-source and it was approved by an internal Expensify engineer. Link to Slack message:
    • I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
    • I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is approved by marketing by adding the Waiting for Copy label for a copy review on the original GH to get the correct copy.
    • I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
    • I verified the JSDocs style guidelines (in STYLE.md) were followed
  • If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
  • I followed the guidelines as stated in the Review Guidelines
  • I tested other components that can be impacted by my changes (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar are working as expected)
  • I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
  • I verified any variables that can be defined as constants (ie. in CONST.js or at the top of the file that uses the constant) are defined as such
  • I verified that if a function's arguments changed that all usages have also been updated correctly
  • If a new component is created I verified that:
    • A similar component doesn't exist in the codebase
    • All props are defined accurately and each prop has a /** comment above it */
    • The file is named correctly
    • The component has a clear name that is non-ambiguous and the purpose of the component can be inferred from the name alone
    • The only data being stored in the state is data necessary for rendering and nothing else
    • If we are not using the full Onyx data that we loaded, I've added the proper selector in order to ensure the component only re-renders when the data it is using changes
    • For Class Components, any internal methods passed to components event handlers are bound to this properly so there are no scoping issues (i.e. for onClick={this.submit} the method this.submit should be bound to this in the constructor)
    • Any internal methods bound to this are necessary to be bound (i.e. avoid this.submit = this.submit.bind(this); if this.submit is never passed to a component event handler like onClick)
    • All JSX used for rendering exists in the render method
    • The component has the minimum amount of code necessary for its purpose, and it is broken down into smaller components in order to separate concerns and functions
  • If any new file was added I verified that:
    • The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory
  • If a new CSS style is added I verified that:
    • A similar style doesn't already exist
    • The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(themeColors.componentBG))
  • If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
  • If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
  • If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
  • If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
  • If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
  • If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.
  • I have checked off every checkbox in the PR author checklist, including those that don't apply to this PR.

Screenshots/Videos

Android: Native
Android: mWeb Chrome
iOS: Native
iOS: mWeb Safari
MacOS: Chrome / Safari

3. Match the columns in your spreadsheet with the Expensify data they correspond to.
4. Click **Import**.

**Note:** If you are utilizing the **Advanced Approval** feature, you can specify to whom each member should submit their expense reports and who an approver should send approved reports for the next step in the approval process. If someone is the final
Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@stephanieelliott not sure how this ended up in this spot, but wanted to complete the sentence!

@github-actions
Copy link
Copy Markdown
Contributor

HelpDot Documentation Review

Overall Assessment

This PR fixes a truncated sentence in the Expensify Classic article "Invite members and assign roles." The previous version cut off mid-sentence at "If someone is the final" -- the proposed change completes the thought and also shifts from third-person ("someone") to second-person ("you"), which is consistent with the direct, user-addressed tone expected in HelpDot articles.

Scores Summary

  • Readability: 9/10 - The completed sentence is clear and actionable. It tells the user exactly what happens when they are the final approver. The use of second-person ("If you are the final approver") is an improvement over the truncated third-person phrasing.
  • AI Readiness: 7/10 - The fix itself is sound, but no metadata or heading changes are in scope for this PR. Score reflects only the change quality, not pre-existing article issues.
  • Style Compliance: 9/10 - The change correctly bolds the UI status label Approved, matching button/label formatting conventions. The phrasing "If you are utilizing" is slightly verbose (prefer "If you use"), but that wording exists in the unchanged portion of the sentence and is not part of this diff.

Key Findings

  • The primary issue (a sentence truncated mid-thought) is fully resolved by this change.
  • The shift from "If someone is the final" to "If you are the final approver" correctly aligns with second-person voice conventions.
  • Approved is properly bolded as a UI status label per HELPSITE_NAMING_CONVENTIONS.md.
  • No governance violations are introduced by this change.

Recommendations

  • No blocking issues. This is a straightforward content fix that should be merged.
  • (Optional, out-of-scope for this PR) The broader article could benefit from a metadata review -- the existing YAML frontmatter does not include internalScope, and several headings may not fully comply with task-based heading rules. These are pre-existing concerns unrelated to this diff.

Files Reviewed

  • docs/articles/expensify-classic/workspaces/Invite-members-and-assign-roles.md -- Truncated sentence completed; no issues introduced.

@OSBotify
Copy link
Copy Markdown
Contributor

A preview of your ExpensifyHelp changes have been deployed to https://79576019.helpdot.pages.dev ⚡️

Updated articles:

@stephanieelliott
Copy link
Copy Markdown
Contributor

Good eye, thanks @brianlee-expensify!

@stephanieelliott stephanieelliott merged commit c68b65b into main May 22, 2026
26 of 27 checks passed
@stephanieelliott stephanieelliott deleted the brianlee-expensify-patch-3 branch May 22, 2026 01:18
@melvin-bot melvin-bot Bot added the Emergency label May 22, 2026
@melvin-bot
Copy link
Copy Markdown

melvin-bot Bot commented May 22, 2026

@stephanieelliott looks like this was merged without a test passing. Please add a note explaining why this was done and remove the Emergency label if this is not an emergency.

@github-actions
Copy link
Copy Markdown
Contributor

HelpDot Documentation Review

Overall Assessment

This PR makes a small, targeted fix to one Expensify Classic article: completing a truncated sentence at the end of the "Import a Group of Members" section in Invite-members-and-assign-roles.md. The original line was cut off mid-sentence ("If someone is the final"), and this change completes it with clear, actionable language ("If you are the final approver, the report becomes Approved and is ready for payment.").

Scores Summary

  • Readability: 9/10 - The completed sentence is clear and concise. Using "you" instead of the previous "someone" aligns with direct, user-facing tone. The sentence flows naturally and is easy to scan.
  • AI Readiness: 7/10 - The fix itself is well-written, but the broader article (outside this PR's scope) has pre-existing structural issues (e.g., multiple # headings that are not task-based, missing internalScope in YAML metadata). The changed line does not introduce any new AI readiness concerns.
  • Style Compliance: 9/10 - The change correctly bolds the UI element Approved and references Advanced Approval with proper formatting. Language is precise and avoids prohibited vague phrasing.

Key Findings

  • The fix resolves an incomplete sentence that would have caused confusion for users and degraded AI retrieval quality (truncated content is unparseable).
  • The shift from third-person ("someone") to second-person ("you") is a positive change that aligns with direct instructional tone.
  • Approved is correctly bolded as a UI status label, consistent with HELPSITE_NAMING_CONVENTIONS.md button/label formatting rules.
  • No new governance violations are introduced by this change.

Recommendations

  • No blocking issues. This is a straightforward content fix that improves clarity.
  • For future PRs on this file, consider addressing pre-existing issues such as non-task-based # headings (e.g., "Automatic Workspace Access with Company Email", "Create an Invitation Link") and adding internalScope to the YAML frontmatter. These are outside the scope of this PR.

Files Reviewed

  • docs/articles/expensify-classic/workspaces/Invite-members-and-assign-roles.md - Single line fix completing a truncated sentence. No issues found.

This review assessed only the proposed changes in the diff, not pre-existing content.

@OSBotify
Copy link
Copy Markdown
Contributor

🚀 Deployed to staging by https://github.com/stephanieelliott in version: 9.3.80-0 🚀

platform result
🕸 web 🕸 success ✅
🤖 android 🤖 success ✅
🍎 iOS 🍎 success ✅

Bundle Size Analysis (Sentry):

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants