[No QA] Update Invite-members-and-assign-roles.md#91319
Conversation
| 3. Match the columns in your spreadsheet with the Expensify data they correspond to. | ||
| 4. Click **Import**. | ||
|
|
||
| **Note:** If you are utilizing the **Advanced Approval** feature, you can specify to whom each member should submit their expense reports and who an approver should send approved reports for the next step in the approval process. If someone is the final |
There was a problem hiding this comment.
@stephanieelliott not sure how this ended up in this spot, but wanted to complete the sentence!
HelpDot Documentation ReviewOverall AssessmentThis PR fixes a truncated sentence in the Expensify Classic article "Invite members and assign roles." The previous version cut off mid-sentence at "If someone is the final" -- the proposed change completes the thought and also shifts from third-person ("someone") to second-person ("you"), which is consistent with the direct, user-addressed tone expected in HelpDot articles. Scores Summary
Key Findings
Recommendations
Files Reviewed
|
|
A preview of your ExpensifyHelp changes have been deployed to https://79576019.helpdot.pages.dev ⚡️ Updated articles: |
|
Good eye, thanks @brianlee-expensify! |
|
@stephanieelliott looks like this was merged without a test passing. Please add a note explaining why this was done and remove the |
HelpDot Documentation ReviewOverall AssessmentThis PR makes a small, targeted fix to one Expensify Classic article: completing a truncated sentence at the end of the "Import a Group of Members" section in Scores Summary
Key Findings
Recommendations
Files Reviewed
This review assessed only the proposed changes in the diff, not pre-existing content. |
|
🚀 Deployed to staging by https://github.com/stephanieelliott in version: 9.3.80-0 🚀
Bundle Size Analysis (Sentry): |
taken from the NewDot version: https://help.expensify.com/articles/new-expensify/reports-and-expenses/Approve-Expenses
Explanation of Change
Fixed Issues
$
PROPOSAL:
Tests
Offline tests
QA Steps
// TODO: These must be filled out, or the issue title must include "[No QA]."
PR Author Checklist
### Fixed Issuessection aboveTestssectionOffline stepssectionQA stepssectiontoggleReportand notonIconClick)myBool && <MyComponent />.src/languages/*files and using the translation methodWaiting for Copylabel for a copy review on the original GH to get the correct copy.STYLE.md) were followedAvatar, I verified the components usingAvatarare working as expected)/** comment above it */thisproperly so there are no scoping issues (i.e. foronClick={this.submit}the methodthis.submitshould be bound tothisin the constructor)thisare necessary to be bound (i.e. avoidthis.submit = this.submit.bind(this);ifthis.submitis never passed to a component event handler likeonClick)StyleUtils.getBackgroundAndBorderStyle(themeColors.componentBG))Avataris modified, I verified thatAvataris working as expected in all cases)ScrollViewcomponent to make it scrollable when more elements are added to the page.mainbranch was merged into this PR after a review, I tested again and verified the outcome was still expected according to theTeststeps.Screenshots/Videos
Android: Native
Android: mWeb Chrome
iOS: Native
iOS: mWeb Safari
MacOS: Chrome / Safari