Fix/90661#91326
Closed
ChavdaSachin wants to merge 5 commits into
Closed
Conversation
Codecov Report❌ Looks like you've decreased code coverage for some files. Please write tests to increase, or at least maintain, the existing level of code coverage. See our documentation here for how to interpret this table.
|
Contributor
Author
|
Note: for zero-amount track expense, the "Missing amount" error on the transaction preview is an existing bug and is irrelevant to any of the PRs related to the current project. |
melvin-bot
Bot
requested review from
ShridharGoel and
trjExpensify
and removed request for
a team
|
@ShridharGoel Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button] |
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
| const firstParticipant = participantsList.at(0); | ||
| if (isNewManualExpenseFlowEnabled && firstParticipant?.isSelfDM && selfDMReport?.reportID && iouType !== CONST.IOU.TYPE.SPLIT) { | ||
| for (const draftTransaction of transactions) { | ||
| const selfDMParticipants = getMoneyRequestParticipantsFromReport(selfDMReport, currentUserPersonalDetails.accountID).map((participant) => ({ |
Contributor
There was a problem hiding this comment.
❌ PERF-13 (docs)
getMoneyRequestParticipantsFromReport(selfDMReport, currentUserPersonalDetails.accountID).map(...) is called inside the for (const draftTransaction of transactions) loop but does not depend on draftTransaction. The result is identical on every iteration, creating redundant O(n) computation.
Hoist the selfDMParticipants computation above the loop:
const selfDMParticipants = getMoneyRequestParticipantsFromReport(selfDMReport, currentUserPersonalDetails.accountID).map((participant) => ({
...participant,
iouType: CONST.IOU.TYPE.TRACK,
}));
for (const draftTransaction of transactions) {
setMoneyRequestParticipants(draftTransaction.transactionID, selfDMParticipants);
setTransactionReport(draftTransaction.transactionID, {reportID: CONST.REPORT.UNREPORTED_REPORT_ID}, true);
}Reviewed at: 7759af0 | Please rate this suggestion with 👍 or 👎 to help us improve! Reactions are used to monitor reviewer efficiency.
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 7759af017f
ℹ️ About Codex in GitHub
Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".
Comment on lines
+165
to
168
| if (!isScanRequestUtil(transaction) && !isTimeRequest && !isDistanceRequest && !isPerDiemRequest && !isValidMoneyRequestAmount(iouAmount, iouType, true, isP2P, isSelfDM)) { | ||
| return {errorKey: 'common.error.invalidAmount'}; | ||
| } | ||
| if (isNewManualExpenseFlowEnabled && !transaction?.isAmountSet) { |
There was a problem hiding this comment.
When NEW_MANUAL_EXPENSE_FLOW is enabled and the amount input is still untouched (transaction.isAmountSet is false), this new guard now returns common.error.invalidAmount for INVOICE, PAY, and SPLIT because iouAmount defaults to 0. That bypasses the intended required-field path immediately below and shows the wrong validation state for an empty field. This regression is introduced by broadening the invalid-amount check at this point in the flow; the isAmountSet check should run first (or be folded into this condition) so empty amounts still surface common.error.fieldRequired in manual-expense confirmation.
Useful? React with 👍 / 👎.
trjExpensify
approved these changes
May 22, 2026
Contributor
trjExpensify
left a comment
trjExpensify
left a comment
There was a problem hiding this comment.
bug fixes for push input editing 👍
Contributor
Reviewer Checklist
Screenshots/VideosAndroid: HybridAppAndroid: mWeb ChromeiOS: HybridAppiOS: mWeb SafariMacOS: Chrome / SafariScreen.Recording.2026-05-22.at.5.45.18.PM.movScreen.Recording.2026-05-22.at.5.44.05.PM.mov |
Contributor
Author
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Explanation of Change
Fixed Issues
$ #90661
#90681
PROPOSAL:
Tests
Offline tests
QA Steps
// TODO: These must be filled out, or the issue title must include "[No QA]."
PR Author Checklist
### Fixed Issuessection aboveTestssectionOffline stepssectionQA stepssectiontoggleReportand notonIconClick)src/languages/*files and using the translation methodSTYLE.md) were followedAvatar, I verified the components usingAvatarare working as expected)StyleUtils.getBackgroundAndBorderStyle(theme.componentBG))npm run compress-svg)Avataris modified, I verified thatAvataris working as expected in all cases)Designlabel and/or tagged@Expensify/designso the design team can review the changes.ScrollViewcomponent to make it scrollable when more elements are added to the page.mainbranch was merged into this PR after a review, I tested again and verified the outcome was still expected according to theTeststeps.Screenshots/Videos
Android: Native
Android: mWeb Chrome
iOS: Native
iOS: mWeb Safari
MacOS: Chrome / Safari
Screen.Recording.2026-05-22.at.2.54.31.AM.mov