Repository navigation
avoid empty sharing settings for dataSets when project does not match… - #520
Merged
MiquelAdell merged 2 commits intoJul 27, 2026
Conversation
BundleMonNo change in files bundle size Groups updated (1)
Final result: ✅ View report in BundleMon website ➡️ |
2 tasks done
MiquelAdell
merged commit Jul 27, 2026
aede2e5
into
development-project-configurator
6 checks passed
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
📌 References
📝 Implementation
If a project is not related to any Country (org. unit level 3) dataSet will be created with no sharing settings. In this PR we're introducing a fallback for this case and set the project (categoryOption) sharing settings to the dataSet.
📹 Screenshots/Screen capture
Project without Country related
Project-Configuration-app_sharing_Settings.mp4
Project with Country related (current funcionality with no changes)
Project-Configuration-app_sharing_Settings_normal.mp4
🔥 Notes to the tester
Explanation with further details on the bug and examples to test -> https://app.clickup.com/t/4528615/869dntzyy?comment=90120227935873