Skip to content

avoid empty sharing settings for dataSets when project does not match… - #520

Merged
MiquelAdell merged 2 commits into
development-project-configuratorfrom
feature/dataset-nosharingsettings-869dntzyy
Jul 27, 2026
Merged

MiquelAdell merged 2 commits into
development-project-configuratorfrom
feature/dataset-nosharingsettings-869dntzyy

Conversation

@eperedo

@eperedo eperedo commented Jul 9, 2026

Copy link
Copy Markdown
Contributor

📌 References

📝 Implementation

If a project is not related to any Country (org. unit level 3) dataSet will be created with no sharing settings. In this PR we're introducing a fallback for this case and set the project (categoryOption) sharing settings to the dataSet.

📹 Screenshots/Screen capture

Project without Country related

Project-Configuration-app_sharing_Settings.mp4

Project with Country related (current funcionality with no changes)

Project-Configuration-app_sharing_Settings_normal.mp4

🔥 Notes to the tester

Explanation with further details on the bug and examples to test -> https://app.clickup.com/t/4528615/869dntzyy?comment=90120227935873

@eperedo
eperedo requested a review from MiquelAdell July 9, 2026 20:52
@bundlemon

bundlemon Bot commented Jul 9, 2026

Copy link
Copy Markdown

BundleMon

No change in files bundle size

Groups updated (1)
Status Path Size Limits
✅ Build Folder
./**/*
996.86KB (+577B +0.06%) +20%

Final result: ✅

View report in BundleMon website ➡️


Current branch size history | Target branch size history

@MiquelAdell
MiquelAdell merged commit aede2e5 into development-project-configurator Jul 27, 2026
6 checks passed
@MiquelAdell
MiquelAdell deleted the feature/dataset-nosharingsettings-869dntzyy branch July 27, 2026 06:43
@MiquelAdell MiquelAdell mentioned this pull request Jul 27, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants