Skip to content

Add description to user group table - #538

Merged
MiquelAdell merged 5 commits into
developmentfrom
feature/user-groups-description-attribute-869a15300
Sep 3, 2026
Merged

MiquelAdell merged 5 commits into
developmentfrom
feature/user-groups-description-attribute-869a15300

Conversation

@eperedo

@eperedo eperedo commented Aug 7, 2026

Copy link
Copy Markdown
Contributor

📌 References

📝 Implementation

  • Add new dropdown to settings to select the attribute for group description
  • Add description in Group Columns settings
  • Include description in the User Groups table

📹 Screenshots/Screen capture

User-Extended_description_attribute.mp4

🔥 Testing

Create an User Group Attribute and then select it in the Group Columns settings section

Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>

fix columns order
@eperedo
eperedo requested a review from adrianq August 7, 2026 20:41
@bundlemon

bundlemon Bot commented Aug 7, 2026 •

Copy link
Copy Markdown

BundleMon

No change in files bundle size

Groups updated (1)
Status Path Size Limits
✅ Build Folder
./**/*
1.47MB (+2.02KB +0.13%) +20%

Final result: ✅

View report in BundleMon website ➡️


Current branch size history | Target branch size history

@adrianq
adrianq requested a review from anagperal August 17, 2026 07:28

@anagperal anagperal left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks @eperedo ! Only a few comments (some non-blocking) and I found this issue: the Description column stays empty until a reload after configuring the attribute, I need to reload the page.

Screencast.from.2026-08-17.11-25-49.webm

sort: sorting.order,
filterEmptyUsers: filterEmptyUsers,
selectedUsersIds: selectedUsersIds,
searchFields: ["name", "description"],

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

searchFields is passed unconditionally, so the search matches the description even when the admin sets the Description column to disabled. Typing a word that only exists in a hidden description returns rows whose visible name doesn't match, which reads as a bug from the user's side. Maybe searchFields should be derived from the visible columns instead?

Screencast.from.2026-08-17.11-28-20.webm

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@eperedo it seems this is not fixed:

Screencast.from.2026-09-01.09-03-11.webm

Comment thread src/domain/usecases/GetGroupColumnsUseCase.ts Outdated
Comment thread src/data/repositories/UserGroupD2Repository.ts Outdated
Comment thread src/domain/usecases/GetGroupColumnsUseCase.ts Outdated
@anagperal

Copy link
Copy Markdown
Contributor

Also this check is failing https://github.com/EyeSeeTea/user-extended/actions/runs/31216941872/job/95357282823?pr=538

The failing check (dependency-track-yarn4) is unrelated to the code in this PR, it's the SCA gate comparing open alert instances against development. You need to merge development into the branch and push, the job should then report 0 introduced.

@eperedo
eperedo requested a review from anagperal September 1, 2026 00:16

@anagperal anagperal left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks @eperedo ! I still see the same behavior: as a super admin with the Description column set to disabled, searching for a word that only exists in a description still returns that group, even though the column is not shown.

@eperedo
eperedo requested a review from anagperal September 1, 2026 14:59

@anagperal anagperal left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks @eperedo !! all ok

@MiquelAdell
MiquelAdell requested review from MiquelAdell and removed request for adrianq September 3, 2026 10:28
@MiquelAdell
MiquelAdell merged commit 7978d99 into development Sep 3, 2026
12 checks passed
@MiquelAdell
MiquelAdell deleted the feature/user-groups-description-attribute-869a15300 branch September 3, 2026 10:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants