Repository navigation
fix : ci pipeline for datumTableEditor - #10
Merged
Merged
Conversation
There was a problem hiding this comment.
🟡 Changes recommended
The release workflow currently hard-codes/renames artifact filenames and injects a version without committing it, which can produce confusing or incorrect release assets and tag/source version mismatches.
Once you've addressed the issues Copilot identified, you can request another Copilot review.
Pull request overview
Adds GitHub Actions workflows to build/test the project on PRs and to create versioned GitHub Releases on pushes to main.
Changes:
- Introduces a
build.ymlworkflow to install dependencies and run pytest on PRs tomainand on non-mainbranch pushes. - Introduces a
release.ymlworkflow to compute a semantic version, run tests, build sdist/wheel, and publish a GitHub Release with attached artifacts.
File summaries
| File | Description |
|---|---|
| .github/workflows/release.yml | New release pipeline: semantic versioning, tests, build, and GitHub Release publishing. |
| .github/workflows/build.yml | New CI pipeline: checkout, install deps, and run pytest for PRs/branch pushes. |
Review details
Suppressed comments (2)
.github/workflows/release.yml:76
- The build step renames the wheel/tarball to a hard-coded
datumTableEditor-...-py3-none-any.whlname and picks the “first” artifact indist/. This can misrepresent the wheel’s real compatibility tags and can break if multiple wheels/sdists are produced (or if the project name differs), making the release assets misleading and potentially non-installable by filename expectations.
VERSION=${{ steps.release-semantic.outputs.version }}
WHL=$(ls dist/*.whl | head -n1)
TAR=$(ls dist/*.tar.gz | head -n1)
DEST_WHL=dist/datumTableEditor-${VERSION}-py3-none-any.whl
DEST_TAR=dist/datumTableEditor-${VERSION}.tar.gz
.github/workflows/release.yml:91
- After removing the artifact renaming logic, the release step should upload the actual build outputs from
dist/rather than expecting exact filenames; otherwise the workflow will fail whenever the produced filenames don’t match the hard-coded pattern.
files: |
dist/datumTableEditor-${{ steps.release-semantic.outputs.version }}-py3-none-any.whl
dist/datumTableEditor-${{ steps.release-semantic.outputs.version }}.tar.gz
- Files reviewed: 2/2 changed files
- Comments generated: 2
- Review effort level: Lite
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.