Skip to content

fix : ci pipeline for datumTableEditor - #10

Merged
Dinesh-Axle merged 2 commits into
mainfrom
DSP-1305
Sep 2, 2026
Merged

Dinesh-Axle merged 2 commits into
mainfrom
DSP-1305

Conversation

@Dinesh-Axle

Copy link
Copy Markdown
Collaborator

No description provided.

Comment thread .github/workflows/build.yml Fixed

Copilot AI left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🟡 Changes recommended

The release workflow currently hard-codes/renames artifact filenames and injects a version without committing it, which can produce confusing or incorrect release assets and tag/source version mismatches.

Once you've addressed the issues Copilot identified, you can request another Copilot review.

Pull request overview

Adds GitHub Actions workflows to build/test the project on PRs and to create versioned GitHub Releases on pushes to main.

Changes:

  • Introduces a build.yml workflow to install dependencies and run pytest on PRs to main and on non-main branch pushes.
  • Introduces a release.yml workflow to compute a semantic version, run tests, build sdist/wheel, and publish a GitHub Release with attached artifacts.
File summaries
File Description
.github/workflows/release.yml New release pipeline: semantic versioning, tests, build, and GitHub Release publishing.
.github/workflows/build.yml New CI pipeline: checkout, install deps, and run pytest for PRs/branch pushes.
Review details

Suppressed comments (2)

.github/workflows/release.yml:76

  • The build step renames the wheel/tarball to a hard-coded datumTableEditor-...-py3-none-any.whl name and picks the “first” artifact in dist/. This can misrepresent the wheel’s real compatibility tags and can break if multiple wheels/sdists are produced (or if the project name differs), making the release assets misleading and potentially non-installable by filename expectations.
          VERSION=${{ steps.release-semantic.outputs.version }}
          WHL=$(ls dist/*.whl | head -n1)
          TAR=$(ls dist/*.tar.gz | head -n1)
          DEST_WHL=dist/datumTableEditor-${VERSION}-py3-none-any.whl
          DEST_TAR=dist/datumTableEditor-${VERSION}.tar.gz

.github/workflows/release.yml:91

  • After removing the artifact renaming logic, the release step should upload the actual build outputs from dist/ rather than expecting exact filenames; otherwise the workflow will fail whenever the produced filenames don’t match the hard-coded pattern.
          files: |
            dist/datumTableEditor-${{ steps.release-semantic.outputs.version }}-py3-none-any.whl
            dist/datumTableEditor-${{ steps.release-semantic.outputs.version }}.tar.gz
  • Files reviewed: 2/2 changed files
  • Comments generated: 2
  • Review effort level: Lite

💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.

Comment thread .github/workflows/release.yml
Comment thread .github/workflows/release.yml
@Dinesh-Axle
Dinesh-Axle merged commit b3d149f into main Sep 2, 2026
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants