Skip to content

Split cost pricing tests#171

Merged
Finesssee merged 1 commit into
mainfrom
thermo-six-prs
Jul 12, 2026
Merged

Split cost pricing tests#171
Finesssee merged 1 commit into
mainfrom
thermo-six-prs

Conversation

@Finesssee

@Finesssee Finesssee commented Jul 12, 2026

Copy link
Copy Markdown
Owner

Summary

  • move cost-pricing tests out of the production module
  • reduce rust/src/core/cost_pricing.rs from 1,135 to 864 lines without changing runtime behavior
  • simplify redundant Option assertions while preserving all 21 pricing tests

Thermo-nuclear review

Reviewed the combined changes from #163, #164, #165, #168, #169, and #170. The only blocking structural regression was the cost-pricing module crossing 1,000 lines. The large Ollama, Gemini, Wayfinder, Claude reset, and models.dev additions remain cohesive provider/domain modules and did not justify behavior-risking rewrites.

The two internal cost-freshness planning documents were identified as removable, but they remain tracked because repository deletion protection rejected the required Recycle Bin operation.

Validation

  • cargo test --manifest-path rust/Cargo.toml
  • cargo clippy --manifest-path rust/Cargo.toml --all-targets -- -D warnings
  • cargo test --manifest-path apps/desktop-tauri/src-tauri/Cargo.toml
  • cargo clippy --manifest-path apps/desktop-tauri/src-tauri/Cargo.toml --all-targets -- -D warnings
  • git diff --check

Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>
@Finesssee Finesssee merged commit 7e7702b into main Jul 12, 2026
2 of 4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant