Skip to content

Fix constant status check for BoolExprNode #9039

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
asfernandes merged 1 commit into from
May 27, 2026
+7 −1
Merged

Fix constant status check for BoolExprNode #9039

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion doc/sql.extensions/README.packages.txt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -106,7 +106,7 @@ Objectives:

The following expressions are valid only if all operands are constants:
1) Arithmetic operations, unary plus/minus
2) Bool As Value
2) Bool As Value, Boolean compare operations
3) CAST, COALESCE, CONCATENATE, DECODE, EXTRACT, UPPER/LOWER, SUBSTRING
4) BIT_LENGTH, CHAR_LENGTH, CHARACTER_LENGTH, OCTET_LENGTH
5) TRIM, LTRIM, RTRIM, BTRIM
Expand Down
6 changes: 6 additions & 0 deletions src/dsql/Nodes.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -729,6 +729,7 @@ class ExprNode : public DmlNode
// SubstringSimilarNode
// TrimNode
// ValueIfNode
// BoolExprNode
//
// Special:
// SysFuncCallNode - see SysFunction::functions
Expand Down Expand Up @@ -818,6 +819,11 @@ class BoolExprNode : public ExprNode
return KIND_BOOLEAN;
}

virtual bool constant() const override
{
return isChildrenConstant();
}

BoolExprNode* dsqlPass(DsqlCompilerScratch* dsqlScratch) override
{
ExprNode::dsqlPass(dsqlScratch);
Expand Down
Loading