Skip to content

Incorrect reason used for environment default flags #341

Description

@khvn26

Currently the engine emits DEFAULT whenever the evaluation result is the environment default flag.

This should be:

  1. STATIC if there are no targeting rules configured for the feature
  2. DEFAULT if there are targeting rules configured, but the evaluation doesn't match them

i.e. if there are segment overrides for a feature, but they don't match the identity we are evaluating for, then return DEFAULT. If there are no segment overrides, return STATIC.

See Resolution Reason.

Acceptance Criteria:

  • Change implemented in this repository and tested
  • New version of engine released
  • New engine version integrated into Flagsmith/flagsmith, Flagsmith/edge-api, Flagsmith/flagsmith-python-client, Flagsmith/edge-proxy
  • Update reason logic in Flagsmith/flagsmith-go-client

Activity

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

Labels

No labels
No labels

Type

Projects

No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions