Skip to content

feat: implement atomic versioned storage contract - #34

Merged
Freyskeyd merged 2 commits into
mainfrom
freyskeyd/che-4-implement-atomic-versioned-storage-contract
Sep 11, 2026
Merged

Freyskeyd merged 2 commits into
mainfrom
freyskeyd/che-4-implement-atomic-versioned-storage-contract

Conversation

@Freyskeyd

@Freyskeyd Freyskeyd commented Sep 8, 2026

Copy link
Copy Markdown
Owner

Summary

  • Add the chekov-storage versioned storage contract and memory backend.
  • Validate read revisions and mutation compare-and-swap expectations before committing.
  • Advance per-key revisions deterministically and preserve deletion tombstones.
  • Report conflicts explicitly and prove no partial commits under stale or concurrent writers.

Validation

  • cargo test --locked
  • cargo clippy -p chekov-core -p chekov-storage --all-targets -- -D warnings
  • cargo fmt --all -- --check

Resolves CHE-4

@linear-code

linear-code Bot commented Sep 8, 2026

Copy link
Copy Markdown

CHE-4

Copilot AI left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🟡 Changes recommended

Every commit clones the complete and continually growing state map while holding the exclusive lock.

Once you've addressed the issues Copilot identified, you can request another Copilot review.

Pull request overview

Adds an atomic, version-aware storage contract and shared in-memory backend.

Changes:

  • Introduces compare-and-swap validation and explicit conflict errors.
  • Preserves tombstone revisions and prevents partial commits.
  • Tests lifecycle, stale writes, concurrency, and overflow.
File summaries
File Description
crates/chekov-storage/src/lib.rs Implements the contract, backend, and tests.
crates/chekov-storage/Cargo.toml Defines the new crate.
Cargo.lock Registers the new package.
Review details
  • Files reviewed: 2/3 changed files
  • Comments generated: 1
  • Review effort level: Balanced

💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.

Comment thread crates/chekov-storage/src/lib.rs Outdated
@Freyskeyd

Copy link
Copy Markdown
Owner Author

@codex

@chatgpt-codex-connector

Copy link
Copy Markdown

Codex Review: Didn't find any major issues. Already looking forward to the next diff.

Reviewed commit: e34f4b088a

ℹ️ About Codex in GitHub

Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".

@Freyskeyd
Freyskeyd merged commit 55d5b28 into main Sep 11, 2026
18 checks passed
@Freyskeyd
Freyskeyd deleted the freyskeyd/che-4-implement-atomic-versioned-storage-contract branch September 11, 2026 08:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants