fix: make predefined filters API generic and prevent dropping regular sort params if provided#1737
Merged
MartinCupela merged 3 commits intomasterfrom May 8, 2026
Merged
Conversation
Matches backend behavior, request sort is still relevant when predefined filter has no sort template
Contributor
|
Size Change: +62 B (+0.02%) Total Size: 381 kB 📦 View Changed
|
isekovanic
approved these changes
May 8, 2026
isekovanic
reviewed
May 8, 2026
|
🎉 This PR is included in version 9.43.2 🎉 The release is available on: Your semantic-release bot 📦🚀 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Goal
The original predefined filters implementation omitted DX, when it used
Record<string, unknown>for filters definitions in predefined filters types. We haveChannelsFiltertype that can be passed to predefined filters types to help users type the filters easier.Also the
channelsQueryRequestmethod was dropping regularsortparameter, if it detectedpredefined_filtersin the methods payload. But this is incorrect in cases, when somebody wants to use predefined filter that has not sort param internally and wants to rely on dynamically provided regularsortobject. If the server-side stored predefined filter definition contains its own sort, the regular sort param is ignored server-side.I have added
fixmecomment so thatchannelsQueryRequestreturns the whole response payload as it containspredefined_filterspayload, that is currently being discarded and cannot be used client-side to follow sorting and filtering rules client-side. This change would be breaking and so it is not implemented with this PR.