gateware.uart: Create ExternalUART#1010
gateware.uart: Create ExternalUART#1010drosseau wants to merge 1 commit intoGlasgowEmbedded:mainfrom
ExternalUART#1010Conversation
drosseau
force-pushed
the
external-uart
branch
from
b8ff239 to
51ff31e
Compare
whitequark
left a comment
whitequark
left a comment
There was a problem hiding this comment.
Thanks. I have a very large OSS backlog so it'll be a bit of time until I get around to this
|
The short version is that the UART primitive you're working with should ideally be completely discarded and rewritten in the same style as e.g. the new SPI peripherals, but I realize this falls quite short of "useful guidance" |
|
Thanks, but I read that as saying this won't be merged. I don't have any strong opinions about this pull request so that's fine by me, but I'd like #1009 to be merged as it's a feature I'm interested in using regularly. Do you have an outline of what changes you'd like to see exactly? If so I could see if it's something I could do otherwise maybe this or something similar could be merged in the interim? |
|
@drosseau I've been a little too sick the last few weeks to have time to review this (I've seen this message and your Matrix ones as well), I'll try to get back to you as soon as it becomes feasible. |
The previous `UART` implementation required being connected to physical pins, but this change allows specifying an arbitrary `UARTBus` implementation for `UART`s that make no assumptions about what they're connected to.
drosseau
force-pushed
the
external-uart
branch
from
51ff31e to
71fa2fd
Compare
3 participants
The previous
UARTimplementation required being connected to physical pins, but this change allows specifying an arbitraryUARTBusimplementation forUARTs that make no assumptions about what they're connected to.