Repository navigation
misc(release): fix VERSION env export in docker job and skip_npm manifest condition - #1195
Merged
Merged
Conversation
connorjclark
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes two issues in
.github/workflows/publish.ymluncovered during thev0.16.0release:VERSIONinbuild-and-test-docker(Prepare Docker files for target version):VERSION="${INPUT_VERSION#v}"was set as an unexported shell variable, and writing to$GITHUB_ENVonly populatesprocess.env.VERSIONin subsequent steps. Whennode -eran in the same step,process.env.VERSIONevaluated toundefined, rewriting@lhci/cli@undefinedintodocs/recipes/docker-client/Dockerfile. Also adds branch/format validation (forskip_npm: trueruns) and an explicit guard in the inline Node script.publish-docker-manifeststo run whenskip_npm: true: Addsif: ${{ !cancelled() && needs.build-and-test-docker.result == 'success' }}so GitHub Actions' default transitivesuccess()check does not skippublish-docker-manifestswhen upstreampublish-npmis skipped.