-
Notifications
You must be signed in to change notification settings - Fork 1.2k
feat(secretmanager): Adding expiretime samples #3294
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
khilan-crest
wants to merge
21
commits into
GoogleCloudPlatform:main
Choose a base branch
from
khilan-crest:cs_expiretime_samples
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from 9 commits
Commits
Show all changes
21 commits
Select commit
Hold shift + click to select a range
62f68ac
feat(secretmanager): Adding labels and annotations sample
khilan-crest 0b20481
feat(secretmanager): Adding filter and cmek samples
khilan-crest dee8bc1
feat(secretmanager): Adding secret version filter samples
khilan-crest d21d2a7
feat(secretmanager): Adding secrets expiration samples
khilan-crest 5832e34
feat(secretmanager): Update labels annotations samples
khilan-crest 7b77ac3
feat(secretmanager): Update cmek filter samples
khilan-crest e4fe6a0
Merge branch 'cs_labels_annotation_samples' of https://github.com/khi…
khilan-crest 43f47dd
Merge branch 'cs_filter_cmek_samples' of https://github.com/khilan-cr…
khilan-crest 922ff50
feat(secretmanager): Update expiration samples
khilan-crest cdd5217
feat(secretmanager): Updating fixture
khilan-crest 3933710
Merge branch 'cs_filter_cmek_samples' of https://github.com/khilan-cr…
khilan-crest 2b756f1
feat(secretmanager): Updating fixture
khilan-crest 4641d03
feat(secretmanager): Reformat code
khilan-crest cdbc3c2
Merge branch 'cs_labels_annotation_samples' of https://github.com/khi…
khilan-crest 34e7a7a
feat(secretmanager): Reformat code
khilan-crest 32295a4
Merge branch 'cs_filter_cmek_samples' of https://github.com/khilan-cr…
khilan-crest 5a4e75a
feat(secretmanager): Reformat code
khilan-crest 2f0bfb5
feat(secretmanager): Reformat code
khilan-crest 7dea915
Merge branch 'cs_labels_annotation_samples' of https://github.com/khi…
khilan-crest a24afb7
Merge branch 'cs_filter_cmek_samples' of https://github.com/khilan-cr…
khilan-crest 2c1de99
feat(secretmanager): Reformat code
khilan-crest File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
51 changes: 51 additions & 0 deletions
51
secretmanager/api/SecretManager.Samples.Tests/CreateRegionalSecretWithExpirationTests.cs
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,51 @@ | ||
| /* | ||
| * Copyright 2026 Google LLC | ||
| * | ||
| * Licensed under the Apache License, Version 2.0 (the "License"); | ||
| * you may not use this file except in compliance with the License. | ||
| * You may obtain a copy of the License at | ||
| * | ||
| * https://www.apache.org/licenses/LICENSE-2.0 | ||
| * | ||
| * Unless required by applicable law or agreed to in writing, software | ||
| * distributed under the License is distributed on an "AS IS" BASIS, | ||
| * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. | ||
| * See the License for the specific language governing permissions and | ||
| * limitations under the License. | ||
| */ | ||
|
|
||
| using Google.Cloud.SecretManager.V1; | ||
| using System; | ||
| using System.IO; | ||
| using Xunit; | ||
|
|
||
| [Collection(nameof(RegionalSecretManagerFixture))] | ||
| public class CreateRegionalSecretWithExpireTimeTests | ||
| { | ||
| private readonly RegionalSecretManagerFixture _fixture; | ||
| private readonly CreateRegionalSecretWithExpireTimeSample _sample; | ||
|
|
||
| public CreateRegionalSecretWithExpireTimeTests(RegionalSecretManagerFixture fixture) | ||
| { | ||
| _fixture = fixture; | ||
| _sample = new CreateRegionalSecretWithExpireTimeSample(); | ||
| } | ||
|
|
||
| [Fact] | ||
| public void CreatesRegionalSecretWithExpireTime() | ||
| { | ||
| // Get the SecretName from the set ProjectId & LocationId. | ||
| SecretName secretName = SecretName.FromProjectLocationSecret( | ||
| _fixture.ProjectId, _fixture.LocationId, _fixture.RandomId()); | ||
|
|
||
| // Run the code sample. | ||
| Secret result = _sample.CreateRegionalSecretWithExpireTime( | ||
| projectId: secretName.ProjectId, | ||
| secretId: secretName.SecretId, | ||
| locationId: secretName.LocationId); | ||
|
|
||
| Assert.NotEmpty(result.ExpireTime.ToString()); | ||
| // Clean the created secret. | ||
| _fixture.DeleteSecret(secretName); | ||
| } | ||
| } | ||
49 changes: 49 additions & 0 deletions
49
secretmanager/api/SecretManager.Samples.Tests/CreateSecretWithExpirationTests.cs
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,49 @@ | ||
| /* | ||
| * Copyright 2026 Google LLC | ||
| * | ||
| * Licensed under the Apache License, Version 2.0 (the "License"); | ||
| * you may not use this file except in compliance with the License. | ||
| * You may obtain a copy of the License at | ||
| * | ||
| * https://www.apache.org/licenses/LICENSE-2.0 | ||
| * | ||
| * Unless required by applicable law or agreed to in writing, software | ||
| * distributed under the License is distributed on an "AS IS" BASIS, | ||
| * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. | ||
| * See the License for the specific language governing permissions and | ||
| * limitations under the License. | ||
| */ | ||
|
|
||
| using Google.Cloud.SecretManager.V1; | ||
| using Google.Protobuf.WellKnownTypes; | ||
| using System; | ||
| using System.IO; | ||
| using Xunit; | ||
|
|
||
| [Collection(nameof(SecretManagerFixture))] | ||
| public class CreateSecretWithExpirationTests | ||
| { | ||
| private readonly SecretManagerFixture _fixture; | ||
| private readonly CreateSecretWithExpirationSample _sample; | ||
|
|
||
| public CreateSecretWithExpirationTests(SecretManagerFixture fixture) | ||
| { | ||
| _fixture = fixture; | ||
| _sample = new CreateSecretWithExpirationSample(); | ||
| } | ||
|
|
||
| [Fact] | ||
| public void CreatesSecretsWithExpiration() | ||
|
khilan-crest marked this conversation as resolved.
Outdated
|
||
| { | ||
| // Get the SecretName to create Secret. | ||
| SecretName secretName = new SecretName(_fixture.ProjectId, _fixture.RandomId()); | ||
|
|
||
| // Create the secret with expiration. | ||
| Secret result = _sample.CreateSecretWithExpiration( | ||
| projectId: secretName.ProjectId, secretId: secretName.SecretId); | ||
|
|
||
| Assert.NotEmpty(result.ExpireTime.ToString()); | ||
|
khilan-crest marked this conversation as resolved.
Outdated
|
||
| // Clean the created secret. | ||
| _fixture.DeleteSecret(secretName); | ||
| } | ||
| } | ||
59 changes: 59 additions & 0 deletions
59
secretmanager/api/SecretManager.Samples.Tests/DeleteRegionalSecretAnnotationTests.cs
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,59 @@ | ||
| /* | ||
| * Copyright 2026 Google LLC | ||
| * | ||
| * Licensed under the Apache License, Version 2.0 (the "License"); | ||
| * you may not use this file except in compliance with the License. | ||
| * You may obtain a copy of the License at | ||
| * | ||
| * https://www.apache.org/licenses/LICENSE-2.0 | ||
| * | ||
| * Unless required by applicable law or agreed to in writing, software | ||
| * distributed under the License is distributed on an "AS IS" BASIS, | ||
| * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. | ||
| * See the License for the specific language governing permissions and | ||
| * limitations under the License. | ||
| */ | ||
|
|
||
| using Google.Cloud.SecretManager.V1; | ||
| using System; | ||
| using System.IO; | ||
| using Xunit; | ||
|
|
||
| [Collection(nameof(RegionalSecretManagerFixture))] | ||
| public class DeleteRegionalSecretAnnotationTests | ||
| { | ||
| private readonly RegionalSecretManagerFixture _fixture; | ||
| private readonly DeleteRegionalSecretAnnotationSample _sample; | ||
|
|
||
| public DeleteRegionalSecretAnnotationTests(RegionalSecretManagerFixture fixture) | ||
| { | ||
| _fixture = fixture; | ||
| _sample = new DeleteRegionalSecretAnnotationSample(); | ||
| } | ||
|
|
||
| [Fact] | ||
| public void DeleteRegionalSecretAnnotation() | ||
| { | ||
| // Create a secret with annotations | ||
| Secret secret = _fixture.CreateSecret(_fixture.RandomId()); | ||
| SecretName secretName = secret.SecretName; | ||
|
|
||
| // Get a key from the existing annotations | ||
| string annotationKey = _fixture.AnnotationKey; | ||
|
|
||
| // Verify the secret has annotations | ||
| Assert.NotEmpty(secret.Annotations); | ||
| Assert.True(secret.Annotations.ContainsKey(annotationKey)); | ||
|
|
||
| // Run the sample code to delete the annotation | ||
| Secret result = _sample.DeleteRegionalSecretAnnotation( | ||
| projectId: secretName.ProjectId, | ||
| locationId: secretName.LocationId, | ||
| secretId: secretName.SecretId); | ||
|
|
||
| Assert.Empty(result.Annotations); | ||
|
|
||
| // Clean the created secret. | ||
| _fixture.DeleteSecret(secretName); | ||
| } | ||
| } |
50 changes: 50 additions & 0 deletions
50
secretmanager/api/SecretManager.Samples.Tests/DeleteRegionalSecretExpirationTests.cs
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,50 @@ | ||
| /* | ||
| * Copyright 2026 Google LLC | ||
| * | ||
| * Licensed under the Apache License, Version 2.0 (the "License"); | ||
| * you may not use this file except in compliance with the License. | ||
| * You may obtain a copy of the License at | ||
| * | ||
| * https://www.apache.org/licenses/LICENSE-2.0 | ||
| * | ||
| * Unless required by applicable law or agreed to in writing, software | ||
| * distributed under the License is distributed on an "AS IS" BASIS, | ||
| * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. | ||
| * See the License for the specific language governing permissions and | ||
| * limitations under the License. | ||
| */ | ||
|
|
||
| using Google.Cloud.SecretManager.V1; | ||
| using Google.Protobuf.WellKnownTypes; | ||
| using System; | ||
| using System.IO; | ||
| using Xunit; | ||
|
|
||
| [Collection(nameof(RegionalSecretManagerFixture))] | ||
| public class DeleteRegionalSecretExpirationTests | ||
| { | ||
| private readonly RegionalSecretManagerFixture _fixture; | ||
| private readonly DeleteRegionalSecretExpirationSample _deleteSample; | ||
|
|
||
| public DeleteRegionalSecretExpirationTests(RegionalSecretManagerFixture fixture) | ||
| { | ||
| _fixture = fixture; | ||
| _deleteSample = new DeleteRegionalSecretExpirationSample(); | ||
| } | ||
|
|
||
| [Fact] | ||
| public void DeletesRegionalSecretExpiration() | ||
| { | ||
| Secret initialSecret = _fixture.CreateSecretWithExpireTime(); | ||
|
|
||
| // Delete the expiration time | ||
| Secret result = _deleteSample.DeleteRegionalSecretExpiration( | ||
| projectId: initialSecret.SecretName.ProjectId, | ||
| secretId: initialSecret.SecretName.SecretId, | ||
| locationId: initialSecret.SecretName.LocationId); | ||
|
|
||
| Assert.Null(result.ExpireTime); | ||
| // Clean the created secret | ||
| _fixture.DeleteSecret(initialSecret.SecretName); | ||
| } | ||
| } |
54 changes: 54 additions & 0 deletions
54
secretmanager/api/SecretManager.Samples.Tests/DeleteRegionalSecretLabelTests.cs
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,54 @@ | ||
| /* | ||
| * Copyright 2026 Google LLC | ||
| * | ||
| * Licensed under the Apache License, Version 2.0 (the "License"); | ||
| * you may not use this file except in compliance with the License. | ||
| * You may obtain a copy of the License at | ||
| * | ||
| * https://www.apache.org/licenses/LICENSE-2.0 | ||
| * | ||
| * Unless required by applicable law or agreed to in writing, software | ||
| * distributed under the License is distributed on an "AS IS" BASIS, | ||
| * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. | ||
| * See the License for the specific language governing permissions and | ||
| * limitations under the License. | ||
| */ | ||
|
|
||
| using Google.Cloud.SecretManager.V1; | ||
| using System; | ||
| using System.IO; | ||
| using Xunit; | ||
|
|
||
| [Collection(nameof(RegionalSecretManagerFixture))] | ||
| public class DeleteRegionalSecretLabelTests | ||
| { | ||
| private readonly RegionalSecretManagerFixture _fixture; | ||
| private readonly DeleteRegionalSecretLabelSample _sample; | ||
|
|
||
| public DeleteRegionalSecretLabelTests(RegionalSecretManagerFixture fixture) | ||
| { | ||
| _fixture = fixture; | ||
| _sample = new DeleteRegionalSecretLabelSample(); | ||
| } | ||
|
|
||
| [Fact] | ||
| public void DeleteRegionalSecretLabel() | ||
| { | ||
| Secret secret = _fixture.CreateSecret(_fixture.RandomId()); | ||
| SecretName secretName = secret.SecretName; | ||
|
|
||
| // Verify the secret has labels | ||
| Assert.NotEmpty(secret.Labels); | ||
|
|
||
| // Run the sample code to delete all labels | ||
| Secret result = _sample.DeleteRegionalSecretLabel( | ||
|
|
||
| projectId: secretName.ProjectId, | ||
| locationId: secretName.LocationId, | ||
| secretId: secretName.SecretId); | ||
|
|
||
| Assert.Empty(result.Labels); | ||
| // Clean the created secret. | ||
| _fixture.DeleteSecret(secretName); | ||
| } | ||
| } |
50 changes: 50 additions & 0 deletions
50
secretmanager/api/SecretManager.Samples.Tests/DeleteSecretAnnotationTests.cs
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,50 @@ | ||
| /* | ||
| * Copyright 2026 Google LLC | ||
| * | ||
| * Licensed under the Apache License, Version 2.0 (the "License"); | ||
| * you may not use this file except in compliance with the License. | ||
| * You may obtain a copy of the License at | ||
| * | ||
| * https://www.apache.org/licenses/LICENSE-2.0 | ||
| * | ||
| * Unless required by applicable law or agreed to in writing, software | ||
| * distributed under the License is distributed on an "AS IS" BASIS, | ||
| * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. | ||
| * See the License for the specific language governing permissions and | ||
| * limitations under the License. | ||
| */ | ||
|
|
||
| using Google.Cloud.SecretManager.V1; | ||
| using System; | ||
| using System.IO; | ||
| using Xunit; | ||
|
|
||
| [Collection(nameof(SecretManagerFixture))] | ||
| public class DeleteSecretAnnotationTests | ||
| { | ||
| private readonly SecretManagerFixture _fixture; | ||
| private readonly DeleteSecretAnnotationSample _sample; | ||
|
|
||
| public DeleteSecretAnnotationTests(SecretManagerFixture fixture) | ||
| { | ||
| _fixture = fixture; | ||
| _sample = new DeleteSecretAnnotationSample(); | ||
| } | ||
|
|
||
| [Fact] | ||
| public void DeleteSecretAnnotation() | ||
| { | ||
| // Create the secret. | ||
| Secret secret = _fixture.CreateSecret(_fixture.RandomId()); | ||
|
|
||
| // Get the secretName from the created secret. | ||
| SecretName secretName = secret.SecretName; | ||
|
|
||
| // Call the code sample function to delete the label | ||
|
khilan-crest marked this conversation as resolved.
Outdated
|
||
| Secret result = _sample.DeleteSecretAnnotation( | ||
| projectId: secretName.ProjectId, secretId: secretName.SecretId); | ||
|
|
||
| // Assert that the label is deleted. | ||
| Assert.Empty(result.Annotations); | ||
| } | ||
| } | ||
53 changes: 53 additions & 0 deletions
53
secretmanager/api/SecretManager.Samples.Tests/DeleteSecretExpirationTests.cs
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,53 @@ | ||
| /* | ||
| * Copyright 2026 Google LLC | ||
| * | ||
| * Licensed under the Apache License, Version 2.0 (the "License"); | ||
| * you may not use this file except in compliance with the License. | ||
| * You may obtain a copy of the License at | ||
| * | ||
| * https://www.apache.org/licenses/LICENSE-2.0 | ||
| * | ||
| * Unless required by applicable law or agreed to in writing, software | ||
| * distributed under the License is distributed on an "AS IS" BASIS, | ||
| * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. | ||
| * See the License for the specific language governing permissions and | ||
| * limitations under the License. | ||
| */ | ||
|
|
||
| using Google.Cloud.SecretManager.V1; | ||
| using Google.Protobuf.WellKnownTypes; | ||
| using System; | ||
| using System.IO; | ||
| using Xunit; | ||
|
|
||
| [Collection(nameof(SecretManagerFixture))] | ||
| public class DeleteSecretExpirationTests | ||
| { | ||
| private readonly SecretManagerFixture _fixture; | ||
| private readonly DeleteSecretExpirationSample _deleteSample; | ||
|
|
||
| public DeleteSecretExpirationTests(SecretManagerFixture fixture) | ||
| { | ||
| _fixture = fixture; | ||
| _deleteSample = new DeleteSecretExpirationSample(); | ||
| } | ||
|
|
||
| [Fact] | ||
| public void DeletesSecretExpiration() | ||
| { | ||
|
|
||
| // Get the SecretName to create Secret. | ||
| SecretName secretName = new SecretName(_fixture.ProjectId, _fixture.RandomId()); | ||
|
|
||
| // First, create a secret with an expiration time | ||
| Secret secret = _fixture.CreateSecretWithExpiration(); | ||
|
|
||
| // Delete the expiration time | ||
| Secret result = _deleteSample.DeleteSecretExpiration( | ||
| projectId: secret.SecretName.ProjectId, secretId: secret.SecretName.SecretId); | ||
|
|
||
| Assert.Null(result.ExpireTime); | ||
| // Clean up the created secret | ||
| _fixture.DeleteSecret(secretName); | ||
|
khilan-crest marked this conversation as resolved.
Outdated
|
||
| } | ||
| } | ||
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.