add support for universal `deletion_policy` by NickElliot · Pull Request #17380 · GoogleCloudPlatform/magic-modules

NickElliot · 2026-05-01T16:13:38Z

Universal deletion_policy is a string field added to the top-level schema of all compatible resources. Rather than using a “default” attribute, it is configured as an optional+computed field.

To display a default from provider configuration or resource settings, it is dependent on a new customize diff function that operates in a similar way to the customize diff functions for displaying Project/Region/Zone at plan-time. A GetRawConfig() check is performed on the resource to verify if it has been set explicitly by the user, and in absence of that checks for if a user has configured a value within their provider configuration, and if that is absent it goes with the resource default. There is no fall back state behind this, as all resources have a default supplied to this customize diff function as a string argument.

At the end of the read function some code has been included for setting virtual fields to their default (following standard design for TPG resources), with the minor addition of checking the provider configuration before using the resource default.

If a resource has been excluded from supporting resourceUpdate() previously, it has been updated to have an Update function that immediately returns resourceRead(). Existing update functions have had a PreUpdate check introduced at the beginning, which quickly checks over the resource to verify if any updates have been planned other than those to deletion-policy, and if only deletion_policy is being updated, will short circuit the function into returning resource*Read().

Lastly, a PreDelete check has been added that performs the logic for either “PREVENT” or “ABANDON”. If necessary due to some implementations using different terms (e.g. “DEFAULT” often being used in place of “DELETE” previously), existing implementations have been updated to be compatible with these standard terms.

Supporting the above implementation, three attributes have been added to resource.go for usage in resource yaml files:
deletion_policy_exclude, if set to true this will avoid generating the deletion_policy related fields to the end resource. This is set to true for resources that are incompatible with a deletion policy (such as those with no delete function), or those that had existing, incompatible implementations.
deletion_policy_custom_docs, if set to true this will avoid generating the standard docs description for the universal deletion policy field. This is set to true for resources which support custom options in their deletion_policy such as “force”, and need a bespoke description for their usage. These resources have maintained their virtual field deletion_policy fields, but updated to have an “exclude: true” attribute that will avoid them being generated into the downstream resource (as these resources will use the fully standard field/associated code in most areas, with their custom code generally being contained within a pre_delete constant.
deletion_policy_default, a string attribute that can be set to the desired default value for a resource. This will default to “DELETE” if unset.

One attribute deletion_policy has been added to provider.go and config.go, and is used to enable configuring the provider-level default.

Release Note Template for Downstream PRs (will be copied)

See Write release notes for guidance.

provider: support for a `deletion_policy` field has been added to almost all resources in the provider. Details on its usage can be found within individual resource documentation if supported.

…oogleCloudPlatform#16075)

…udPlatform#16324)

…Platform#16325)

…leCloudPlatform#16382)

…se (GoogleCloudPlatform#16383)

…rm#16462)

…gleCloudPlatform#16478)

)

modular-magician · 2026-05-01T16:24:03Z

Hi there, I'm the Modular magician. I've detected the following information about your changes for commit 4faf853:

Diff report

Your PR generated the following diffs in downstream repositories:

Repository	Diff Link	Changes
`google` provider	View Diff	2515 files changed, 39731 insertions(+), 511 deletions(-)
`google-beta` provider	View Diff	2654 files changed, 42666 insertions(+), 576 deletions(-)
`terraform-google-conversion`	View Diff	11 files changed, 163 insertions(+), 30 deletions(-)

Breaking Change(s) Detected

The following breaking change(s) were detected within your pull request.

Field deletion_policy default value changed from "" to <nil> on google_billing_subaccount - reference
Field deletion_policy default value changed from ABANDON to <nil> on google_firestore_database - reference
Field deletion_policy default value changed from DEFAULT to <nil> on google_alloydb_cluster - reference
Field deletion_policy default value changed from DEFAULT to <nil> on google_chronicle_data_table - reference
Field deletion_policy default value changed from DEFAULT to <nil> on google_chronicle_rule - reference
Field deletion_policy default value changed from DEFAULT to <nil> on google_firebase_data_connect_service - reference
Field deletion_policy default value changed from DEFAULT to <nil> on google_looker_instance - reference
Field deletion_policy default value changed from DEFAULT to <nil> on google_netapp_volume - reference
Field deletion_policy default value changed from DELETE to <nil> on google_container_attached_cluster - reference
Field deletion_policy default value changed from DELETE to <nil> on google_dataform_repository - reference
Field deletion_policy default value changed from DELETE to <nil> on google_firebase_android_app - reference
Field deletion_policy default value changed from DELETE to <nil> on google_firebase_apple_app - reference
Field deletion_policy default value changed from DELETE to <nil> on google_firebase_web_app - reference
Field deletion_policy default value changed from DELETE to <nil> on google_firestore_index - reference
Field deletion_policy default value changed from DELETE to <nil> on google_secret_manager_regional_secret_version - reference
Field deletion_policy default value changed from DELETE to <nil> on google_secret_manager_secret_version - reference
Field deletion_policy default value changed from DELETE to <nil> on google_sql_database - reference
Field deletion_policy default value changed from FORCE to <nil> on google_datastream_private_connection - reference
Field deletion_policy default value changed from PREVENT to <nil> on google_project - reference
Field deletion_policy default value changed from PREVENT to <nil> on google_secure_source_manager_instance - reference
Field deletion_policy default value changed from PREVENT to <nil> on google_secure_source_manager_repository - reference

If you believe this detection to be incorrect please raise the concern with your reviewer.
If you intend to make this change you will need to wait for a major release window.
An override-breaking-change label can be added to allow merging.

Missing doc report (experimental)

The following resources have fields missing in documents.

google_composer_environment
- Expected Document Path: /website/docs/r/composer_environment.html.markdown
- Fields: [deletion_policy]
google_compute_instance_from_machine_image
- Expected Document Path: /website/docs/r/compute_instance_from_machine_image.html.markdown
- Fields: [deletion_policy]
google_compute_instance_from_template
- Expected Document Path: /website/docs/r/compute_instance_from_template.html.markdown
- Fields: [deletion_policy]
google_endpoints_service
- Expected Document Path: /website/docs/r/endpoints_service.html.markdown
- Fields: [deletion_policy]

The following data sources are missing documents:

google_backup_dr_backup_plan, expect file /website/docs/d/backup_dr_backup_plan.html.markdown to exist.
google_compute_region_ssl_policy, expect file /website/docs/d/compute_region_ssl_policy.html.markdown to exist.
google_vmwareengine_datastore, expect file /website/docs/d/vmwareengine_datastore.html.markdown to exist.

Test report

Analytics

Total Tests	Passed	Skipped	Affected
6385	5715	655	15

Affected Service Packages

All service packages are affected

Learn how VCR tests work

Step 1: Replaying Mode

Action taken

Found 15 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit. Click here to see the affected tests

TestAccApigeeOrganization_apigeeOrganizationCloudBasicDisableVpcPeeringTestExample
TestAccApigeeOrganization_apigeeOrganizationCloudFullDisableVpcPeeringTestExample
TestAccBeyondcorpAppConnection_beyondcorpAppConnectionBasicExample
TestAccCloudRunService_cloudRunServiceGpuExample
TestAccComputeRouterPeer_AddMd5AuthenticationKey
TestAccComputeSubnetwork_secondaryIpRanges_sendEmpty
TestAccContainerCluster_updateVersion
TestAccContainerCluster_withAutopilotResourceManagerTags
TestAccContainerNodePool_withHostMaintenancePolicy
TestAccDataformRepository_dataformRepositoryWithCloudsourceRepoAndSshExample
TestAccDataprocMetastoreService_dataprocMetastoreServicePrivateServiceConnectExample
TestAccDiscoveryEngineDataStore_discoveryengineDatastoreKmsKeyNameExample
TestAccManagedKafkaConnector_managedkafkaConnectorBasicExample
TestAccProjectIamMemberRemove_memberInMultipleBindings
TestAccPubsubSubscription_pubsubSubscriptionTagsExample

View the build log

Step 2: Recording Mode

Test Name	Recording Mode	Replaying Rerun
`TestAccApigeeOrganization_apigeeOrganizationCloudBasicDisableVpcPeeringTestExample`	🔴 Failed [Error message] [Debug log]	-
`TestAccApigeeOrganization_apigeeOrganizationCloudFullDisableVpcPeeringTestExample`	🔴 Failed [Error message] [Debug log]	-
`TestAccBeyondcorpAppConnection_beyondcorpAppConnectionBasicExample`	🔴 Failed [Error message] [Debug log]	-
`TestAccCloudRunService_cloudRunServiceGpuExample`	🔴 Failed [Error message] [Debug log]	-
`TestAccComputeRouterPeer_AddMd5AuthenticationKey`	🟢 Passed [Debug log]	🟢 Passed
`TestAccComputeSubnetwork_secondaryIpRanges_sendEmpty`	🔴 Failed [Error message] [Debug log]	-
`TestAccContainerCluster_updateVersion`	🔴 Failed [Error message] [Debug log]	-
`TestAccContainerCluster_withAutopilotResourceManagerTags`	🔴 Failed [Error message] [Debug log]	-
`TestAccContainerNodePool_withHostMaintenancePolicy`	🔴 Failed [Error message] [Debug log]	-
`TestAccDataformRepository_dataformRepositoryWithCloudsourceRepoAndSshExample`	🔴 Failed [Error message] [Debug log]	-
`TestAccDataprocMetastoreService_dataprocMetastoreServicePrivateServiceConnectExample`	🔴 Failed [Error message] [Debug log]	-
`TestAccDiscoveryEngineDataStore_discoveryengineDatastoreKmsKeyNameExample`	🔴 Failed [Error message] [Debug log]	-
`TestAccManagedKafkaConnector_managedkafkaConnectorBasicExample`	🔴 Failed [Error message] [Debug log]	-
`TestAccProjectIamMemberRemove_memberInMultipleBindings`	🟢 Passed [Debug log]	🟢 Passed
`TestAccPubsubSubscription_pubsubSubscriptionTagsExample`	🔴 Failed [Error message] [Debug log]	-

Caution

Issues requiring attention before PR completion

🔴 Initial Recording Failed: Some tests failed during the recording step. See the table above for details.

Please address these issues to complete your PR. If you believe these detections are incorrect or unrelated to your change, please raise the concern with your reviewer.

View the build log or the debug logs folder for detailed results.

@NickElliot VCR tests complete for 4faf853!

NickElliot · 2026-05-04T17:20:44Z

all standard test failures unrelated to deletion policy

bringing in @zli82016 as a second reviewer for the TGC tests issues/for extra eyes given the size of the PR

c2thorn

Can you help me out by re-explaining some important points in a singular place here, or in the main PR comment? It's been a long process of reviewing individual PRs within the feature branch, and each of those were focused pieces. We should take a step back and double check we've covered everything here at the end, and it's hard to remember all the pieces to track and decisions we've made a long the way.

If this PR were to break things and someone that wasn't you or I were to try to understand the changes here, it'd be too big to decipher easily. A summary of the high-level changes in this PR would be really helpful.

My main questions right now:

are the findings from the breaking change detector expected? From what I understood we were preserving the defaults via deletion_policy_default. If we are ignoring the breaking change detector, how do we know we haven't accidentally swapped a default?
Is there a follow up PR expected for the provider-scoped UDP documentation?
Are we planning on having contribution documentation for UDP?
a few todo/to-do's in this final merge, are those tracked somewhere, or should they be addressed now?

NickElliot · 2026-05-05T15:22:04Z

will write something up!

zli82016 · 2026-05-05T17:13:31Z

The failed tgc integration tests are unrelated and have been fixed in the main branch.

NickElliot · 2026-05-06T21:10:10Z

Can you help me out by re-explaining some important points in a singular place here

I updated the top comment with full details.

The breaking change flags are expected here. The design of the field has swapped from an input only field to one that is O+C, with the default being configured as a parameter supplied to the tpgresource.DefaultProviderDeletionPolicy and as the fallback option in event of a resource/provider config level setting not being detected. I’ll perform another personal review passover of the flagged breaking changes to verify that they all have their new "defaults" matching the old
Here: Update reference docs to detail universal deletion policy #17445
^
Solved the todos I had note of

modular-magician · 2026-05-06T21:19:26Z

Hi there, I'm the Modular magician. I've detected the following information about your changes for commit eb0746d:

Diff report

Your PR generated the following diffs in downstream repositories:

Repository	Diff Link	Changes
`google` provider	View Diff	2523 files changed, 39825 insertions(+), 506 deletions(-)
`google-beta` provider	View Diff	2662 files changed, 42756 insertions(+), 571 deletions(-)
`terraform-google-conversion`	View Diff	11 files changed, 163 insertions(+), 30 deletions(-)

Breaking Change(s) Detected

The following breaking change(s) were detected within your pull request.

Field deletion_policy default value changed from "" to <nil> on google_billing_subaccount - reference
Field deletion_policy default value changed from ABANDON to <nil> on google_firestore_database - reference
Field deletion_policy default value changed from DEFAULT to <nil> on google_alloydb_cluster - reference
Field deletion_policy default value changed from DEFAULT to <nil> on google_chronicle_data_table - reference
Field deletion_policy default value changed from DEFAULT to <nil> on google_chronicle_rule - reference
Field deletion_policy default value changed from DEFAULT to <nil> on google_firebase_data_connect_service - reference
Field deletion_policy default value changed from DEFAULT to <nil> on google_looker_instance - reference
Field deletion_policy default value changed from DEFAULT to <nil> on google_netapp_volume - reference
Field deletion_policy default value changed from DELETE to <nil> on google_container_attached_cluster - reference
Field deletion_policy default value changed from DELETE to <nil> on google_dataform_repository - reference
Field deletion_policy default value changed from DELETE to <nil> on google_firebase_android_app - reference
Field deletion_policy default value changed from DELETE to <nil> on google_firebase_apple_app - reference
Field deletion_policy default value changed from DELETE to <nil> on google_firebase_web_app - reference
Field deletion_policy default value changed from DELETE to <nil> on google_firestore_index - reference
Field deletion_policy default value changed from DELETE to <nil> on google_secret_manager_regional_secret_version - reference
Field deletion_policy default value changed from DELETE to <nil> on google_secret_manager_secret_version - reference
Field deletion_policy default value changed from DELETE to <nil> on google_sql_database - reference
Field deletion_policy default value changed from FORCE to <nil> on google_datastream_private_connection - reference
Field deletion_policy default value changed from PREVENT to <nil> on google_project - reference
Field deletion_policy default value changed from PREVENT to <nil> on google_secure_source_manager_instance - reference
Field deletion_policy default value changed from PREVENT to <nil> on google_secure_source_manager_repository - reference

If you believe this detection to be incorrect please raise the concern with your reviewer.
If you intend to make this change you will need to wait for a major release window.
An override-breaking-change label can be added to allow merging.

Missing doc report (experimental)

The following resources have fields missing in documents.

google_composer_environment
- Expected Document Path: /website/docs/r/composer_environment.html.markdown
- Fields: [deletion_policy]
google_compute_instance_from_machine_image
- Expected Document Path: /website/docs/r/compute_instance_from_machine_image.html.markdown
- Fields: [deletion_policy]
google_compute_instance_from_template
- Expected Document Path: /website/docs/r/compute_instance_from_template.html.markdown
- Fields: [deletion_policy]
google_endpoints_service
- Expected Document Path: /website/docs/r/endpoints_service.html.markdown
- Fields: [deletion_policy]

The following data sources are missing documents:

google_backup_dr_backup_plan, expect file /website/docs/d/backup_dr_backup_plan.html.markdown to exist.
google_compute_region_ssl_policy, expect file /website/docs/d/compute_region_ssl_policy.html.markdown to exist.
google_vmwareengine_datastore, expect file /website/docs/d/vmwareengine_datastore.html.markdown to exist.

Test report

Analytics

Total Tests	Passed	Skipped	Affected
6400	5726	655	19

Affected Service Packages

All service packages are affected

Learn how VCR tests work

Step 1: Replaying Mode

Action taken

Found 19 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit. Click here to see the affected tests

TestAccApigeeOrganization_apigeeOrganizationCloudBasicDisableVpcPeeringTestExample
TestAccApigeeOrganization_apigeeOrganizationCloudFullDisableVpcPeeringTestExample
TestAccBeyondcorpAppConnection_beyondcorpAppConnectionBasicExample
TestAccCloudRunService_cloudRunServiceGpuExample
TestAccComputeInstanceFromTemplate_DiskForceAttach
TestAccComputeSecurityPolicyRule_securityPolicyRuleWithBodyExcludeExample
TestAccComputeSubnetwork_secondaryIpRanges_sendEmpty
TestAccContainerCluster_updateVersion
TestAccContainerNodePool_withHostMaintenancePolicy
TestAccDataSourceGoogleCloudRunService_basic
TestAccDataSourceGoogleCloudRunService_optionalProject
TestAccDataformConfig_update
TestAccDataformRepository_dataformRepositoryWithCloudsourceRepoAndSshExample
TestAccDataprocMetastoreService_dataprocMetastoreServicePrivateServiceConnectExample
TestAccDiscoveryEngineDataStore_discoveryengineDatastoreKmsKeyNameExample
TestAccManagedKafkaConnector_managedkafkaConnectorBasicExample
TestAccNetworkServicesLbRouteExtension_crossRegionInternalPluginExtension
TestAccNetworkServicesLbTrafficExtension_crossRegionInternalPluginExtension
TestAccPubsubSubscription_pubsubSubscriptionTagsExample

View the build log

Step 2: Recording Mode

Recording Mode	Replaying Rerun	Test Name
✅ Log	✅	TestAccNetworkServicesLbRouteExtension_crossRegionInternalPluginExtension
✅ Log	✅	TestAccNetworkServicesLbTrafficExtension_crossRegionInternalPluginExtension
✅ Log	❌ Error · Log	TestAccDataformConfig_update
❌ Error · Log	-	TestAccApigeeOrganization_apigeeOrganizationCloudBasicDisableVpcPeeringTestExample
❌ Error · Log	-	TestAccApigeeOrganization_apigeeOrganizationCloudFullDisableVpcPeeringTestExample
❌ Error · Log	-	TestAccBeyondcorpAppConnection_beyondcorpAppConnectionBasicExample
❌ Error · Log	-	TestAccCloudRunService_cloudRunServiceGpuExample
❌ Error · Log	-	TestAccComputeInstanceFromTemplate_DiskForceAttach
❌ Error · Log	-	TestAccComputeSecurityPolicyRule_securityPolicyRuleWithBodyExcludeExample
❌ Error · Log	-	TestAccComputeSubnetwork_secondaryIpRanges_sendEmpty
❌ Error · Log	-	TestAccContainerCluster_updateVersion
❌ Error · Log	-	TestAccContainerNodePool_withHostMaintenancePolicy
❌ Error · Log	-	TestAccDataSourceGoogleCloudRunService_basic
❌ Error · Log	-	TestAccDataSourceGoogleCloudRunService_optionalProject
❌ Error · Log	-	TestAccDataformRepository_dataformRepositoryWithCloudsourceRepoAndSshExample
❌ Error · Log	-	TestAccDataprocMetastoreService_dataprocMetastoreServicePrivateServiceConnectExample
❌ Error · Log	-	TestAccDiscoveryEngineDataStore_discoveryengineDatastoreKmsKeyNameExample
❌ Error · Log	-	TestAccManagedKafkaConnector_managedkafkaConnectorBasicExample
❌ Error · Log	-	TestAccPubsubSubscription_pubsubSubscriptionTagsExample

Caution

Issues requiring attention before PR completion

🔴 Initial Recording Failed: Some tests failed during the recording step. See the table above for details.

🔴 Replaying Rerun Failed: Some tests failed due to non-determinism when VCR replayed the response. See the table above for details.

Please address these issues to complete your PR. If you believe these detections are incorrect or unrelated to your change, please raise the concern with your reviewer.

View the build log or the debug logs folder for detailed results.

@NickElliot, @zli82016 VCR tests complete for eb0746d!

modular-magician · 2026-05-06T21:27:13Z

Hi there, I'm the Modular magician. I've detected the following information about your changes for commit d7c9d31:

Diff report

Your PR generated the following diffs in downstream repositories:

Repository	Diff Link	Changes
`google` provider	View Diff	2523 files changed, 39825 insertions(+), 506 deletions(-)
`google-beta` provider	View Diff	2662 files changed, 42756 insertions(+), 571 deletions(-)
`terraform-google-conversion`	View Diff	11 files changed, 163 insertions(+), 30 deletions(-)

Breaking Change(s) Detected

The following breaking change(s) were detected within your pull request.

Field deletion_policy default value changed from "" to <nil> on google_billing_subaccount - reference
Field deletion_policy default value changed from ABANDON to <nil> on google_firestore_database - reference
Field deletion_policy default value changed from DEFAULT to <nil> on google_alloydb_cluster - reference
Field deletion_policy default value changed from DEFAULT to <nil> on google_chronicle_data_table - reference
Field deletion_policy default value changed from DEFAULT to <nil> on google_chronicle_rule - reference
Field deletion_policy default value changed from DEFAULT to <nil> on google_firebase_data_connect_service - reference
Field deletion_policy default value changed from DEFAULT to <nil> on google_looker_instance - reference
Field deletion_policy default value changed from DEFAULT to <nil> on google_netapp_volume - reference
Field deletion_policy default value changed from DELETE to <nil> on google_container_attached_cluster - reference
Field deletion_policy default value changed from DELETE to <nil> on google_dataform_repository - reference
Field deletion_policy default value changed from DELETE to <nil> on google_firebase_android_app - reference
Field deletion_policy default value changed from DELETE to <nil> on google_firebase_apple_app - reference
Field deletion_policy default value changed from DELETE to <nil> on google_firebase_web_app - reference
Field deletion_policy default value changed from DELETE to <nil> on google_firestore_index - reference
Field deletion_policy default value changed from DELETE to <nil> on google_secret_manager_regional_secret_version - reference
Field deletion_policy default value changed from DELETE to <nil> on google_secret_manager_secret_version - reference
Field deletion_policy default value changed from DELETE to <nil> on google_sql_database - reference
Field deletion_policy default value changed from FORCE to <nil> on google_datastream_private_connection - reference
Field deletion_policy default value changed from PREVENT to <nil> on google_project - reference
Field deletion_policy default value changed from PREVENT to <nil> on google_secure_source_manager_instance - reference
Field deletion_policy default value changed from PREVENT to <nil> on google_secure_source_manager_repository - reference

If you believe this detection to be incorrect please raise the concern with your reviewer.
If you intend to make this change you will need to wait for a major release window.
An override-breaking-change label can be added to allow merging.

Missing doc report (experimental)

The following resources have fields missing in documents.

google_composer_environment
- Expected Document Path: /website/docs/r/composer_environment.html.markdown
- Fields: [deletion_policy]
google_compute_instance_from_machine_image
- Expected Document Path: /website/docs/r/compute_instance_from_machine_image.html.markdown
- Fields: [deletion_policy]
google_compute_instance_from_template
- Expected Document Path: /website/docs/r/compute_instance_from_template.html.markdown
- Fields: [deletion_policy]
google_endpoints_service
- Expected Document Path: /website/docs/r/endpoints_service.html.markdown
- Fields: [deletion_policy]

The following data sources are missing documents:

google_backup_dr_backup_plan, expect file /website/docs/d/backup_dr_backup_plan.html.markdown to exist.
google_compute_region_ssl_policy, expect file /website/docs/d/compute_region_ssl_policy.html.markdown to exist.
google_vmwareengine_datastore, expect file /website/docs/d/vmwareengine_datastore.html.markdown to exist.

Test report

Analytics

Total Tests	Passed	Skipped	Affected
6400	5724	655	21

Affected Service Packages

All service packages are affected

Learn how VCR tests work

Step 1: Replaying Mode

Action taken

Found 21 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit. Click here to see the affected tests

TestAccApigeeOrganization_apigeeOrganizationCloudBasicDisableVpcPeeringTestExample
TestAccApigeeOrganization_apigeeOrganizationCloudFullDisableVpcPeeringTestExample
TestAccBeyondcorpAppConnection_beyondcorpAppConnectionBasicExample
TestAccCloudRunService_cloudRunServiceGpuExample
TestAccComputeInstanceFromTemplate_DiskForceAttach
TestAccComputeSecurityPolicyRule_securityPolicyRuleWithBodyExcludeExample
TestAccComputeSubnetwork_secondaryIpRanges_sendEmpty
TestAccContainerCluster_updateVersion
TestAccContainerNodePool_withHostMaintenancePolicy
TestAccDataSourceGoogleCloudRunService_basic
TestAccDataSourceGoogleCloudRunService_optionalProject
TestAccDataformConfig_update
TestAccDataformRepository_dataformRepositoryWithCloudsourceRepoAndSshExample
TestAccDataprocMetastoreService_dataprocMetastoreServicePrivateServiceConnectExample
TestAccDiscoveryEngineDataStore_discoveryengineDatastoreKmsKeyNameExample
TestAccManagedKafkaConnector_managedkafkaConnectorBasicExample
TestAccNetworkServicesLbRouteExtension_crossRegionInternalPluginExtension
TestAccNetworkServicesLbTrafficExtension_crossRegionInternalPluginExtension
TestAccProjectIamMemberRemove_memberInMultipleBindings
TestAccProjectIamPolicy_invalidMembers
TestAccPubsubSubscription_pubsubSubscriptionTagsExample

View the build log

Step 2: Recording Mode

Recording Mode	Replaying Rerun	Test Name
✅ Log	✅	TestAccNetworkServicesLbRouteExtension_crossRegionInternalPluginExtension
✅ Log	✅	TestAccNetworkServicesLbTrafficExtension_crossRegionInternalPluginExtension
✅ Log	✅	TestAccProjectIamPolicy_invalidMembers
✅ Log	❌ Error · Log	TestAccDataformConfig_update
✅ Log	❌ Error · Log	TestAccProjectIamMemberRemove_memberInMultipleBindings
❌ Error · Log	-	TestAccApigeeOrganization_apigeeOrganizationCloudBasicDisableVpcPeeringTestExample
❌ Error · Log	-	TestAccApigeeOrganization_apigeeOrganizationCloudFullDisableVpcPeeringTestExample
❌ Error · Log	-	TestAccBeyondcorpAppConnection_beyondcorpAppConnectionBasicExample
❌ Error · Log	-	TestAccCloudRunService_cloudRunServiceGpuExample
❌ Error · Log	-	TestAccComputeInstanceFromTemplate_DiskForceAttach
❌ Error · Log	-	TestAccComputeSecurityPolicyRule_securityPolicyRuleWithBodyExcludeExample
❌ Error · Log	-	TestAccComputeSubnetwork_secondaryIpRanges_sendEmpty
❌ Error · Log	-	TestAccContainerCluster_updateVersion
❌ Error · Log	-	TestAccContainerNodePool_withHostMaintenancePolicy
❌ Error · Log	-	TestAccDataSourceGoogleCloudRunService_basic
❌ Error · Log	-	TestAccDataSourceGoogleCloudRunService_optionalProject
❌ Error · Log	-	TestAccDataformRepository_dataformRepositoryWithCloudsourceRepoAndSshExample
❌ Error · Log	-	TestAccDataprocMetastoreService_dataprocMetastoreServicePrivateServiceConnectExample
❌ Error · Log	-	TestAccDiscoveryEngineDataStore_discoveryengineDatastoreKmsKeyNameExample
❌ Error · Log	-	TestAccManagedKafkaConnector_managedkafkaConnectorBasicExample
❌ Error · Log	-	TestAccPubsubSubscription_pubsubSubscriptionTagsExample

Caution

Issues requiring attention before PR completion

🔴 Initial Recording Failed: Some tests failed during the recording step. See the table above for details.

🔴 Replaying Rerun Failed: Some tests failed due to non-determinism when VCR replayed the response. See the table above for details.

Please address these issues to complete your PR. If you believe these detections are incorrect or unrelated to your change, please raise the concern with your reviewer.

View the build log or the debug logs folder for detailed results.

@NickElliot, @zli82016 VCR tests complete for d7c9d31!

c2thorn

I believe this is good to go, the contributor docs can go any time after.

Verified the defaults match their previous values, so I believe we are good there.

Thank you for the write up and explanations.

zli82016

LGTM except that the unit test failed.

modular-magician · 2026-05-08T18:29:52Z

Hi there, I'm the Modular magician. I've detected the following information about your changes for commit 8a5493d:

Diff report

Your PR generated the following diffs in downstream repositories:

Repository	Diff Link	Changes
`google` provider	View Diff	2528 files changed, 39927 insertions(+), 506 deletions(-)
`google-beta` provider	View Diff	2665 files changed, 42810 insertions(+), 571 deletions(-)
`terraform-google-conversion`	View Diff	11 files changed, 163 insertions(+), 30 deletions(-)

Breaking Change(s) Detected

The following breaking change(s) were detected within your pull request.

Field deletion_policy default value changed from "" to <nil> on google_billing_subaccount - reference
Field deletion_policy default value changed from ABANDON to <nil> on google_firestore_database - reference
Field deletion_policy default value changed from DEFAULT to <nil> on google_alloydb_cluster - reference
Field deletion_policy default value changed from DEFAULT to <nil> on google_chronicle_data_table - reference
Field deletion_policy default value changed from DEFAULT to <nil> on google_chronicle_rule - reference
Field deletion_policy default value changed from DEFAULT to <nil> on google_firebase_data_connect_service - reference
Field deletion_policy default value changed from DEFAULT to <nil> on google_looker_instance - reference
Field deletion_policy default value changed from DEFAULT to <nil> on google_netapp_volume - reference
Field deletion_policy default value changed from DELETE to <nil> on google_container_attached_cluster - reference
Field deletion_policy default value changed from DELETE to <nil> on google_dataform_repository - reference
Field deletion_policy default value changed from DELETE to <nil> on google_firebase_android_app - reference
Field deletion_policy default value changed from DELETE to <nil> on google_firebase_apple_app - reference
Field deletion_policy default value changed from DELETE to <nil> on google_firebase_web_app - reference
Field deletion_policy default value changed from DELETE to <nil> on google_firestore_index - reference
Field deletion_policy default value changed from DELETE to <nil> on google_secret_manager_regional_secret_version - reference
Field deletion_policy default value changed from DELETE to <nil> on google_secret_manager_secret_version - reference
Field deletion_policy default value changed from DELETE to <nil> on google_sql_database - reference
Field deletion_policy default value changed from FORCE to <nil> on google_datastream_private_connection - reference
Field deletion_policy default value changed from PREVENT to <nil> on google_project - reference
Field deletion_policy default value changed from PREVENT to <nil> on google_secure_source_manager_instance - reference
Field deletion_policy default value changed from PREVENT to <nil> on google_secure_source_manager_repository - reference

If you believe this detection to be incorrect please raise the concern with your reviewer.
If you intend to make this change you will need to wait for a major release window.
An override-breaking-change label can be added to allow merging.

Missing doc report (experimental)

The following resources have fields missing in documents.

google_composer_environment
- Expected Document Path: /website/docs/r/composer_environment.html.markdown
- Fields: [deletion_policy]
google_compute_instance_from_machine_image
- Expected Document Path: /website/docs/r/compute_instance_from_machine_image.html.markdown
- Fields: [deletion_policy]
google_compute_instance_from_template
- Expected Document Path: /website/docs/r/compute_instance_from_template.html.markdown
- Fields: [deletion_policy]
google_endpoints_service
- Expected Document Path: /website/docs/r/endpoints_service.html.markdown
- Fields: [deletion_policy]

The following data sources are missing documents:

google_backup_dr_backup_plan, expect file /website/docs/d/backup_dr_backup_plan.html.markdown to exist.
google_compute_region_ssl_policy, expect file /website/docs/d/compute_region_ssl_policy.html.markdown to exist.
google_vmwareengine_datastore, expect file /website/docs/d/vmwareengine_datastore.html.markdown to exist.

Test report

Analytics

Total Tests	Passed	Skipped	Affected
6415	5742	657	16

Affected Service Packages

All service packages are affected

Learn how VCR tests work

Step 1: Replaying Mode

Action taken

Found 16 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit. Click here to see the affected tests

TestAccApigeeOrganization_apigeeOrganizationCloudBasicDisableVpcPeeringTestExample
TestAccApigeeOrganization_apigeeOrganizationCloudFullDisableVpcPeeringTestExample
TestAccBeyondcorpAppConnection_beyondcorpAppConnectionBasicExample
TestAccCloudRunService_cloudRunServiceGpuExample
TestAccComputeInstanceFromTemplate_DiskForceAttach
TestAccComputeSecurityPolicyRule_securityPolicyRuleWithBodyExcludeExample
TestAccComputeSubnetwork_secondaryIpRanges_sendEmpty
TestAccContainerCluster_updateVersion
TestAccContainerNodePool_withHostMaintenancePolicy
TestAccDataformRepository_dataformRepositoryWithCloudsourceRepoAndSshExample
TestAccDataprocMetastoreService_dataprocMetastoreServicePrivateServiceConnectExample
TestAccDiscoveryEngineDataStore_discoveryengineDatastoreKmsKeyNameExample
TestAccEphemeralServiceAccountKey_create
TestAccEphemeralServiceAccountKey_upload
TestAccManagedKafkaConnector_managedkafkaConnectorBasicExample
TestAccPubsubSubscription_pubsubSubscriptionTagsExample

View the build log

Step 2: Recording Mode

Recording Mode	Replaying Rerun	Test Name
✅ Log	❌ Error · Log	TestAccEphemeralServiceAccountKey_create
❌ Error · Log	-	TestAccApigeeOrganization_apigeeOrganizationCloudBasicDisableVpcPeeringTestExample
❌ Error · Log	-	TestAccApigeeOrganization_apigeeOrganizationCloudFullDisableVpcPeeringTestExample
❌ Error · Log	-	TestAccBeyondcorpAppConnection_beyondcorpAppConnectionBasicExample
❌ Error · Log	-	TestAccCloudRunService_cloudRunServiceGpuExample
❌ Error · Log	-	TestAccComputeInstanceFromTemplate_DiskForceAttach
❌ Error · Log	-	TestAccComputeSecurityPolicyRule_securityPolicyRuleWithBodyExcludeExample
❌ Error · Log	-	TestAccComputeSubnetwork_secondaryIpRanges_sendEmpty
❌ Error · Log	-	TestAccContainerCluster_updateVersion
❌ Error · Log	-	TestAccContainerNodePool_withHostMaintenancePolicy
❌ Error · Log	-	TestAccDataformRepository_dataformRepositoryWithCloudsourceRepoAndSshExample
❌ Error · Log	-	TestAccDataprocMetastoreService_dataprocMetastoreServicePrivateServiceConnectExample
❌ Error · Log	-	TestAccDiscoveryEngineDataStore_discoveryengineDatastoreKmsKeyNameExample
❌ Error · Log	-	TestAccEphemeralServiceAccountKey_upload
❌ Error · Log	-	TestAccManagedKafkaConnector_managedkafkaConnectorBasicExample
❌ Error · Log	-	TestAccPubsubSubscription_pubsubSubscriptionTagsExample

Caution

Issues requiring attention before PR completion

🔴 Initial Recording Failed: Some tests failed during the recording step. See the table above for details.

🔴 Replaying Rerun Failed: Some tests failed due to non-determinism when VCR replayed the response. See the table above for details.

Please address these issues to complete your PR. If you believe these detections are incorrect or unrelated to your change, please raise the concern with your reviewer.

View the build log or the debug logs folder for detailed results.

@NickElliot VCR tests complete for 8a5493d!

modular-magician · 2026-05-08T18:32:21Z

Hi there, I'm the Modular magician. I've detected the following information about your changes for commit ee0994e:

Diff report

Your PR generated the following diffs in downstream repositories:

Repository	Diff Link	Changes
`google` provider	View Diff	2528 files changed, 39927 insertions(+), 506 deletions(-)
`google-beta` provider	View Diff	2665 files changed, 42810 insertions(+), 571 deletions(-)
`terraform-google-conversion`	View Diff	11 files changed, 163 insertions(+), 30 deletions(-)

Breaking Change(s) Detected

The following breaking change(s) were detected within your pull request.

Field deletion_policy default value changed from "" to <nil> on google_billing_subaccount - reference
Field deletion_policy default value changed from ABANDON to <nil> on google_firestore_database - reference
Field deletion_policy default value changed from DEFAULT to <nil> on google_alloydb_cluster - reference
Field deletion_policy default value changed from DEFAULT to <nil> on google_chronicle_data_table - reference
Field deletion_policy default value changed from DEFAULT to <nil> on google_chronicle_rule - reference
Field deletion_policy default value changed from DEFAULT to <nil> on google_firebase_data_connect_service - reference
Field deletion_policy default value changed from DEFAULT to <nil> on google_looker_instance - reference
Field deletion_policy default value changed from DEFAULT to <nil> on google_netapp_volume - reference
Field deletion_policy default value changed from DELETE to <nil> on google_container_attached_cluster - reference
Field deletion_policy default value changed from DELETE to <nil> on google_dataform_repository - reference
Field deletion_policy default value changed from DELETE to <nil> on google_firebase_android_app - reference
Field deletion_policy default value changed from DELETE to <nil> on google_firebase_apple_app - reference
Field deletion_policy default value changed from DELETE to <nil> on google_firebase_web_app - reference
Field deletion_policy default value changed from DELETE to <nil> on google_firestore_index - reference
Field deletion_policy default value changed from DELETE to <nil> on google_secret_manager_regional_secret_version - reference
Field deletion_policy default value changed from DELETE to <nil> on google_secret_manager_secret_version - reference
Field deletion_policy default value changed from DELETE to <nil> on google_sql_database - reference
Field deletion_policy default value changed from FORCE to <nil> on google_datastream_private_connection - reference
Field deletion_policy default value changed from PREVENT to <nil> on google_project - reference
Field deletion_policy default value changed from PREVENT to <nil> on google_secure_source_manager_instance - reference
Field deletion_policy default value changed from PREVENT to <nil> on google_secure_source_manager_repository - reference

If you believe this detection to be incorrect please raise the concern with your reviewer.
If you intend to make this change you will need to wait for a major release window.
An override-breaking-change label can be added to allow merging.

Missing doc report (experimental)

The following resources have fields missing in documents.

google_composer_environment
- Expected Document Path: /website/docs/r/composer_environment.html.markdown
- Fields: [deletion_policy]
google_compute_instance_from_machine_image
- Expected Document Path: /website/docs/r/compute_instance_from_machine_image.html.markdown
- Fields: [deletion_policy]
google_compute_instance_from_template
- Expected Document Path: /website/docs/r/compute_instance_from_template.html.markdown
- Fields: [deletion_policy]
google_endpoints_service
- Expected Document Path: /website/docs/r/endpoints_service.html.markdown
- Fields: [deletion_policy]

The following data sources are missing documents:

google_backup_dr_backup_plan, expect file /website/docs/d/backup_dr_backup_plan.html.markdown to exist.
google_compute_region_ssl_policy, expect file /website/docs/d/compute_region_ssl_policy.html.markdown to exist.
google_vmwareengine_datastore, expect file /website/docs/d/vmwareengine_datastore.html.markdown to exist.

Test report

Analytics

Total Tests	Passed	Skipped	Affected
6415	5741	657	17

Affected Service Packages

All service packages are affected

Learn how VCR tests work

Step 1: Replaying Mode

Action taken

Found 17 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit. Click here to see the affected tests

TestAccApigeeOrganization_apigeeOrganizationCloudBasicDisableVpcPeeringTestExample
TestAccApigeeOrganization_apigeeOrganizationCloudFullDisableVpcPeeringTestExample
TestAccBeyondcorpAppConnection_beyondcorpAppConnectionBasicExample
TestAccCloudRunService_cloudRunServiceGpuExample
TestAccComputeInstanceFromTemplate_DiskForceAttach
TestAccComputeSecurityPolicyRule_securityPolicyRuleWithBodyExcludeExample
TestAccComputeSubnetwork_secondaryIpRanges_sendEmpty
TestAccContainerCluster_updateVersion
TestAccContainerNodePool_withHostMaintenancePolicy
TestAccDataformRepository_dataformRepositoryWithCloudsourceRepoAndSshExample
TestAccDataprocMetastoreService_dataprocMetastoreServicePrivateServiceConnectExample
TestAccDiscoveryEngineDataStore_discoveryengineDatastoreKmsKeyNameExample
TestAccEphemeralServiceAccountKey_create
TestAccEphemeralServiceAccountKey_upload
TestAccManagedKafkaConnector_managedkafkaConnectorBasicExample
TestAccProjectIamMemberRemove_memberInMultipleBindings
TestAccPubsubSubscription_pubsubSubscriptionTagsExample

View the build log

Step 2: Recording Mode

Recording Mode	Replaying Rerun	Test Name
✅ Log	❌ Error · Log	TestAccEphemeralServiceAccountKey_create
✅ Log	❌ Error · Log	TestAccProjectIamMemberRemove_memberInMultipleBindings
❌ Error · Log	-	TestAccApigeeOrganization_apigeeOrganizationCloudBasicDisableVpcPeeringTestExample
❌ Error · Log	-	TestAccApigeeOrganization_apigeeOrganizationCloudFullDisableVpcPeeringTestExample
❌ Error · Log	-	TestAccBeyondcorpAppConnection_beyondcorpAppConnectionBasicExample
❌ Error · Log	-	TestAccCloudRunService_cloudRunServiceGpuExample
❌ Error · Log	-	TestAccComputeInstanceFromTemplate_DiskForceAttach
❌ Error · Log	-	TestAccComputeSecurityPolicyRule_securityPolicyRuleWithBodyExcludeExample
❌ Error · Log	-	TestAccComputeSubnetwork_secondaryIpRanges_sendEmpty
❌ Error · Log	-	TestAccContainerCluster_updateVersion
❌ Error · Log	-	TestAccContainerNodePool_withHostMaintenancePolicy
❌ Error · Log	-	TestAccDataformRepository_dataformRepositoryWithCloudsourceRepoAndSshExample
❌ Error · Log	-	TestAccDataprocMetastoreService_dataprocMetastoreServicePrivateServiceConnectExample
❌ Error · Log	-	TestAccDiscoveryEngineDataStore_discoveryengineDatastoreKmsKeyNameExample
❌ Error · Log	-	TestAccEphemeralServiceAccountKey_upload
❌ Error · Log	-	TestAccManagedKafkaConnector_managedkafkaConnectorBasicExample
❌ Error · Log	-	TestAccPubsubSubscription_pubsubSubscriptionTagsExample

Caution

Issues requiring attention before PR completion

🔴 Initial Recording Failed: Some tests failed during the recording step. See the table above for details.

🔴 Replaying Rerun Failed: Some tests failed due to non-determinism when VCR replayed the response. See the table above for details.

Please address these issues to complete your PR. If you believe these detections are incorrect or unrelated to your change, please raise the concern with your reviewer.

View the build log or the debug logs folder for detailed results.

@NickElliot VCR tests complete for ee0994e!

modular-magician · 2026-05-08T21:10:58Z

Hi there, I'm the Modular magician. I've detected the following information about your changes for commit 365c06f:

Diff report

Your PR generated the following diffs in downstream repositories:

Repository	Diff Link	Changes
`google` provider	View Diff	2528 files changed, 39927 insertions(+), 506 deletions(-)
`google-beta` provider	View Diff	2665 files changed, 42810 insertions(+), 571 deletions(-)
`terraform-google-conversion`	View Diff	11 files changed, 163 insertions(+), 30 deletions(-)

Breaking Change(s) Detected

The following breaking change(s) were detected within your pull request.

Field deletion_policy default value changed from "" to <nil> on google_billing_subaccount - reference
Field deletion_policy default value changed from ABANDON to <nil> on google_firestore_database - reference
Field deletion_policy default value changed from DEFAULT to <nil> on google_alloydb_cluster - reference
Field deletion_policy default value changed from DEFAULT to <nil> on google_chronicle_data_table - reference
Field deletion_policy default value changed from DEFAULT to <nil> on google_chronicle_rule - reference
Field deletion_policy default value changed from DEFAULT to <nil> on google_firebase_data_connect_service - reference
Field deletion_policy default value changed from DEFAULT to <nil> on google_looker_instance - reference
Field deletion_policy default value changed from DEFAULT to <nil> on google_netapp_volume - reference
Field deletion_policy default value changed from DELETE to <nil> on google_container_attached_cluster - reference
Field deletion_policy default value changed from DELETE to <nil> on google_dataform_repository - reference
Field deletion_policy default value changed from DELETE to <nil> on google_firebase_android_app - reference
Field deletion_policy default value changed from DELETE to <nil> on google_firebase_apple_app - reference
Field deletion_policy default value changed from DELETE to <nil> on google_firebase_web_app - reference
Field deletion_policy default value changed from DELETE to <nil> on google_firestore_index - reference
Field deletion_policy default value changed from DELETE to <nil> on google_secret_manager_regional_secret_version - reference
Field deletion_policy default value changed from DELETE to <nil> on google_secret_manager_secret_version - reference
Field deletion_policy default value changed from DELETE to <nil> on google_sql_database - reference
Field deletion_policy default value changed from FORCE to <nil> on google_datastream_private_connection - reference
Field deletion_policy default value changed from PREVENT to <nil> on google_project - reference
Field deletion_policy default value changed from PREVENT to <nil> on google_secure_source_manager_instance - reference
Field deletion_policy default value changed from PREVENT to <nil> on google_secure_source_manager_repository - reference

If you believe this detection to be incorrect please raise the concern with your reviewer.
If you intend to make this change you will need to wait for a major release window.
An override-breaking-change label can be added to allow merging.

Missing doc report (experimental)

The following resources have fields missing in documents.

google_composer_environment
- Expected Document Path: /website/docs/r/composer_environment.html.markdown
- Fields: [deletion_policy]
google_compute_instance_from_machine_image
- Expected Document Path: /website/docs/r/compute_instance_from_machine_image.html.markdown
- Fields: [deletion_policy]
google_compute_instance_from_template
- Expected Document Path: /website/docs/r/compute_instance_from_template.html.markdown
- Fields: [deletion_policy]
google_endpoints_service
- Expected Document Path: /website/docs/r/endpoints_service.html.markdown
- Fields: [deletion_policy]

The following data sources are missing documents:

google_backup_dr_backup_plan, expect file /website/docs/d/backup_dr_backup_plan.html.markdown to exist.
google_compute_region_ssl_policy, expect file /website/docs/d/compute_region_ssl_policy.html.markdown to exist.
google_vmwareengine_datastore, expect file /website/docs/d/vmwareengine_datastore.html.markdown to exist.

NickElliot added 30 commits February 4, 2026 14:35

adds deletion_policy field generation to templates (feature branch) (G…

592fb27

…oogleCloudPlatform#16075)

deletion policy generation accessapproval-artifactregistry (GoogleClo…

59e2f9f

…udPlatform#16324)

deletion policy generation backupdr-blockchainnodeengine (GoogleCloud…

0134df4

…Platform#16325)

deletion policy generation certificatemanager-containerattached (Goog…

7f1b014

…leCloudPlatform#16382)

deletion policy generation databasemigrationservice-documentaiwarehou…

618ffb2

…se (GoogleCloudPlatform#16383)

deletion policy generation edgecontainer-firestore (GoogleCloudPlatfo…

1e01019

…rm#16462)

add logic to short circuit updates in deletion policy generation (Goo…

e3e4515

…gleCloudPlatform#16478)

deletion policy generation iam2-kms (GoogleCloudPlatform#16529)

e58cd37

deletion policy generation gemini - healthcare (GoogleCloudPlatform#1…

b1b0797

…6511)

add deletion_policy_exclude to firestore index

c6022ed

Sync feature branch universal deletion policy (GoogleCloudPlatform#16610

d01762f

)

logging-monitoring

bf6e246

deletion policy generation logging-monitoring (GoogleCloudPlatform#16626

e4c90b7

)

deletion policy generation parallelstore-runtimeconfig (GoogleCloudPl…

cee5fca

…atform#16628)

deletion policy generation saasservicemgmt-storagetransfer (GoogleClo…

30b3b9f

…udPlatform#16633)

deletion policy generation tags-workstations (GoogleCloudPlatform#16634)

4a8f391

deletion policy generation netapp-oslogin (GoogleCloudPlatform#16627)

161981e

add deletion_policy_exclude to chronicle data table

072535b

sync universal deletion feature branch march 17 (GoogleCloudPlatform#…

84cc95e

…16745)

apigee_app

52fdedb

apigee_sharedflow

7020449

apigee_sharedflow_deployment

4cc8c9c

apigee_flowhook

9e49005

apigee_keystores_aliases_pkcs12

f9187b3

big*

cc9148d

cloud functions function

1260a7b

composer environment

6f9b689

composer workloads secret

f2eadcf

compute part 1

44928ce

gofmt/add to data source schema manually

5738618

NickElliot added 5 commits April 30, 2026 11:28

storage bucket object

87842d5

build/fmt

149e12a

bigtable schema

2f8f8ca

last missing resources for universal deletion policy (GoogleCloudPlat…

f0d1232

…form#17360)

merge conflicts

4faf853

modular-magician added the service/terraform label May 1, 2026

NickElliot marked this pull request as ready for review May 4, 2026 17:19

NickElliot requested review from c2thorn and zli82016 May 4, 2026 17:20

c2thorn reviewed May 4, 2026

View reviewed changes

NickElliot added 3 commits May 6, 2026 14:05

remove product opt-in

fb5f7fd

remove //udp markers

965ce77

merge conflict

eb0746d

gofmt

d7c9d31

c2thorn approved these changes May 7, 2026

View reviewed changes

zli82016 requested changes May 8, 2026

View reviewed changes

NickElliot added 3 commits May 8, 2026 11:14

fix metadata unit test

6b54354

Merge branch 'main' into universaldeletionpolicyfinal

8a5493d

issues

ee0994e

Merge branch 'main' into universaldeletionpolicyfinal

365c06f

Conversation

NickElliot commented May 1, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

modular-magician commented May 1, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Diff report

Breaking Change(s) Detected

Missing doc report (experimental)

Test report

Analytics

Action taken

Uh oh!

NickElliot commented May 4, 2026

Uh oh!

c2thorn left a comment • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

NickElliot commented May 5, 2026

Uh oh!

zli82016 commented May 5, 2026

Uh oh!

NickElliot commented May 6, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

modular-magician commented May 6, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Diff report

Breaking Change(s) Detected

Missing doc report (experimental)

Test report

Analytics

Action taken

Uh oh!

modular-magician commented May 6, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Diff report

Breaking Change(s) Detected

Missing doc report (experimental)

Test report

Analytics

Action taken

Uh oh!

c2thorn left a comment

Choose a reason for hiding this comment

Uh oh!

zli82016 left a comment

Choose a reason for hiding this comment

Uh oh!

modular-magician commented May 8, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Diff report

Breaking Change(s) Detected

Missing doc report (experimental)

Test report

Analytics

Action taken

Uh oh!

modular-magician commented May 8, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Diff report

Breaking Change(s) Detected

Missing doc report (experimental)

Test report

Analytics

Action taken

Uh oh!

modular-magician commented May 8, 2026

Diff report

Breaking Change(s) Detected

Missing doc report (experimental)

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

NickElliot commented May 1, 2026 •

edited

Loading

modular-magician commented May 1, 2026 •

edited

Loading

c2thorn left a comment •

edited

Loading

NickElliot commented May 6, 2026 •

edited

Loading

modular-magician commented May 6, 2026 •

edited

Loading

modular-magician commented May 6, 2026 •

edited

Loading

modular-magician commented May 8, 2026 •

edited

Loading

modular-magician commented May 8, 2026 •

edited

Loading