Add verification polling to service account updates#17447
Add verification polling to service account updates#17447chasevedder wants to merge 1 commit intoGoogleCloudPlatform:mainfrom
Conversation
|
Googlers: For automatic test runs see go/terraform-auto-test-runs. @slevenick, a repository maintainer, has been assigned to review your changes. If you have not received review feedback within 2 business days, please leave a comment on this PR asking them to take a look. You can help make sure that review is quick by doing a self-review and by running impacted tests locally. |
|
Hi there, I'm the Modular magician. I've detected the following information about your changes for commit bea16f9: Diff reportYour PR generated the following diffs in downstream repositories:
Test reportAnalytics
Affected Service Packages
Step 1: Replaying Mode Action takenFound 1 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit. Click here to see the affected tests
View the build log Step 2: Recording Mode
🟢 All tests passed! View the build log or the debug logs folder for detailed results. @chasevedder, @slevenick VCR tests complete for bea16f9! |
Recently there has been some flakiness is service account tests involving updates. These test failures are the result of updates not being propagated by the time validation is done. There is already a 5 second sleep, but in order to make the results more consistent this fix applies polling to check for field updates before considering the update a success. This is similar to the fix in #14547 for creates. Unlike creates however, this does not result in inconsistent state for the terraform resource, so it largely only affects tests.