Skip to content

Migrated resource compute region instance template test to use transp…#17449

Draft
jcromanu wants to merge 1 commit intoGoogleCloudPlatform:mainfrom
jcromanu:resource_compute_region_instance_template_test
Draft

Migrated resource compute region instance template test to use transp…#17449
jcromanu wants to merge 1 commit intoGoogleCloudPlatform:mainfrom
jcromanu:resource_compute_region_instance_template_test

Conversation

@jcromanu
Copy link
Copy Markdown
Contributor

@jcromanu jcromanu commented May 7, 2026

…ort_tpg

Release Note Template for Downstream PRs (will be copied)

See Write release notes for guidance.

compute: migrated `google_compute_region_instance_template_test` resource  to use direct HTTP rather than a client library

@github-actions github-actions Bot requested a review from hao-nan-li May 7, 2026 02:05
@github-actions
Copy link
Copy Markdown

github-actions Bot commented May 7, 2026

Googlers: For automatic test runs see go/terraform-auto-test-runs.

@hao-nan-li, a repository maintainer, has been assigned to review your changes. If you have not received review feedback within 2 business days, please leave a comment on this PR asking them to take a look.

You can help make sure that review is quick by doing a self-review and by running impacted tests locally.

@modular-magician
Copy link
Copy Markdown
Collaborator

modular-magician commented May 7, 2026

Hi there, I'm the Modular magician. I've detected the following information about your changes for commit e201165:

Diff report

Your PR generated the following diffs in downstream repositories:

Repository Diff Link Changes
google provider View Diff 1 file changed, 327 insertions(+), 187 deletions(-)
google-beta provider View Diff 1 file changed, 362 insertions(+), 213 deletions(-)

Test report

Analytics

Total Tests Passed Skipped Affected
1433 1337 91 5
Affected Service Packages
  • compute

Learn how VCR tests work


Step 1: Replaying Mode

Action taken

Found 5 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit. Click here to see the affected tests
  • TestAccComputeInstanceFromTemplate_DiskForceAttach
  • TestAccComputeRegionInstanceTemplate_localSsdRecoveryTimeout
  • TestAccComputeRegionInstanceTemplate_maxRunDuration_onInstanceStopAction
  • TestAccComputeRegionInstanceTemplate_spot_maxRunDuration
  • TestAccComputeSecurityPolicyRule_securityPolicyRuleWithBodyExcludeExample

View the build log


Step 2: Recording Mode

Recording Mode Replaying Rerun Test Name
❌ Error · Log - TestAccComputeInstanceFromTemplate_DiskForceAttach
❌ Error · Log - TestAccComputeRegionInstanceTemplate_localSsdRecoveryTimeout
❌ Error · Log - TestAccComputeRegionInstanceTemplate_maxRunDuration_onInstanceStopAction
❌ Error · Log - TestAccComputeRegionInstanceTemplate_spot_maxRunDuration
❌ Error · Log - TestAccComputeSecurityPolicyRule_securityPolicyRuleWithBodyExcludeExample

Caution

Issues requiring attention before PR completion

🔴 Initial Recording Failed: Some tests failed during the recording step. See the table above for details.

Please address these issues to complete your PR. If you believe these detections are incorrect or unrelated to your change, please raise the concern with your reviewer.

View the build log or the debug logs folder for detailed results.

@jcromanu, @hao-nan-li VCR tests complete for e201165!

@jcromanu jcromanu marked this pull request as draft May 8, 2026 18:55
@jcromanu jcromanu force-pushed the resource_compute_region_instance_template_test branch from e201165 to b1a3cce Compare May 8, 2026 20:03
@modular-magician
Copy link
Copy Markdown
Collaborator

modular-magician commented May 8, 2026

Hi there, I'm the Modular magician. I've detected the following information about your changes for commit b1a3cce:

Diff report

Your PR generated the following diffs in downstream repositories:

Repository Diff Link Changes
google provider View Diff 1 file changed, 327 insertions(+), 187 deletions(-)
google-beta provider View Diff 1 file changed, 362 insertions(+), 213 deletions(-)

Test report

Analytics

Total Tests Passed Skipped Affected
1445 1347 93 5
Affected Service Packages
  • compute

Learn how VCR tests work


Step 1: Replaying Mode

Action taken

Found 5 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit. Click here to see the affected tests
  • TestAccComputeInstanceFromTemplate_DiskForceAttach
  • TestAccComputeRegionInstanceTemplate_localSsdRecoveryTimeout
  • TestAccComputeRegionInstanceTemplate_maxRunDuration_onInstanceStopAction
  • TestAccComputeRegionInstanceTemplate_spot_maxRunDuration
  • TestAccComputeSecurityPolicyRule_securityPolicyRuleWithBodyExcludeExample

View the build log


Step 2: Recording Mode

Recording Mode Replaying Rerun Test Name
❌ Error · Log - TestAccComputeInstanceFromTemplate_DiskForceAttach
❌ Error · Log - TestAccComputeRegionInstanceTemplate_localSsdRecoveryTimeout
❌ Error · Log - TestAccComputeRegionInstanceTemplate_maxRunDuration_onInstanceStopAction
❌ Error · Log - TestAccComputeRegionInstanceTemplate_spot_maxRunDuration
❌ Error · Log - TestAccComputeSecurityPolicyRule_securityPolicyRuleWithBodyExcludeExample

Caution

Issues requiring attention before PR completion

🔴 Initial Recording Failed: Some tests failed during the recording step. See the table above for details.

Please address these issues to complete your PR. If you believe these detections are incorrect or unrelated to your change, please raise the concern with your reviewer.

View the build log or the debug logs folder for detailed results.

@jcromanu, @hao-nan-li VCR tests complete for b1a3cce!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants