Partner CCI Terraform GA

[abhijeetkjha-google]

networkconnectivity: `google_network_connectivity_transport` resource promoted to GA

[github-actions]

Googlers: For automatic test runs see go/terraform-auto-test-runs.

@NickElliot, a repository maintainer, has been assigned to review your changes. If you have not received review feedback within 2 business days, please leave a comment on this PR asking them to take a look.

You can help make sure that review is quick by doing a self-review and by running impacted tests locally.

[modular-magician]

Hi there, I'm the Modular magician. I've detected the following information about your changes for commit 3253e0b:

Diff report

Your PR generated the following diffs in downstream repositories:

Repository	Diff Link	Changes
google provider	View Diff	6 files changed, 1513 insertions(+), 11 deletions(-)
google-beta provider	View Diff	3 files changed, 8 insertions(+), 33 deletions(-)
Open in Cloud Shell	View Diff	4 files changed, 118 insertions(+)

Test report

Important

Manual Verification Required (GA-only additions)

The following tests are GA-only additions and cannot be run by VCR in Beta mode. Please verify them manually:

🔴 TestAccNetworkConnectivityTransport_networkConnectivityTransportBasicExample
🔴 TestAccNetworkConnectivityTransport_networkConnectivityTransportBasicExample_Full

Analytics

Total Tests	Passed	Skipped	Affected
39	36	1	2

Affected Service Packages

• networkconnectivity

Learn how VCR tests work

---

Step 1: Replaying Mode

Action taken

Found 2 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit. Click here to see the affected tests

• TestAccNetworkConnectivityTransport_networkConnectivityTransportBasicExample
• TestAccNetworkConnectivityTransport_networkConnectivityTransportBasicExample_Full

View the build log

---

Step 2: Recording Mode

Recording Mode	Replaying Rerun	Test Name
❌ Error · Log	-	TestAccNetworkConnectivityTransport_networkConnectivityTransportBasicExample
❌ Error · Log	-	TestAccNetworkConnectivityTransport_networkConnectivityTransportBasicExample_Full

Caution

Issues requiring attention before PR completion

🔴 Manual Verification Required: New tests were added that are skipped in presubmit tests. See the "Manual Verification Required" section at the top for details.

🔴 Initial Recording Failed: Some tests failed during the recording step. See the table above for details.

Please address these issues to complete your PR. If you believe these detections are incorrect or unrelated to your change, please raise the concern with your reviewer.

View the build log or the debug logs folder for detailed results.

@abhijeetkjha-google, @NickElliot VCR tests complete for 3253e0b!

[modular-magician]

Hi there, I'm the Modular magician. I've detected the following information about your changes for commit d476c0b:

Diff report

Your PR generated the following diffs in downstream repositories:

Repository	Diff Link	Changes
google provider	View Diff	6 files changed, 1514 insertions(+), 12 deletions(-)
google-beta provider	View Diff	3 files changed, 9 insertions(+), 34 deletions(-)
Open in Cloud Shell	View Diff	4 files changed, 118 insertions(+)

Test report

Important

Manual Verification Required (GA-only additions)

The following tests are GA-only additions and cannot be run by VCR in Beta mode. Please verify them manually:

🔴 TestAccNetworkConnectivityTransport_networkConnectivityTransportBasicExample
🔴 TestAccNetworkConnectivityTransport_networkConnectivityTransportBasicExample_Full

Analytics

Total Tests	Passed	Skipped	Affected
39	36	1	2

Affected Service Packages

• networkconnectivity

Learn how VCR tests work

---

Step 1: Replaying Mode

Action taken

Found 2 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit. Click here to see the affected tests

• TestAccNetworkConnectivityTransport_networkConnectivityTransportBasicExample
• TestAccNetworkConnectivityTransport_networkConnectivityTransportBasicExample_Full

View the build log

---

Step 2: Recording Mode

Recording Mode	Replaying Rerun	Test Name
❌ Error · Log	-	TestAccNetworkConnectivityTransport_networkConnectivityTransportBasicExample
❌ Error · Log	-	TestAccNetworkConnectivityTransport_networkConnectivityTransportBasicExample_Full

Caution

Issues requiring attention before PR completion

🔴 Manual Verification Required: New tests were added that are skipped in presubmit tests. See the "Manual Verification Required" section at the top for details.

🔴 Initial Recording Failed: Some tests failed during the recording step. See the table above for details.

Please address these issues to complete your PR. If you believe these detections are incorrect or unrelated to your change, please raise the concern with your reviewer.

View the build log or the debug logs folder for detailed results.

@abhijeetkjha-google, @NickElliot VCR tests complete for d476c0b!

[modular-magician]

Hi there, I'm the Modular magician. I've detected the following information about your changes for commit 16d0bd2:

Diff report

Your PR generated the following diffs in downstream repositories:

Repository	Diff Link	Changes
google provider	View Diff	6 files changed, 1517 insertions(+), 12 deletions(-)
google-beta provider	View Diff	3 files changed, 11 insertions(+), 33 deletions(-)
Open in Cloud Shell	View Diff	4 files changed, 118 insertions(+)

Test report

Important

Manual Verification Required (GA-only additions)

The following tests are GA-only additions and cannot be run by VCR in Beta mode. Please verify them manually:

🔴 TestAccNetworkConnectivityTransport_networkConnectivityTransportBasicExample
🔴 TestAccNetworkConnectivityTransport_networkConnectivityTransportBasicExample_Full

Analytics

Total Tests	Passed	Skipped	Affected
39	36	1	2

Affected Service Packages

• networkconnectivity

Learn how VCR tests work

---

Step 1: Replaying Mode

Action taken

Found 2 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit. Click here to see the affected tests

• TestAccNetworkConnectivityTransport_networkConnectivityTransportBasicExample
• TestAccNetworkConnectivityTransport_networkConnectivityTransportBasicExample_Full

View the build log

---

Step 2: Recording Mode

Recording Mode	Replaying Rerun	Test Name
✅ Log	✅	TestAccNetworkConnectivityTransport_networkConnectivityTransportBasicExample_Full
❌ Error · Log	-	TestAccNetworkConnectivityTransport_networkConnectivityTransportBasicExample

Caution

Issues requiring attention before PR completion

🔴 Manual Verification Required: New tests were added that are skipped in presubmit tests. See the "Manual Verification Required" section at the top for details.

🔴 Initial Recording Failed: Some tests failed during the recording step. See the table above for details.

Please address these issues to complete your PR. If you believe these detections are incorrect or unrelated to your change, please raise the concern with your reviewer.

View the build log or the debug logs folder for detailed results.

@abhijeetkjha-google, @NickElliot VCR tests complete for 16d0bd2!

[modular-magician]

Hi there, I'm the Modular magician. I've detected the following information about your changes for commit 77f4216:

Diff report

Your PR generated the following diffs in downstream repositories:

Repository	Diff Link	Changes
google provider	View Diff	6 files changed, 1520 insertions(+), 11 deletions(-)
google-beta provider	View Diff	3 files changed, 13 insertions(+), 31 deletions(-)
Open in Cloud Shell	View Diff	4 files changed, 120 insertions(+)

Test report

Important

Manual Verification Required (GA-only additions)

The following tests are GA-only additions and cannot be run by VCR in Beta mode. Please verify them manually:

🔴 TestAccNetworkConnectivityTransport_networkConnectivityTransportBasicExample
🔴 TestAccNetworkConnectivityTransport_networkConnectivityTransportBasicExample_Full

Analytics

Total Tests	Passed	Skipped	Affected
39	37	1	1

Affected Service Packages

• networkconnectivity

Learn how VCR tests work

---

Step 1: Replaying Mode

Action taken

Found 1 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit. Click here to see the affected tests

• TestAccNetworkConnectivityTransport_networkConnectivityTransportBasicExample

View the build log

---

Step 2: Recording Mode

Recording Mode	Replaying Rerun	Test Name
✅ Log	✅	TestAccNetworkConnectivityTransport_networkConnectivityTransportBasicExample

Caution

Issues requiring attention before PR completion

🔴 Manual Verification Required: New tests were added that are skipped in presubmit tests. See the "Manual Verification Required" section at the top for details.

Please address these issues to complete your PR. If you believe these detections are incorrect or unrelated to your change, please raise the concern with your reviewer.

View the build log or the debug logs folder for detailed results.

@abhijeetkjha-google, @NickElliot VCR tests complete for 77f4216!

[NickElliot]

the tests are failing when ran against ga:

------- Stdout: -------
=== RUN TestAccNetworkConnectivityTransport_networkConnectivityTransportBasicExample
=== PAUSE TestAccNetworkConnectivityTransport_networkConnectivityTransportBasicExample
=== CONT TestAccNetworkConnectivityTransport_networkConnectivityTransportBasicExample
resource_network_connectivity_transport_generated_test.go:66: Step 1/3 error: Error running apply: exit status 1
Error: Error creating Transport: googleapi: Error 400: Invalid JSON payload received. Unknown name "adminEnabled" at 'transport': Cannot find field.
Invalid JSON payload received. Unknown name "autoAccept" at 'transport': Cannot find field.
Invalid JSON payload received. Unknown name "pscRoutingEnabled" at 'transport': Cannot find field.
Details:
[
{
"@type": "type.googleapis.com/google.rpc.BadRequest",
"fieldViolations": [
{
"description": "Invalid JSON payload received. Unknown name "adminEnabled" at 'transport': Cannot find field.",
"field": "transport"
},
{
"description": "Invalid JSON payload received. Unknown name "autoAccept" at 'transport': Cannot find field.",
"field": "transport"
},
{
"description": "Invalid JSON payload received. Unknown name "pscRoutingEnabled" at 'transport': Cannot find field.",
"field": "transport"
}
]
}
]

do you have any logs of these passing locally?