Skip to content

Updating terraform doc to add note that name of target_instance field…#17456

Open
aditikumarii-google wants to merge 1 commit intoGoogleCloudPlatform:mainfrom
aditikumarii-google:doc_changes
Open

Updating terraform doc to add note that name of target_instance field…#17456
aditikumarii-google wants to merge 1 commit intoGoogleCloudPlatform:mainfrom
aditikumarii-google:doc_changes

Conversation

@aditikumarii-google
Copy link
Copy Markdown
Contributor

sql: added notes in doc samples to nofify uses that `target_resource` is mandatory field and the target_resource name should match the name of the resource being created.

Doc - https://docs.google.com/document/d/10UBI5l64MmmzV4ghZGMzSNLiNWrMMM1sKfMrVtlAO5o/edit?resourcekey=0-O3iT087a3Jl7FXYU9heTWg&tab=t.0

@github-actions github-actions Bot requested a review from NickElliot May 7, 2026 09:46
@github-actions
Copy link
Copy Markdown

github-actions Bot commented May 7, 2026

Googlers: For automatic test runs see go/terraform-auto-test-runs.

@NickElliot, a repository maintainer, has been assigned to review your changes. If you have not received review feedback within 2 business days, please leave a comment on this PR asking them to take a look.

You can help make sure that review is quick by doing a self-review and by running impacted tests locally.

@modular-magician
Copy link
Copy Markdown
Collaborator

Hi there, I'm the Modular magician. I've detected the following information about your changes for commit 487e02b:

Diff report

Your PR generated the following diffs in downstream repositories:

Repository Diff Link Changes
google provider View Diff 1 file changed, 4 insertions(+), 4 deletions(-)
google-beta provider View Diff 1 file changed, 4 insertions(+), 4 deletions(-)

Copy link
Copy Markdown
Contributor

@NickElliot NickElliot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM but are there plans to make these requirements enforced at plantime when breaking changes are being accepted in the next release?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants