Skip to content

Add field to control propagation of Firebase AI Logic Prompt Templates#17463

Open
tanzimfh wants to merge 2 commits intoGoogleCloudPlatform:mainfrom
tanzimfh:main
Open

Add field to control propagation of Firebase AI Logic Prompt Templates#17463
tanzimfh wants to merge 2 commits intoGoogleCloudPlatform:mainfrom
tanzimfh:main

Conversation

@tanzimfh
Copy link
Copy Markdown
Contributor

@tanzimfh tanzimfh commented May 7, 2026

This adds an optional boolean field regional_propagation_disabled to the PromptTemplate and PromptTemplateLock resources. By default, any operation on a PromptTemplate in the global location is replicated on all Cloud regions where possible. This new field allows expert users to disable that behavior if they want to work with PromptTemplates in global only.

Part of http://b/496979779

Release Note Template for Downstream PRs (will be copied)

firebaseailogic: added `regional_propagation_disabled` field to `google_firebase_ai_logic_prompt_template` and `google_firebase_ai_logic_prompt_template_lock` resources (beta)

@modular-magician
Copy link
Copy Markdown
Collaborator

modular-magician commented May 7, 2026

Hi there, I'm the Modular magician. I've detected the following information about your changes for commit e7e8e22:

Diff report

Your PR generated the following diffs in downstream repositories:

Repository Diff Link Changes
google provider View Diff 2 files changed, 57 insertions(+)
google-beta provider View Diff 10 files changed, 196 insertions(+), 15 deletions(-)

Breaking Change(s) Detected

The following breaking change(s) were detected within your pull request.

  • Field regional_propagation_disabled added as optional with a default value and force new on pre-existing resource google_firebase_ai_logic_prompt_template_lock. This can be allowed if there is a confirmed API-level default that matches the schema default - reference

If you believe this detection to be incorrect please raise the concern with your reviewer.
If you intend to make this change you will need to wait for a major release window.
An override-breaking-change label can be added to allow merging.

Test report

Analytics

Total Tests Passed Skipped Affected
12 3 0 9
Affected Service Packages
  • firebaseailogic

Learn how VCR tests work


Step 1: Replaying Mode

Action taken

Found 9 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit. Click here to see the affected tests
  • TestAccFirebaseAILogicPromptTemplateLock_firebaseailogicPromptTemplateLockBasicExample
  • TestAccFirebaseAILogicPromptTemplateLock_firebaseailogicPromptTemplateLockGlobalOnlyExample
  • TestAccFirebaseAILogicPromptTemplate_firebaseailogicPromptTemplateBasicExample
  • TestAccFirebaseAILogicPromptTemplate_firebaseailogicPromptTemplateComplexUpdate
  • TestAccFirebaseAILogicPromptTemplate_firebaseailogicPromptTemplateFileExample
  • TestAccFirebaseAILogicPromptTemplate_firebaseailogicPromptTemplateGlobalOnlyExample
  • TestAccFirebaseAILogicPromptTemplate_firebaseailogicPromptTemplateLockedUpdateError
  • TestAccFirebaseAILogicPromptTemplate_firebaseailogicPromptTemplateUpdate
  • TestAccFirebaseAILogicPromptTemplate_regional

View the build log


Step 2: Recording Mode

Recording Mode Replaying Rerun Test Name
✅ Log TestAccFirebaseAILogicPromptTemplateLock_firebaseailogicPromptTemplateLockBasicExample
✅ Log TestAccFirebaseAILogicPromptTemplateLock_firebaseailogicPromptTemplateLockGlobalOnlyExample
✅ Log TestAccFirebaseAILogicPromptTemplate_firebaseailogicPromptTemplateBasicExample
✅ Log TestAccFirebaseAILogicPromptTemplate_firebaseailogicPromptTemplateComplexUpdate
✅ Log TestAccFirebaseAILogicPromptTemplate_firebaseailogicPromptTemplateFileExample
✅ Log TestAccFirebaseAILogicPromptTemplate_firebaseailogicPromptTemplateGlobalOnlyExample
✅ Log TestAccFirebaseAILogicPromptTemplate_firebaseailogicPromptTemplateLockedUpdateError
✅ Log TestAccFirebaseAILogicPromptTemplate_firebaseailogicPromptTemplateUpdate
✅ Log TestAccFirebaseAILogicPromptTemplate_regional

🟢 All tests passed!

View the build log or the debug logs folder for detailed results.

@tanzimfh, @jacksonic VCR tests complete for e7e8e22!

@modular-magician modular-magician requested a review from jacksonic May 7, 2026 20:44
@tanzimfh tanzimfh marked this pull request as ready for review May 8, 2026 14:16
@github-actions github-actions Bot requested a review from zli82016 May 8, 2026 14:17
@github-actions
Copy link
Copy Markdown

github-actions Bot commented May 8, 2026

Googlers: For automatic test runs see go/terraform-auto-test-runs.

@zli82016, a repository maintainer, has been assigned to review your changes. If you have not received review feedback within 2 business days, please leave a comment on this PR asking them to take a look.

You can help make sure that review is quick by doing a self-review and by running impacted tests locally.

@tanzimfh
Copy link
Copy Markdown
Contributor Author

tanzimfh commented May 8, 2026

IIUC, the breaking change warning is because adding an immutable field (immutability inherited from the prompt_template_lock resource) with a default value that's different than the API's is a breaking change. Our API's default for this field is indeed also false.

@tanzimfh
Copy link
Copy Markdown
Contributor Author

tanzimfh commented May 8, 2026

Hey @rainshen49, could I please get a review?

Comment thread mmv1/products/firebaseailogic/PromptTemplateLock.yaml
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants